Skip to contentSkip to conversation

backlight: ktd253: Switch to use dev_err_probe() helper

PATCH RESEND Applied Yang Yingliang 3 participants 3 messages Sep 26, 2022 – Oct 24, 2022

Subsystems (3)
Framebuffer layer Backlight class/subsystem KTD253 backlight driver

v1 of 3 Applied Latest is v3 →

lore
Share & tools
lore

Yang Yingliang

author
#0 lore raw

PATCH RESEND 1/1 backlight: ktd253: Switch to use dev_err_probe() helper

In the probe path, dev_err() can be replaced with dev_err_probe() which will check if error code is -EPROBE_DEFER and prints the error name. It also sets the defer probe reason which can be checked later through debugfs. It's more simple in error path.

Signed-off-by Yang Yingliang <[email protected]>
Reviewed-by Daniel Thompson <[email protected]>

---
Resend for adding Sob.

---
 drivers/video/backlight/ktd253-backlight.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
drivers/video/backlight/ktd253-backlight.c +3 -6
index 37aa5a669530..d7d43454f64a 100644
@@ -173,12 +173,9 @@ static int ktd253_backlight_probe(struct platform_device *pdev)
 	}
 
 	ktd253->gpiod = devm_gpiod_get(dev, "enable", GPIOD_OUT_LOW);
-	if (IS_ERR(ktd253->gpiod)) {
-		ret = PTR_ERR(ktd253->gpiod);
-		if (ret != -EPROBE_DEFER)
-			dev_err(dev, "gpio line missing or invalid.\n");
-		return ret;
-	}
+	if (IS_ERR(ktd253->gpiod))
+		return dev_err_probe(dev, PTR_ERR(ktd253->gpiod),
+				     "gpio line missing or invalid.\n");
 	gpiod_set_consumer_name(ktd253->gpiod, dev_name(dev));
 	/* Bring backlight to a known off state */
 	msleep(KTD253_T_OFF_MS);
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Yang Yingliang

In the probe path, dev_err() can be replaced with dev_err_probe() which will check if error code is -EPROBE_DEFER and prints the error name. It also sets the defer probe reason which can be checked later through debugfs. It's more simple in error path.

Signed-off-by Yang Yingliang <[email protected]>
Reviewed-by Daniel Thompson <[email protected]>
Reviewed-by Linus Walleij <[email protected]>

Yours,
Linus Walleij

maintainer Applied
#2 lore raw
In reply to Yang Yingliang
Quoted 5 lines · Yang Yingliang

In the probe path, dev_err() can be replaced with dev_err_probe() which will check if error code is -EPROBE_DEFER and prints the error name. It also sets the defer probe reason which can be checked later through debugfs. It's more simple in error path.

Quoted 7 lines
Signed-off-by Yang Yingliang <[email protected]>
Reviewed-by Daniel Thompson <[email protected]>

---
Resend for adding Sob.

---
 drivers/video/backlight/ktd253-backlight.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

Applied, thanks.

Signature · 1 line
Lee Jones [李琼斯]