linux/container_of.h: Warn about loss of constness
PATCH v2 1/1 linux/container_of.h: Warn about loss of constness
container_of() casts the original type to another which leads to the loss of the const qualifier if it is not specified in the caller-provided type. This easily leads to container_of() returning a non-const pointer to a const struct which the C compiler does not warn about.
Signed-off-by Sakari Ailus <[email protected]>
--- include/linux/container_of.h | 1 + 1 file changed, 1 insertion(+)
include/linux/container_of.h +1 -0
@@ -13,6 +13,7 @@* @type: the type of the container struct this is embedded in. * @member: the name of the member within the struct. * +* WARNING: any const qualifier of @ptr is lost. */ #define container_of (ptr, type, member) ({ \ void *__mptr = (void *)(ptr); \
Signature · 1 line
2.30.2
Quoted 4 lines · Sakari Ailus
container_of()casts the original type to another which leads to the loss of the const qualifier if it is not specified in the caller-provided type. This easily leads tocontainer_of()returning a non-const pointer to a const struct which the C compiler does not warn about.
Acked-by Andy Shevchenko <[email protected]>
Quoted 20 lines
Signed-off-by Sakari Ailus <[email protected]>--- include/linux/container_of.h | 1 + 1 file changed, 1 insertion(+)include/linux/container_of.h +1
-0@@ -13,6 +13,7 @@* @type: the type of the container struct this is embedded in. * @member: the name of the member within the struct. * +* WARNING: any const qualifier of @ptr is lost. */ #define container_of (ptr, type, member) ({ \ void *__mptr = (void *)(ptr); \Signature · 1 line
2.30.2
Signature · 2 lines
With Best Regards, Andy Shevchenko