mm: /proc/pid/smaps_rollup: fix no vma's null-deref
PATCH 1/1 mm: /proc/pid/smaps_rollup: fix no vma's null-deref
Commit 258f669e7e88 ("mm: /proc/pid/smaps_rollup: convert to single value seq_file") introduced a null-deref if there are no vma's in the task in show_smaps_rollup.
---c4c84f06285e on upstream resolves this issue as part of the switch to using maple trees for VMA lookups, but a fix must still be applied to stable trees 4.19-5.19.
fs/proc/task_mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/proc/task_mmu.c +1 -1
@@ -969,7 +969,7 @@ static int show_smaps_rollup(struct seq_file *m, void *v) vma = vma->vm_next; } -show_vma_header_prefix (m, priv->mm->mmap->vm_start, +show_vma_header_prefix (m, priv->mm->mmap ? priv->mm->mmap->vm_start :0 , last_vma_end,0 ,0 ,0 ,0 );seq_pad (m,' ' );seq_puts (m,"[rollup]\n" );
Signature · 1 line
2.38.0.rc1.362.ged0d419d3c-goog
Quoted 4 lines · Seth Jenkins
Commit
258f669e7e88("mm:/proc/pid/smaps_rollup: convert to single valueseq_file") introduced a null-deref if there are no vma's in the task inshow_smaps_rollup.
Quoted 8 lines
Fixes 258f669e7e88 ("mm: /proc/pid/smaps_rollup: convert to single value seq_file")Signed-off-by Seth Jenkins <[email protected]>Reviewed-by Alexey Dobriyan <[email protected]>Tested-by Alexey Dobriyan <[email protected]>---
c4c84f06285eon upstream resolves this issue as part of the switch to using maple trees for VMA lookups, but a fix must still be applied to stable trees 4.19-5.19.
Now queued up, thanks.
greg k-h