iio: accel: bma400: Ensure VDDIO is enable defore reading the chip ID.
Subsystems (2)
Jonathan Cameron
maintainerPATCH 1/1 iio: accel: bma400: Ensure VDDIO is enable defore reading the chip ID.
From: Jonathan Cameron <[email protected]>
The regulator enables were after the check on the chip variant, which was very unlikely to return a correct value when not powered. Presumably all the device anyone is testing on have a regulator that is already powered up when this code runs for reasons beyond the scope of this driver. Move the read call down a few lines.
--- drivers/iio/accel/bma400_core.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-)
drivers/iio/accel/bma400_core.c +12 -12
@@ -869,18 +869,6 @@ static int bma400_init(struct bma400_data *data)unsigned int val;int ret; -/* Try to read chip_id register. It must return 0x90. */ - ret =regmap_read (data->regmap,BMA400_CHIP_ID_REG , &val); -if (ret) { -dev_err (data->dev,"Failed to read chip id register\n" ); -return ret; - } - -if (val !=BMA400_ID_REG_VAL ) { -dev_err (data->dev,"Chip ID mismatch\n" ); -return -ENODEV ; - } - data->regulators[BMA400_VDD_REGULATOR ].supply ="vdd" ; data->regulators[BMA400_VDDIO_REGULATOR ].supply ="vddio" ; ret = devm_regulator_bulk_get(data->dev,
@@ -902,6 +890,18 @@ static int bma400_init(struct bma400_data *data)if (ret)return ret; +/* Try to read chip_id register. It must return 0x90. */ + ret =regmap_read (data->regmap,BMA400_CHIP_ID_REG , &val); +if (ret) { +dev_err (data->dev,"Failed to read chip id register\n" ); +return ret; + } + +if (val !=BMA400_ID_REG_VAL ) { +dev_err (data->dev,"Chip ID mismatch\n" ); +return -ENODEV ; + } + ret =bma400_get_power_mode (data);if (ret) {dev_err (data->dev,"Failed to get the initial power-mode\n" );
Signature · 1 line
2.37.2
Quoted 10 lines · Jonathan Cameron
From: Jonathan Cameron <[email protected]>
The regulator enables were after the check on the chip variant, which was very unlikely to return a correct value when not powered. Presumably all the device anyone is testing on have a regulator that is already powered up when this code runs for reasons beyond the scope of this driver. Move the read call down a few lines.
Fixes 3cf7ded15e40 ("iio: accel: bma400: basic regulator support")Signed-off-by Jonathan Cameron <[email protected]>
Thanks for catching this!
Cheers,
- Dan
Quoted 9 lines · On Fri, 28 Oct 2022 13:07:47 +0000 Dan Robertson <[email protected]> wrote:
Quoted 8 lines · Jonathan Cameron
From: Jonathan Cameron <[email protected]>
The regulator enables were after the check on the chip variant, which was very unlikely to return a correct value when not powered. Presumably all the device anyone is testing on have a regulator that is already powered up when this code runs for reasons beyond the scope of this driver. Move the read call down a few lines.
Quoted 6 lines
Quoted 2 lines
Fixes 3cf7ded15e40 ("iio: accel: bma400: basic regulator support")Signed-off-by Jonathan Cameron <[email protected]>Reviewed-by Dan Robertson <[email protected]>Thanks for catching this!
Applied to the fixes-togreg branch of iio.git and marked for stable.
Thanks,
Jonathan
Quoted 4 lines
Cheers,
- Dan