Skip to contentSkip to conversation

ARM: s3c64xx: include header defining input event codes

PATCH In review Dmitry Torokhov 2 participants 2 messages Oct 28, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: s3c64xx: include header defining input event codes

The board file for Wolfson Cragganmore 6410 uses various KEY_* defines, but does not include the relevant header directly and instead relies on other headers to include it indirectly. With the upcoming cleanup of matrix_keypad.h this indirection is now broken and we should include the relevant header directly.

---

If possible I'd like to get this through input tree so I can take another stab at landing matrix_keypad.h patch.

 arch/arm/mach-s3c/mach-crag6410.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-s3c/mach-crag6410.c +1 -0
index 9a45474d1bf7..2ecb85856e24 100644
@@ -14,6 +14,7 @@
 #include <linux/fb.h>
 #include <linux/io.h>
 #include <linux/init.h>
+#include <linux/input-event-codes.h>
 #include <linux/gpio.h>
 #include <linux/gpio/machine.h>
 #include <linux/leds.h>
Signature · 5 lines
2.38.1.273.g43a17bfeac-goog


-- 
Dmitry
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Dmitry Torokhov

The board file for Wolfson Cragganmore 6410 uses various KEY_* defines, but does not include the relevant header directly and instead relies on other headers to include it indirectly. With the upcoming cleanup of matrix_keypad.h this indirection is now broken and we should include the relevant header directly.

Quoted 7 lines

---

If possible I'd like to get this through input tree so I can take another stab at landing matrix_keypad.h patch.

Should be fine, although there is a risk of potential conflict with Arnd's patches if he changes something more in v2. v1 was non-conflicting, at first glance.

Best regards,
Krzysztof