Skip to contentSkip to conversation

staging: rtl8192e: Remove line breaks to match coding style

PATCH Superseded Gabhyun Kim 2 participants 2 messages Nov 1, 2022 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8192e: Remove line breaks to match coding style

Remove redundant line breaks between function definitions to correct the coding style

---
 drivers/staging/rtl8192e/rtllib_softmac.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/staging/rtl8192e/rtllib_softmac.c +1 -4
index 1a3ca3e57623..78828ecac28a 100644
@@ -22,7 +22,6 @@
 
 static void rtllib_sta_wakeup(struct rtllib_device *ieee, short nl);
 
-
 static short rtllib_is_54g(struct rtllib_network *net)
 {
 	return (net->rates_ex_len > 0) || (net->rates_len > 4);
@@ -147,9 +146,7 @@ static void init_mgmt_queue(struct rtllib_device *ieee)
 	ieee->mgmt_queue_tail = ieee->mgmt_queue_head = 0;
 }
 
-
-u8
-MgntQuery_TxRateExcludeCCKRates(struct rtllib_device *ieee)
+u8 MgntQuery_TxRateExcludeCCKRates(struct rtllib_device *ieee)
 {
 	u16	i;
 	u8	QueryRate = 0;
Signature · 1 line
2.25.1
maintainer
#1 lore raw
Quoted 1 line · Gabhyun Kim

Remove redundant line breaks between function definitions to correct the coding style

Nit, your changelog text is too wide, please properly wrap your lines at 72 columns.

Quoted 19 lines
---
 drivers/staging/rtl8192e/rtllib_softmac.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/staging/rtl8192e/rtllib_softmac.c +0 -1
index 1a3ca3e57623..78828ecac28a 100644
@@ -22,7 +22,6 @@
 
 static void rtllib_sta_wakeup(struct rtllib_device *ieee, short nl);
 
-
 static short rtllib_is_54g(struct rtllib_network *net)
 {
 	return (net->rates_ex_len > 0) || (net->rates_len > 4);

drivers/staging/rtl8192e/rtllib_softmac.c static void init_mgmt_queue(struct rtllib_device *ieee) · line 150

Quoted 8 lines
drivers/staging/rtl8192e/rtllib_softmac.c +1 -3
@@ -147,9 +146,7 @@ static void init_mgmt_queue(struct rtllib_device *ieee)
 	ieee->mgmt_queue_tail = ieee->mgmt_queue_head = 0;
 }
 
-
-u8
-MgntQuery_TxRateExcludeCCKRates(struct rtllib_device *ieee)
+u8 MgntQuery_TxRateExcludeCCKRates(struct rtllib_device *ieee)
 {

You are doing two different types of things here, please only do one "logical" type of thing at a time in a patch.

thanks,

greg k-h