drm/amd/display: add parameter backlight_min
Subsystems (3)
PATCH 1/1 drm/amd/display: add parameter backlight_min
There are some devices on which amdgpu won't allow user to set brightness to sufficiently low values even though the hardware would support it just fine.
This usually happens in two cases when either configuration of brightness levels via ACPI/ATIF is not available and amdgpu falls back to defaults (currently 12 for minimum level) which may be too high for some devices or even the configuration via ATIF is available but the minimum brightness level provided by the manufacturer is set to unreasonably high value.
In either case user can use this new module parameter to adjust the minimum allowed backlight brightness level.
--- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 15 +++++++++++++++ drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 15 +++++++++++++++ 3 files changed, 33 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu.h +3 -0
@@ -200,6 +200,9 @@ extern uint amdgpu_dc_debug_mask;extern uint amdgpu_dc_visual_confirm;extern uint amdgpu_dm_abm_level;extern int amdgpu_backlight; +#ifdef CONFIG_DRM_AMD_DC +extern int amdgpu_backlight_override_min[]; +#endif extern struct amdgpu_mgpu_info mgpu_info;extern int amdgpu_ras_enable;extern uint amdgpu_ras_mask;
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +15 -0
@@ -43,6 +43,7 @@#include "amdgpu_irq.h" #include "amdgpu_dma_buf.h" #include "amdgpu_sched.h" +#include "amdgpu_dm.h" #include "amdgpu_fdinfo.h" #include "amdgpu_amdkfd.h"
@@ -853,6 +854,20 @@ int amdgpu_backlight = -1;MODULE_PARM_DESC (backlight,"Backlight control (0 = pwm, 1 = aux, -1 auto (default))" );module_param_named (backlight, amdgpu_backlight, bint,0444 ); +/** +* DOC: backlight_min (array of int) +* Override minimum allowed backlight brightness signal (per display). +* Must be less than the maximum brightness signal. +* Negative value means no override. +* +* Defaults to all -1 (no override on any display). +*/ +#ifdef CONFIG_DRM_AMD_DC +int amdgpu_backlight_override_min[AMDGPU_DM_MAX_NUM_EDP ] = {[0 ... (AMDGPU_DM_MAX_NUM_EDP -1 )] =-1 }; +MODULE_PARM_DESC (backlight_min,"Override minimum backlight brightness signal (0..max-1, -1 = no override (default))" ); +module_param_array_named (backlight_min, amdgpu_backlight_override_min, int,NULL ,0444 ); +#endif +/** * DOC: tmz (int) * Trusted Memory Zone (TMZ) is a method to protect data being written
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +15 -0
@@ -3911,6 +3911,21 @@ static void amdgpu_dm_update_backlight_caps(struct amdgpu_display_manager *dm, dm->backlight_caps[bl_idx].min_input_signal =AMDGPU_DM_DEFAULT_MIN_BACKLIGHT ; dm->backlight_caps[bl_idx].max_input_signal =AMDGPU_DM_DEFAULT_MAX_BACKLIGHT ;#endif + +if (amdgpu_backlight_override_min[bl_idx] >=0 ) { +if (amdgpu_backlight_override_min[bl_idx] < dm->backlight_caps[bl_idx].max_input_signal) { +DRM_INFO ("amdgpu: backlight[%i]: overriding minimum brightness from %i to %i\n" , + bl_idx, + dm->backlight_caps[bl_idx].min_input_signal, + amdgpu_backlight_override_min[bl_idx]); + dm->backlight_caps[bl_idx].min_input_signal = amdgpu_backlight_override_min[bl_idx]; + }else { +DRM_ERROR ("amdgpu: backlight[%i]: minimum brightness override (%i) is not below maximum (%i)\n" , + bl_idx, + amdgpu_backlight_override_min[bl_idx], + dm->backlight_caps[bl_idx].max_input_signal); + } + } } static int get_brightness_range(const struct amdgpu_dm_backlight_caps *caps,
base-commit: d8c03bfe146fd5e081a252cd34f3f12ca0255357
Signature · 1 line
2.30.2
Quoted 4 lines · Filip Moc
There are some devices on which amdgpu won't allow user to set brightness to sufficiently low values even though the hardware would support it just fine.
Quoted 9 lines
This usually happens in two cases when either configuration of brightness levels via ACPI/ATIF is not available and amdgpu falls back to defaults (currently 12 for minimum level) which may be too high for some devices or even the configuration via ATIF is available but the minimum brightness level provided by the manufacturer is set to unreasonably high value.
In either case user can use this new module parameter to adjust the minimum allowed backlight brightness level.
Thanks for this patch and covering all the bases.
It might be useful to have an example in the commit description on how to set the array property. I assume it looks like this if I wanted to set the first device to a minimum of 2 and leave the default for the 2nd one:
amdgpu.backlight_min=2:-1
Either way, this patch is
Harry
Quoted 83 lines
Signed-off-by Filip Moc <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 15 +++++++++++++++ drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 15 +++++++++++++++ 3 files changed, 33 insertions(+)drivers/gpu/drm/amd/amdgpu/amdgpu.h +3
-0@@ -200,6 +200,9 @@ extern uint amdgpu_dc_debug_mask;extern uint amdgpu_dc_visual_confirm;extern uint amdgpu_dm_abm_level;extern int amdgpu_backlight; +#ifdef CONFIG_DRM_AMD_DC +extern int amdgpu_backlight_override_min[]; +#endif extern struct amdgpu_mgpu_info mgpu_info;extern int amdgpu_ras_enable;extern uint amdgpu_ras_mask;drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +15
-0@@ -43,6 +43,7 @@#include "amdgpu_irq.h" #include "amdgpu_dma_buf.h" #include "amdgpu_sched.h" +#include "amdgpu_dm.h" #include "amdgpu_fdinfo.h" #include "amdgpu_amdkfd.h" @@ -853,6 +854,20 @@ int amdgpu_backlight = -1;MODULE_PARM_DESC (backlight,"Backlight control (0 = pwm, 1 = aux, -1 auto (default))" );module_param_named (backlight, amdgpu_backlight, bint,0444 ); +/** +* DOC: backlight_min (array of int) +* Override minimum allowed backlight brightness signal (per display). +* Must be less than the maximum brightness signal. +* Negative value means no override. +* +* Defaults to all -1 (no override on any display). +*/ +#ifdef CONFIG_DRM_AMD_DC +int amdgpu_backlight_override_min[AMDGPU_DM_MAX_NUM_EDP ] = {[0 ... (AMDGPU_DM_MAX_NUM_EDP -1 )] =-1 }; +MODULE_PARM_DESC (backlight_min,"Override minimum backlight brightness signal (0..max-1, -1 = no override (default))" ); +module_param_array_named (backlight_min, amdgpu_backlight_override_min, int,NULL ,0444 ); +#endif +/** * DOC: tmz (int) * Trusted Memory Zone (TMZ) is a method to protect data being written drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +15
-0@@ -3911,6 +3911,21 @@ static void amdgpu_dm_update_backlight_caps(struct amdgpu_display_manager *dm, dm->backlight_caps[bl_idx].min_input_signal =AMDGPU_DM_DEFAULT_MIN_BACKLIGHT ; dm->backlight_caps[bl_idx].max_input_signal =AMDGPU_DM_DEFAULT_MAX_BACKLIGHT ;#endif + +if (amdgpu_backlight_override_min[bl_idx] >=0 ) { +if (amdgpu_backlight_override_min[bl_idx] < dm->backlight_caps[bl_idx].max_input_signal) { +DRM_INFO ("amdgpu: backlight[%i]: overriding minimum brightness from %i to %i\n" , + bl_idx, + dm->backlight_caps[bl_idx].min_input_signal, + amdgpu_backlight_override_min[bl_idx]); + dm->backlight_caps[bl_idx].min_input_signal = amdgpu_backlight_override_min[bl_idx]; + }else { +DRM_ERROR ("amdgpu: backlight[%i]: minimum brightness override (%i) is not below maximum (%i)\n" , + bl_idx, + amdgpu_backlight_override_min[bl_idx], + dm->backlight_caps[bl_idx].max_input_signal); + } + } } static int get_brightness_range(const struct amdgpu_dm_backlight_caps *caps,base-commit:
d8c03bfe146fd5e081a252cd34f3f12ca0255357
Hello Harry,
thank you for your response.
Quoted 1 line
amdgpu.backlight_min=2:-1
almost :-)
Array elements in module parameters are separated by commas not colons. So for cmdline it should look like this:
amdgpu.backlight_min=2,-1
Though you can just drop the ,-1 relying on kernel leaving the rest of array untouched. Which I would recommend as there is no point for user to follow AMDGPU_DM_MAX_NUM_EDP.
Only when you need to override some other display than display 0 then you may need to use -1. E.g. backlight_min=-1,2 overrides display 1 to min backlight=2 while keeping display 0 with no override.
When amdgpu is loaded as a kernel module, backlight_min can also be passed as a parameter to modprobe, e.g.:
modprobe backlight_min=2
So in that case you probably want to add something like
options amdgpu backlight_min=2 to /etc/modprobe.d/amdgpu.conf
(and also run update-initramfs if amdgpu is loaded by initramfs).
I'll add some examples to commit message in v2.
Filip
V Mon, Oct 31, 2022 at 10:24:25AM -0400, Harry Wentland napsal(a):
Quoted 113 lines · Filip Moc
Quoted 4 lines
There are some devices on which amdgpu won't allow user to set brightness to sufficiently low values even though the hardware would support it just fine.
Quoted 9 lines
This usually happens in two cases when either configuration of brightness levels via ACPI/ATIF is not available and amdgpu falls back to defaults (currently 12 for minimum level) which may be too high for some devices or even the configuration via ATIF is available but the minimum brightness level provided by the manufacturer is set to unreasonably high value.
In either case user can use this new module parameter to adjust the minimum allowed backlight brightness level.
Thanks for this patch and covering all the bases.
It might be useful to have an example in the commit description on how to set the array property. I assume it looks like this if I wanted to set the first device to a minimum of 2 and leave the default for the 2nd one:
amdgpu.backlight_min=2:-1
Either way, this patch is
Reviewed-by Harry Wentland <[email protected]>Harry
Quoted 83 lines
Signed-off-by Filip Moc <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 15 +++++++++++++++ drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 15 +++++++++++++++ 3 files changed, 33 insertions(+)drivers/gpu/drm/amd/amdgpu/amdgpu.h +3
-0@@ -200,6 +200,9 @@ extern uint amdgpu_dc_debug_mask;extern uint amdgpu_dc_visual_confirm;extern uint amdgpu_dm_abm_level;extern int amdgpu_backlight; +#ifdef CONFIG_DRM_AMD_DC +extern int amdgpu_backlight_override_min[]; +#endif extern struct amdgpu_mgpu_info mgpu_info;extern int amdgpu_ras_enable;extern uint amdgpu_ras_mask;drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +15
-0@@ -43,6 +43,7 @@#include "amdgpu_irq.h" #include "amdgpu_dma_buf.h" #include "amdgpu_sched.h" +#include "amdgpu_dm.h" #include "amdgpu_fdinfo.h" #include "amdgpu_amdkfd.h" @@ -853,6 +854,20 @@ int amdgpu_backlight = -1;MODULE_PARM_DESC (backlight,"Backlight control (0 = pwm, 1 = aux, -1 auto (default))" );module_param_named (backlight, amdgpu_backlight, bint,0444 ); +/** +* DOC: backlight_min (array of int) +* Override minimum allowed backlight brightness signal (per display). +* Must be less than the maximum brightness signal. +* Negative value means no override. +* +* Defaults to all -1 (no override on any display). +*/ +#ifdef CONFIG_DRM_AMD_DC +int amdgpu_backlight_override_min[AMDGPU_DM_MAX_NUM_EDP ] = {[0 ... (AMDGPU_DM_MAX_NUM_EDP -1 )] =-1 }; +MODULE_PARM_DESC (backlight_min,"Override minimum backlight brightness signal (0..max-1, -1 = no override (default))" ); +module_param_array_named (backlight_min, amdgpu_backlight_override_min, int,NULL ,0444 ); +#endif +/** * DOC: tmz (int) * Trusted Memory Zone (TMZ) is a method to protect data being written drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +15
-0@@ -3911,6 +3911,21 @@ static void amdgpu_dm_update_backlight_caps(struct amdgpu_display_manager *dm, dm->backlight_caps[bl_idx].min_input_signal =AMDGPU_DM_DEFAULT_MIN_BACKLIGHT ; dm->backlight_caps[bl_idx].max_input_signal =AMDGPU_DM_DEFAULT_MAX_BACKLIGHT ;#endif + +if (amdgpu_backlight_override_min[bl_idx] >=0 ) { +if (amdgpu_backlight_override_min[bl_idx] < dm->backlight_caps[bl_idx].max_input_signal) { +DRM_INFO ("amdgpu: backlight[%i]: overriding minimum brightness from %i to %i\n" , + bl_idx, + dm->backlight_caps[bl_idx].min_input_signal, + amdgpu_backlight_override_min[bl_idx]); + dm->backlight_caps[bl_idx].min_input_signal = amdgpu_backlight_override_min[bl_idx]; + }else { +DRM_ERROR ("amdgpu: backlight[%i]: minimum brightness override (%i) is not below maximum (%i)\n" , + bl_idx, + amdgpu_backlight_override_min[bl_idx], + dm->backlight_caps[bl_idx].max_input_signal); + } + } } static int get_brightness_range(const struct amdgpu_dm_backlight_caps *caps,base-commit:
d8c03bfe146fd5e081a252cd34f3f12ca0255357
Harry Wentland
maintainerQuoted 19 lines · Filip Moc
Hello Harry,
thank you for your response.
Quoted 1 line
amdgpu.backlight_min=2:-1
almost :-)
Array elements in module parameters are separated by commas not colons. So for cmdline it should look like this:
amdgpu.backlight_min=2,-1Though you can just drop the ,-1 relying on kernel leaving the rest of array untouched. Which I would recommend as there is no point for user to follow
AMDGPU_DM_MAX_NUM_EDP.
Only when you need to override some other display than display 0 then you may need to use -1. E.g. backlight_min=-1,2 overrides display 1 to min backlight=2 while keeping display 0 with no override.
Quoted 9 lines
When amdgpu is loaded as a kernel module,
backlight_mincan also be passed as a parameter to modprobe, e.g.:
modprobe backlight_min=2
So in that case you probably want to add something like
options amdgpu backlight_min=2 to/etc/modprobe.d/amdgpu.conf
(and also run update-initramfs if amdgpu is loaded by initramfs).I'll add some examples to commit message in v2.
Awesome. Thanks.
Harry
Quoted 117 lines
Filip
V Mon, Oct 31, 2022 at 10:24:25AM -0400, Harry Wentland napsal(a):
Quoted 113 lines · Filip Moc
Quoted 4 lines
There are some devices on which amdgpu won't allow user to set brightness to sufficiently low values even though the hardware would support it just fine.
Quoted 9 lines
This usually happens in two cases when either configuration of brightness levels via ACPI/ATIF is not available and amdgpu falls back to defaults (currently 12 for minimum level) which may be too high for some devices or even the configuration via ATIF is available but the minimum brightness level provided by the manufacturer is set to unreasonably high value.
In either case user can use this new module parameter to adjust the minimum allowed backlight brightness level.
Thanks for this patch and covering all the bases.
It might be useful to have an example in the commit description on how to set the array property. I assume it looks like this if I wanted to set the first device to a minimum of 2 and leave the default for the 2nd one:
amdgpu.backlight_min=2:-1
Either way, this patch is
Reviewed-by Harry Wentland <[email protected]>Harry
Quoted 83 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 15 +++++++++++++++ drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 15 +++++++++++++++ 3 files changed, 33 insertions(+)drivers/gpu/drm/amd/amdgpu/amdgpu.h +3
-0@@ -200,6 +200,9 @@ extern uint amdgpu_dc_debug_mask;extern uint amdgpu_dc_visual_confirm;extern uint amdgpu_dm_abm_level;extern int amdgpu_backlight; +#ifdef CONFIG_DRM_AMD_DC +extern int amdgpu_backlight_override_min[]; +#endif extern struct amdgpu_mgpu_info mgpu_info;extern int amdgpu_ras_enable;extern uint amdgpu_ras_mask;drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +15
-0@@ -43,6 +43,7 @@#include "amdgpu_irq.h" #include "amdgpu_dma_buf.h" #include "amdgpu_sched.h" +#include "amdgpu_dm.h" #include "amdgpu_fdinfo.h" #include "amdgpu_amdkfd.h" @@ -853,6 +854,20 @@ int amdgpu_backlight = -1;MODULE_PARM_DESC (backlight,"Backlight control (0 = pwm, 1 = aux, -1 auto (default))" );module_param_named (backlight, amdgpu_backlight, bint,0444 ); +/** +* DOC: backlight_min (array of int) +* Override minimum allowed backlight brightness signal (per display). +* Must be less than the maximum brightness signal. +* Negative value means no override. +* +* Defaults to all -1 (no override on any display). +*/ +#ifdef CONFIG_DRM_AMD_DC +int amdgpu_backlight_override_min[AMDGPU_DM_MAX_NUM_EDP ] = {[0 ... (AMDGPU_DM_MAX_NUM_EDP -1 )] =-1 }; +MODULE_PARM_DESC (backlight_min,"Override minimum backlight brightness signal (0..max-1, -1 = no override (default))" ); +module_param_array_named (backlight_min, amdgpu_backlight_override_min, int,NULL ,0444 ); +#endif +/** * DOC: tmz (int) * Trusted Memory Zone (TMZ) is a method to protect data being written drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +15
-0@@ -3911,6 +3911,21 @@ static void amdgpu_dm_update_backlight_caps(struct amdgpu_display_manager *dm, dm->backlight_caps[bl_idx].min_input_signal =AMDGPU_DM_DEFAULT_MIN_BACKLIGHT ; dm->backlight_caps[bl_idx].max_input_signal =AMDGPU_DM_DEFAULT_MAX_BACKLIGHT ;#endif + +if (amdgpu_backlight_override_min[bl_idx] >=0 ) { +if (amdgpu_backlight_override_min[bl_idx] < dm->backlight_caps[bl_idx].max_input_signal) { +DRM_INFO ("amdgpu: backlight[%i]: overriding minimum brightness from %i to %i\n" , + bl_idx, + dm->backlight_caps[bl_idx].min_input_signal, + amdgpu_backlight_override_min[bl_idx]); + dm->backlight_caps[bl_idx].min_input_signal = amdgpu_backlight_override_min[bl_idx]; + }else { +DRM_ERROR ("amdgpu: backlight[%i]: minimum brightness override (%i) is not below maximum (%i)\n" , + bl_idx, + amdgpu_backlight_override_min[bl_idx], + dm->backlight_caps[bl_idx].max_input_signal); + } + } } static int get_brightness_range(const struct amdgpu_dm_backlight_caps *caps,base-commit:
d8c03bfe146fd5e081a252cd34f3f12ca0255357
Quoted 11 lines · Filip Moc
There are some devices on which amdgpu won't allow user to set brightness to sufficiently low values even though the hardware would support it just fine.
This usually happens in two cases when either configuration of brightness levels via ACPI/ATIF is not available and amdgpu falls back to defaults (currently 12 for minimum level) which may be too high for some devices or even the configuration via ATIF is available but the minimum brightness level provided by the manufacturer is set to unreasonably high value.
Quoted 5 lines
In either case user can use this new module parameter to adjust the minimum allowed backlight brightness level.
Does your system require an override and if so, what is it? It would be good to add a quirk for your system as well so that other users of the same system wouldn't need to manually figure out an apply the settings.
Alex
Quoted 84 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 15 +++++++++++++++ drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 15 +++++++++++++++ 3 files changed, 33 insertions(+)drivers/gpu/drm/amd/amdgpu/amdgpu.h +3
-0@@ -200,6 +200,9 @@ extern uint amdgpu_dc_debug_mask;extern uint amdgpu_dc_visual_confirm;extern uint amdgpu_dm_abm_level;extern int amdgpu_backlight; +#ifdef CONFIG_DRM_AMD_DC +extern int amdgpu_backlight_override_min[]; +#endif extern struct amdgpu_mgpu_info mgpu_info;extern int amdgpu_ras_enable;extern uint amdgpu_ras_mask;drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +15
-0@@ -43,6 +43,7 @@#include "amdgpu_irq.h" #include "amdgpu_dma_buf.h" #include "amdgpu_sched.h" +#include "amdgpu_dm.h" #include "amdgpu_fdinfo.h" #include "amdgpu_amdkfd.h" @@ -853,6 +854,20 @@ int amdgpu_backlight = -1;MODULE_PARM_DESC (backlight,"Backlight control (0 = pwm, 1 = aux, -1 auto (default))" );module_param_named (backlight, amdgpu_backlight, bint,0444 ); +/** +* DOC: backlight_min (array of int) +* Override minimum allowed backlight brightness signal (per display). +* Must be less than the maximum brightness signal. +* Negative value means no override. +* +* Defaults to all -1 (no override on any display). +*/ +#ifdef CONFIG_DRM_AMD_DC +int amdgpu_backlight_override_min[AMDGPU_DM_MAX_NUM_EDP ] = {[0 ... (AMDGPU_DM_MAX_NUM_EDP -1 )] =-1 }; +MODULE_PARM_DESC (backlight_min,"Override minimum backlight brightness signal (0..max-1, -1 = no override (default))" ); +module_param_array_named (backlight_min, amdgpu_backlight_override_min, int,NULL ,0444 ); +#endif +/** * DOC: tmz (int) * Trusted Memory Zone (TMZ) is a method to protect data being written drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +15
-0@@ -3911,6 +3911,21 @@ static void amdgpu_dm_update_backlight_caps(struct amdgpu_display_manager *dm, dm->backlight_caps[bl_idx].min_input_signal =AMDGPU_DM_DEFAULT_MIN_BACKLIGHT ; dm->backlight_caps[bl_idx].max_input_signal =AMDGPU_DM_DEFAULT_MAX_BACKLIGHT ;#endif + +if (amdgpu_backlight_override_min[bl_idx] >=0 ) { +if (amdgpu_backlight_override_min[bl_idx] < dm->backlight_caps[bl_idx].max_input_signal) { +DRM_INFO ("amdgpu: backlight[%i]: overriding minimum brightness from %i to %i\n" , + bl_idx, + dm->backlight_caps[bl_idx].min_input_signal, + amdgpu_backlight_override_min[bl_idx]); + dm->backlight_caps[bl_idx].min_input_signal = amdgpu_backlight_override_min[bl_idx]; + }else { +DRM_ERROR ("amdgpu: backlight[%i]: minimum brightness override (%i) is not below maximum (%i)\n" , + bl_idx, + amdgpu_backlight_override_min[bl_idx], + dm->backlight_caps[bl_idx].max_input_signal); + } + } } static int get_brightness_range(const struct amdgpu_dm_backlight_caps *caps,base-commit:
d8c03bfe146fd5e081a252cd34f3f12ca0255357--
2.30.2
Hello Alex,
thank you for your response.
Yes, I have HP ENVY x360 Convertible 13-ay1xxx, and backlight_min=2 seems to work the best in my case.
I added a dmi based quirk table. So far with support only for display 0 to make it simple. Support for more displays in quirk table can be added later if ever needed.
According to [1] HP ENVY x360 Convertible 13-ag0xxx also needs a quirk so I'm going to use this to cover both:DMI_EXACT_MATCH(DMI_SYS_VENDOR, "HP") DMI_MATCH(DMI_PRODUCT_NAME, "HP ENVY x360 Convertible 13-")
So far it seems to be working fine.
I'll send this in v2 once I do some final tweaks and do more tests.
[1] https://bugzilla.kernel.org/show_bug.cgi?id=203439#c5
Filip
V Mon, Oct 31, 2022 at 11:36:09AM -0400, Alex Deucher napsal(a):
Quoted 110 lines · Filip Moc
Quoted 11 lines
There are some devices on which amdgpu won't allow user to set brightness to sufficiently low values even though the hardware would support it just fine.
This usually happens in two cases when either configuration of brightness levels via ACPI/ATIF is not available and amdgpu falls back to defaults (currently 12 for minimum level) which may be too high for some devices or even the configuration via ATIF is available but the minimum brightness level provided by the manufacturer is set to unreasonably high value.
Quoted 5 lines
In either case user can use this new module parameter to adjust the minimum allowed backlight brightness level.
Does your system require an override and if so, what is it? It would be good to add a quirk for your system as well so that other users of the same system wouldn't need to manually figure out an apply the settings.
Alex
Quoted 84 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 15 +++++++++++++++ drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 15 +++++++++++++++ 3 files changed, 33 insertions(+)drivers/gpu/drm/amd/amdgpu/amdgpu.h +3
-0@@ -200,6 +200,9 @@ extern uint amdgpu_dc_debug_mask;extern uint amdgpu_dc_visual_confirm;extern uint amdgpu_dm_abm_level;extern int amdgpu_backlight; +#ifdef CONFIG_DRM_AMD_DC +extern int amdgpu_backlight_override_min[]; +#endif extern struct amdgpu_mgpu_info mgpu_info;extern int amdgpu_ras_enable;extern uint amdgpu_ras_mask;drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +15
-0@@ -43,6 +43,7 @@#include "amdgpu_irq.h" #include "amdgpu_dma_buf.h" #include "amdgpu_sched.h" +#include "amdgpu_dm.h" #include "amdgpu_fdinfo.h" #include "amdgpu_amdkfd.h" @@ -853,6 +854,20 @@ int amdgpu_backlight = -1;MODULE_PARM_DESC (backlight,"Backlight control (0 = pwm, 1 = aux, -1 auto (default))" );module_param_named (backlight, amdgpu_backlight, bint,0444 ); +/** +* DOC: backlight_min (array of int) +* Override minimum allowed backlight brightness signal (per display). +* Must be less than the maximum brightness signal. +* Negative value means no override. +* +* Defaults to all -1 (no override on any display). +*/ +#ifdef CONFIG_DRM_AMD_DC +int amdgpu_backlight_override_min[AMDGPU_DM_MAX_NUM_EDP ] = {[0 ... (AMDGPU_DM_MAX_NUM_EDP -1 )] =-1 }; +MODULE_PARM_DESC (backlight_min,"Override minimum backlight brightness signal (0..max-1, -1 = no override (default))" ); +module_param_array_named (backlight_min, amdgpu_backlight_override_min, int,NULL ,0444 ); +#endif +/** * DOC: tmz (int) * Trusted Memory Zone (TMZ) is a method to protect data being written drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +15
-0@@ -3911,6 +3911,21 @@ static void amdgpu_dm_update_backlight_caps(struct amdgpu_display_manager *dm, dm->backlight_caps[bl_idx].min_input_signal =AMDGPU_DM_DEFAULT_MIN_BACKLIGHT ; dm->backlight_caps[bl_idx].max_input_signal =AMDGPU_DM_DEFAULT_MAX_BACKLIGHT ;#endif + +if (amdgpu_backlight_override_min[bl_idx] >=0 ) { +if (amdgpu_backlight_override_min[bl_idx] < dm->backlight_caps[bl_idx].max_input_signal) { +DRM_INFO ("amdgpu: backlight[%i]: overriding minimum brightness from %i to %i\n" , + bl_idx, + dm->backlight_caps[bl_idx].min_input_signal, + amdgpu_backlight_override_min[bl_idx]); + dm->backlight_caps[bl_idx].min_input_signal = amdgpu_backlight_override_min[bl_idx]; + }else { +DRM_ERROR ("amdgpu: backlight[%i]: minimum brightness override (%i) is not below maximum (%i)\n" , + bl_idx, + amdgpu_backlight_override_min[bl_idx], + dm->backlight_caps[bl_idx].max_input_signal); + } + } } static int get_brightness_range(const struct amdgpu_dm_backlight_caps *caps,base-commit:
d8c03bfe146fd5e081a252cd34f3f12ca0255357--
2.30.2
Quoted 8 lines · Filip Moc
Hello Alex,
thank you for your response.
Yes, I have HP ENVY x360 Convertible 13-ay1xxx, and backlight_min=2 seems to work the best in my case.
Quoted 8 lines
I added a dmi based quirk table. So far with support only for display 0 to make it simple. Support for more displays in quirk table can be added later if ever needed.
According to [1] HP ENVY x360 Convertible 13-ag0xxx also needs a quirk so I'm going to use this to cover both:
DMI_EXACT_MATCH(DMI_SYS_VENDOR, "HP")DMI_MATCH(DMI_PRODUCT_NAME, "HP ENVY x360 Convertible 13-")
You might want to add an additional check for the panel name/vendor from the EDID as well in case HP uses multiple panels from different vendors on that system.
Alex
Quoted 120 lines
So far it seems to be working fine.
I'll send this in v2 once I do some final tweaks and do more tests.[1] https://bugzilla.kernel.org/show_bug.cgi?id=203439#c5
Filip
V Mon, Oct 31, 2022 at 11:36:09AM -0400, Alex Deucher napsal(a):
Quoted 110 lines · Filip Moc
Quoted 11 lines
There are some devices on which amdgpu won't allow user to set brightness to sufficiently low values even though the hardware would support it just fine.
This usually happens in two cases when either configuration of brightness levels via ACPI/ATIF is not available and amdgpu falls back to defaults (currently 12 for minimum level) which may be too high for some devices or even the configuration via ATIF is available but the minimum brightness level provided by the manufacturer is set to unreasonably high value.
Quoted 5 lines
In either case user can use this new module parameter to adjust the minimum allowed backlight brightness level.
Does your system require an override and if so, what is it? It would be good to add a quirk for your system as well so that other users of the same system wouldn't need to manually figure out an apply the settings.
Alex
Quoted 84 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 15 +++++++++++++++ drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 15 +++++++++++++++ 3 files changed, 33 insertions(+)drivers/gpu/drm/amd/amdgpu/amdgpu.h +3
-0@@ -200,6 +200,9 @@ extern uint amdgpu_dc_debug_mask;extern uint amdgpu_dc_visual_confirm;extern uint amdgpu_dm_abm_level;extern int amdgpu_backlight; +#ifdef CONFIG_DRM_AMD_DC +extern int amdgpu_backlight_override_min[]; +#endif extern struct amdgpu_mgpu_info mgpu_info;extern int amdgpu_ras_enable;extern uint amdgpu_ras_mask;drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +15
-0@@ -43,6 +43,7 @@#include "amdgpu_irq.h" #include "amdgpu_dma_buf.h" #include "amdgpu_sched.h" +#include "amdgpu_dm.h" #include "amdgpu_fdinfo.h" #include "amdgpu_amdkfd.h" @@ -853,6 +854,20 @@ int amdgpu_backlight = -1;MODULE_PARM_DESC (backlight,"Backlight control (0 = pwm, 1 = aux, -1 auto (default))" );module_param_named (backlight, amdgpu_backlight, bint,0444 ); +/** +* DOC: backlight_min (array of int) +* Override minimum allowed backlight brightness signal (per display). +* Must be less than the maximum brightness signal. +* Negative value means no override. +* +* Defaults to all -1 (no override on any display). +*/ +#ifdef CONFIG_DRM_AMD_DC +int amdgpu_backlight_override_min[AMDGPU_DM_MAX_NUM_EDP ] = {[0 ... (AMDGPU_DM_MAX_NUM_EDP -1 )] =-1 }; +MODULE_PARM_DESC (backlight_min,"Override minimum backlight brightness signal (0..max-1, -1 = no override (default))" ); +module_param_array_named (backlight_min, amdgpu_backlight_override_min, int,NULL ,0444 ); +#endif +/** * DOC: tmz (int) * Trusted Memory Zone (TMZ) is a method to protect data being written drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +15
-0@@ -3911,6 +3911,21 @@ static void amdgpu_dm_update_backlight_caps(struct amdgpu_display_manager *dm, dm->backlight_caps[bl_idx].min_input_signal =AMDGPU_DM_DEFAULT_MIN_BACKLIGHT ; dm->backlight_caps[bl_idx].max_input_signal =AMDGPU_DM_DEFAULT_MAX_BACKLIGHT ;#endif + +if (amdgpu_backlight_override_min[bl_idx] >=0 ) { +if (amdgpu_backlight_override_min[bl_idx] < dm->backlight_caps[bl_idx].max_input_signal) { +DRM_INFO ("amdgpu: backlight[%i]: overriding minimum brightness from %i to %i\n" , + bl_idx, + dm->backlight_caps[bl_idx].min_input_signal, + amdgpu_backlight_override_min[bl_idx]); + dm->backlight_caps[bl_idx].min_input_signal = amdgpu_backlight_override_min[bl_idx]; + }else { +DRM_ERROR ("amdgpu: backlight[%i]: minimum brightness override (%i) is not below maximum (%i)\n" , + bl_idx, + amdgpu_backlight_override_min[bl_idx], + dm->backlight_caps[bl_idx].max_input_signal); + } + } } static int get_brightness_range(const struct amdgpu_dm_backlight_caps *caps,base-commit:
d8c03bfe146fd5e081a252cd34f3f12ca0255357--
2.30.2
Quoted 13 lines · Alex Deucher
Quoted 12 lines · Filip Moc
Hello Alex,
thank you for your response.
Yes, I have HP ENVY x360 Convertible 13-ay1xxx, and backlight_min=2 seems to work the best in my case.
I added a dmi based quirk table. So far with support only for display 0 to make it simple. Support for more displays in quirk table can be added later if ever needed.
Quoted 8 lines
Quoted 4 lines
According to [1] HP ENVY x360 Convertible 13-ag0xxx also needs a quirk so I'm going to use this to cover both:
DMI_EXACT_MATCH(DMI_SYS_VENDOR, "HP")DMI_MATCH(DMI_PRODUCT_NAME, "HP ENVY x360 Convertible 13-")You might want to add an additional check for the panel name/vendor from the EDID as well in case HP uses multiple panels from different vendors on that system.
Hello,
thank you for this feedback.
I agree it would be nice to have this additional check but I'm not sure if there is an easy way to do this.
I don't think we can add this to the EDID quirk table in drm_edid.c as we also need to store the value for backlight min_input_signal. There might also be different laptop manufacturers using the same panel which only one of them needs a quirk or both of them might need a quirk but with different value. Or there also might be more devices with the same DMI but different panels where each panel needs a quirk with different value.
So it seems if we want to cover all possible situations we need a nested quirk tables for this. One main table for DMI matches where each record would contain another table for EDID matches.
Then there's also a question of how to obtain the EDID.
The most simple and straightforward approach seems to be getting the EDID vendor/product identification from dc_edid_caps. But this seems to be going completely against the goal 10. in display/TODO.
So another approach I'm considering is to use drm_edid_get_panel_id but for that we would need a pointer to i2c_adapter for the corresponding backlight_link. Which I think is currently only available via amdgpu_dm_connector which from dc_link is only accessible via void *priv. Which seems like something that shouldn't be touched here.
So overall I don't know what would be the best way to implement this. It also seems too complex I'm not even sure if it's worth the trouble and maybe just hoping there won't be any two devices with the same DMI but different EDID which only one of them would need a quirk while the other would break with it might seem more reasonable.
Or maybe I'm missing something?
Please let me know what you think.
Filip
Quoted 123 lines
Alex
Quoted 120 lines
So far it seems to be working fine.
I'll send this in v2 once I do some final tweaks and do more tests.[1] https://bugzilla.kernel.org/show_bug.cgi?id=203439#c5
Filip
V Mon, Oct 31, 2022 at 11:36:09AM -0400, Alex Deucher napsal(a):
Quoted 110 lines · Filip Moc
Quoted 11 lines
There are some devices on which amdgpu won't allow user to set brightness to sufficiently low values even though the hardware would support it just fine.
This usually happens in two cases when either configuration of brightness levels via ACPI/ATIF is not available and amdgpu falls back to defaults (currently 12 for minimum level) which may be too high for some devices or even the configuration via ATIF is available but the minimum brightness level provided by the manufacturer is set to unreasonably high value.
Quoted 5 lines
In either case user can use this new module parameter to adjust the minimum allowed backlight brightness level.
Does your system require an override and if so, what is it? It would be good to add a quirk for your system as well so that other users of the same system wouldn't need to manually figure out an apply the settings.
Alex
Quoted 84 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 15 +++++++++++++++ drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 15 +++++++++++++++ 3 files changed, 33 insertions(+)drivers/gpu/drm/amd/amdgpu/amdgpu.h +3
-0@@ -200,6 +200,9 @@ extern uint amdgpu_dc_debug_mask;extern uint amdgpu_dc_visual_confirm;extern uint amdgpu_dm_abm_level;extern int amdgpu_backlight; +#ifdef CONFIG_DRM_AMD_DC +extern int amdgpu_backlight_override_min[]; +#endif extern struct amdgpu_mgpu_info mgpu_info;extern int amdgpu_ras_enable;extern uint amdgpu_ras_mask;drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +15
-0@@ -43,6 +43,7 @@#include "amdgpu_irq.h" #include "amdgpu_dma_buf.h" #include "amdgpu_sched.h" +#include "amdgpu_dm.h" #include "amdgpu_fdinfo.h" #include "amdgpu_amdkfd.h" @@ -853,6 +854,20 @@ int amdgpu_backlight = -1;MODULE_PARM_DESC (backlight,"Backlight control (0 = pwm, 1 = aux, -1 auto (default))" );module_param_named (backlight, amdgpu_backlight, bint,0444 ); +/** +* DOC: backlight_min (array of int) +* Override minimum allowed backlight brightness signal (per display). +* Must be less than the maximum brightness signal. +* Negative value means no override. +* +* Defaults to all -1 (no override on any display). +*/ +#ifdef CONFIG_DRM_AMD_DC +int amdgpu_backlight_override_min[AMDGPU_DM_MAX_NUM_EDP ] = {[0 ... (AMDGPU_DM_MAX_NUM_EDP -1 )] =-1 }; +MODULE_PARM_DESC (backlight_min,"Override minimum backlight brightness signal (0..max-1, -1 = no override (default))" ); +module_param_array_named (backlight_min, amdgpu_backlight_override_min, int,NULL ,0444 ); +#endif +/** * DOC: tmz (int) * Trusted Memory Zone (TMZ) is a method to protect data being written drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +15
-0@@ -3911,6 +3911,21 @@ static void amdgpu_dm_update_backlight_caps(struct amdgpu_display_manager *dm, dm->backlight_caps[bl_idx].min_input_signal =AMDGPU_DM_DEFAULT_MIN_BACKLIGHT ; dm->backlight_caps[bl_idx].max_input_signal =AMDGPU_DM_DEFAULT_MAX_BACKLIGHT ;#endif + +if (amdgpu_backlight_override_min[bl_idx] >=0 ) { +if (amdgpu_backlight_override_min[bl_idx] < dm->backlight_caps[bl_idx].max_input_signal) { +DRM_INFO ("amdgpu: backlight[%i]: overriding minimum brightness from %i to %i\n" , + bl_idx, + dm->backlight_caps[bl_idx].min_input_signal, + amdgpu_backlight_override_min[bl_idx]); + dm->backlight_caps[bl_idx].min_input_signal = amdgpu_backlight_override_min[bl_idx]; + }else { +DRM_ERROR ("amdgpu: backlight[%i]: minimum brightness override (%i) is not below maximum (%i)\n" , + bl_idx, + amdgpu_backlight_override_min[bl_idx], + dm->backlight_caps[bl_idx].max_input_signal); + } + } } static int get_brightness_range(const struct amdgpu_dm_backlight_caps *caps,base-commit:
d8c03bfe146fd5e081a252cd34f3f12ca0255357--
2.30.2