memory: tegra20-emc: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE
Subsystems (2)
PATCH 1/1 memory: tegra20-emc: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE
Fix the following coccicheck warning:
drivers/memory/tegra/tegra20-emc.c:902:0-23: WARNING:
tegra_emc_debug_max_rate_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE
drivers/memory/tegra/tegra20-emc.c:872:0-23: WARNING:
tegra_emc_debug_min_rate_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE
--- drivers/memory/tegra/tegra20-emc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/memory/tegra/tegra20-emc.c +2 -2
@@ -869,7 +869,7 @@ static int tegra_emc_debug_min_rate_set(void *data, u64 rate)return 0 ; } -DEFINE_SIMPLE_ATTRIBUTE (tegra_emc_debug_min_rate_fops, +DEFINE_DEBUGFS_ATTRIBUTE (tegra_emc_debug_min_rate_fops, tegra_emc_debug_min_rate_get, tegra_emc_debug_min_rate_set,"%llu\n" );
@@ -899,7 +899,7 @@ static int tegra_emc_debug_max_rate_set(void *data, u64 rate)return 0 ; } -DEFINE_SIMPLE_ATTRIBUTE (tegra_emc_debug_max_rate_fops, +DEFINE_DEBUGFS_ATTRIBUTE (tegra_emc_debug_max_rate_fops, tegra_emc_debug_max_rate_get, tegra_emc_debug_max_rate_set,"%llu\n" );
Signature · 1 line
2.27.0
Quoted 10 lines · Bo Liu
Fix the following coccicheck warning:
drivers/memory/tegra/tegra20-emc.c:902:0-23: WARNING:
tegra_emc_debug_max_rate_fopsshould be defined withDEFINE_DEBUGFS_ATTRIBUTE
drivers/memory/tegra/tegra20-emc.c:872:0-23: WARNING:
tegra_emc_debug_min_rate_fopsshould be defined withDEFINE_DEBUGFS_ATTRIBUTESigned-off-by Bo Liu <[email protected]>--- drivers/memory/tegra/tegra20-emc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
This seems incomplete: the rationale in that debugfs cocci script says that DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe() is the pattern to use vs. the less efficient DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file(). So this patch should probably use the unsafe function variant at the same time to take full advantage.
Thierry
Quoted 26 lines
drivers/memory/tegra/tegra20-emc.c +2
-2@@ -869,7 +869,7 @@ static int tegra_emc_debug_min_rate_set(void *data, u64 rate)return 0 ; } -DEFINE_SIMPLE_ATTRIBUTE (tegra_emc_debug_min_rate_fops, +DEFINE_DEBUGFS_ATTRIBUTE (tegra_emc_debug_min_rate_fops, tegra_emc_debug_min_rate_get, tegra_emc_debug_min_rate_set,"%llu\n" );@@ -899,7 +899,7 @@ static int tegra_emc_debug_max_rate_set(void *data, u64 rate)return 0 ; } -DEFINE_SIMPLE_ATTRIBUTE (tegra_emc_debug_max_rate_fops, +DEFINE_DEBUGFS_ATTRIBUTE (tegra_emc_debug_max_rate_fops, tegra_emc_debug_max_rate_get, tegra_emc_debug_max_rate_set,"%llu\n" );Signature · 1 line
2.27.0
Quoted 12 lines · Thierry Reding
Quoted 10 lines · Bo Liu
Fix the following coccicheck warning:
drivers/memory/tegra/tegra20-emc.c:902:0-23: WARNING:
tegra_emc_debug_max_rate_fopsshould be defined withDEFINE_DEBUGFS_ATTRIBUTE
drivers/memory/tegra/tegra20-emc.c:872:0-23: WARNING:
tegra_emc_debug_min_rate_fopsshould be defined withDEFINE_DEBUGFS_ATTRIBUTESigned-off-by Bo Liu <[email protected]>--- drivers/memory/tegra/tegra20-emc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Quoted 5 lines
This seems incomplete: the rationale in that debugfs cocci script says that
DEFINE_DEBUGFS_ATTRIBUTE+debugfs_create_file_unsafe()is the pattern to use vs. the less efficientDEFINE_SIMPLE_ATTRIBUTE+debugfs_create_file(). So this patch should probably use the unsafe function variant at the same time to take full advantage.
That said, I'm not even sure if these attributes would qualify for debugfs_create_file_unsafe() since there's really no protection against removal.
Overall that cocci seems a bit misleading in that it makes these changes seem like trivial conversions. Only converting DEFINE_SIMPLE_ATTRIBUTE() to DEFINE_DEBUGFS_ATTRIBUTE() is basically a noop, except that debugfs has a little more overhead (for example debugfs_attr_read() wraps simple_attr_read()), so I'm not sure if that's worth doing on its own.
Thierry
Quoted 26 lines
Quoted 26 lines
drivers/memory/tegra/tegra20-emc.c +2
-2@@ -869,7 +869,7 @@ static int tegra_emc_debug_min_rate_set(void *data, u64 rate)return 0 ; } -DEFINE_SIMPLE_ATTRIBUTE (tegra_emc_debug_min_rate_fops, +DEFINE_DEBUGFS_ATTRIBUTE (tegra_emc_debug_min_rate_fops, tegra_emc_debug_min_rate_get, tegra_emc_debug_min_rate_set,"%llu\n" );@@ -899,7 +899,7 @@ static int tegra_emc_debug_max_rate_set(void *data, u64 rate)return 0 ; } -DEFINE_SIMPLE_ATTRIBUTE (tegra_emc_debug_max_rate_fops, +DEFINE_DEBUGFS_ATTRIBUTE (tegra_emc_debug_max_rate_fops, tegra_emc_debug_max_rate_get, tegra_emc_debug_max_rate_set,"%llu\n" );Signature · 1 line
2.27.0