Skip to contentSkip to conversation

Documentation: process: Describe kernel version prefix for third option

PATCH In review Bagas Sanjaya 2 participants 4 messages Nov 1, 2022 – Nov 2, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Documentation: process: Describe kernel version prefix for third option

The current wording on third option of stable kernel submission doesn't mention how to specify desired kernel version. Submitters reading the documentation could simply send multiple backported patches of the same upstream commit without any kernel version information, leaving stable maintainers and reviewers hard time to figure out the correct kernel version to be applied.

Describe the subject prefix for specifying kernel version for the case above.

---
This patch is sent as response to [1].

[1]: https://lore.kernel.org/stable/20221101074351.GA8310@amd/

 Documentation/process/stable-kernel-rules.rst | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Documentation/process/stable-kernel-rules.rst +3 -1
index 2fd8aa593a2851..409ae73c1ffcd1 100644
@@ -77,7 +77,9 @@ Option 3
 Send the patch, after verifying that it follows the above rules, to
 [email protected].  You must note the upstream commit ID in the
 changelog of your submission, as well as the kernel version you wish
-it to be applied to.
+it to be applied to by adding desired kernel version number to the
+patch subject prefix. For example, patches targeting 5.15 kernel should
+have ``[PATCH 5.15]`` prefix.
 
 :ref:`option_1` is **strongly** preferred, is the easiest and most common.
 :ref:`option_2` and :ref:`option_3` are more useful if the patch isn't deemed

base-commit: 30a0b95b1335e12efef89dd78518ed3e4a71a763

Signature · 1 line
An old man doll... just what I always wanted! - Clara
#1 lore raw
Quoted 25 lines · Bagas Sanjaya

The current wording on third option of stable kernel submission doesn't mention how to specify desired kernel version. Submitters reading the documentation could simply send multiple backported patches of the same upstream commit without any kernel version information, leaving stable maintainers and reviewers hard time to figure out the correct kernel version to be applied.

Describe the subject prefix for specifying kernel version for the case above.

---
This patch is sent as response to [1].

[1]: https://lore.kernel.org/stable/20221101074351.GA8310@amd/

 Documentation/process/stable-kernel-rules.rst | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Documentation/process/stable-kernel-rules.rst +0 -0
index 2fd8aa593a2851..409ae73c1ffcd1 100644

Documentation/process/stable-kernel-rules.rst Option 3 · line 82

Quoted 7 lines
Documentation/process/stable-kernel-rules.rst +3 -1
@@ -77,7 +77,9 @@ Option 3
 Send the patch, after verifying that it follows the above rules, to
 [email protected].  You must note the upstream commit ID in the
 changelog of your submission, as well as the kernel version you wish
-it to be applied to.
+it to be applied to by adding desired kernel version number to the
+patch subject prefix. For example, patches targeting 5.15 kernel should
+have ``[PATCH 5.15]`` prefix.

No, sorry, this is not needed and does not have to be in the subject line at all.

The current wording is fine, it's just that people don't always read it.

so consider this a NAK.

thanks,

greg k-h-

#2 lore raw
Quoted 8 lines · Greg Kroah-Hartman

No, sorry, this is not needed and does not have to be in the subject line at all.

The current wording is fine, it's just that people don't always read it.

so consider this a NAK.

Hi Greg,

There was a case when a submitter submitted multiple backports (which qualified for third option) without specifying the prefix, hence a reviewer complained [1].

[1]: https://lore.kernel.org/all/20221101074351.GA8310@amd/

Signature · 1 line
An old man doll... just what I always wanted! - Clara
#3 lore raw
Quoted 10 lines · Bagas Sanjaya
Quoted 8 lines · Greg Kroah-Hartman

No, sorry, this is not needed and does not have to be in the subject line at all.

The current wording is fine, it's just that people don't always read it.

so consider this a NAK.

Quoted 7 lines

Hi Greg,

There was a case when a submitter submitted multiple backports (which qualified for third option) without specifying the prefix, hence a reviewer complained [1].

[1]: https://lore.kernel.org/all/20221101074351.GA8310@amd/

Yes, and as I said on that thread, to you directly:
https://lore.kernel.org/all/[email protected]/
the submission was done correctly, no one should have complained, and the patches were applied by me to the correct branches without any problems at all.

This is not an issue, this change is not needed at all.

greg k-h