Input: edt-ft5x06 - replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE
Subsystems (2)
PATCH 1/1 Input: edt-ft5x06 - replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE
Fix the following coccicheck warning:
drivers/input/touchscreen/edt-ft5x06.c:756:0-23: WARNING:
debugfs_mode_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE
--- drivers/input/touchscreen/edt-ft5x06.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/touchscreen/edt-ft5x06.c +1 -1
@@ -753,7 +753,7 @@ static int edt_ft5x06_debugfs_mode_set(void *data, u64 mode)return retval; }; -DEFINE_SIMPLE_ATTRIBUTE (debugfs_mode_fops, edt_ft5x06_debugfs_mode_get, +DEFINE_DEBUGFS_ATTRIBUTE (debugfs_mode_fops, edt_ft5x06_debugfs_mode_get, edt_ft5x06_debugfs_mode_set,"%llu\n" ); static ssize_t edt_ft5x06_debugfs_raw_data_read(struct file *file,
Signature · 1 line
2.27.0
Quoted 9 lines
Am 01.11.2022 um 09:14 schrieb Bo Liu <[email protected]>:
Fix the following coccicheck warning:
drivers/input/touchscreen/edt-ft5x06.c:756:0-23: WARNING:
debugfs_mode_fopsshould be defined withDEFINE_DEBUGFS_ATTRIBUTESigned-off-by Bo Liu <[email protected]>
Quoted 20 lines
---
drivers/input/touchscreen/edt-ft5x06.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/input/touchscreen/edt-ft5x06.c +1
-1@@ -753,7 +753,7 @@ static int edt_ft5x06_debugfs_mode_set(void *data, u64 mode)return retval; }; -DEFINE_SIMPLE_ATTRIBUTE (debugfs_mode_fops, edt_ft5x06_debugfs_mode_get, +DEFINE_DEBUGFS_ATTRIBUTE (debugfs_mode_fops, edt_ft5x06_debugfs_mode_get, edt_ft5x06_debugfs_mode_set,"%llu\n" ); static ssize_t edt_ft5x06_debugfs_raw_data_read(struct file *file,Signature · 1 line
2.27.0
Dmitry Torokhov
maintainerHi Bo,
Quoted 3 lines · Bo Liu
Fix the following coccicheck warning:
drivers/input/touchscreen/edt-ft5x06.c:756:0-23: WARNING:
debugfs_mode_fopsshould be defined withDEFINE_DEBUGFS_ATTRIBUTE
This is not a great justification for a change. Could you please update the patch description to document why DEFINE_DEBUGFS_ATTRIBUTE is preferred over DEFINE_SIMPLE_ATTRIBUTE?
Quoted 22 lines
Signed-off-by Bo Liu <[email protected]>--- drivers/input/touchscreen/edt-ft5x06.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/input/touchscreen/edt-ft5x06.c +1
-1@@ -753,7 +753,7 @@ static int edt_ft5x06_debugfs_mode_set(void *data, u64 mode)return retval; }; -DEFINE_SIMPLE_ATTRIBUTE (debugfs_mode_fops, edt_ft5x06_debugfs_mode_get, +DEFINE_DEBUGFS_ATTRIBUTE (debugfs_mode_fops, edt_ft5x06_debugfs_mode_get, edt_ft5x06_debugfs_mode_set,"%llu\n" ); static ssize_t edt_ft5x06_debugfs_raw_data_read(struct file *file,Signature · 1 line
2.27.0
Thanks.
Signature · 1 line
Dmitry