Skip to contentSkip to conversation

staging: media: atomisp: make hive_int8 explictly signed

PATCH In review Jason A. Donenfeld 2 participants 2 messages Nov 3, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: media: atomisp: make hive_int8 explictly signed

The current definition of hive_int8 is a naked char, without any sign specifier. This is incorrect on platforms such as arm, where char is unsigned. Fortunately nothing in the kernel actually uses a hive_int8 type, but in case it gets used later rather than removed, this makes it explicitly signed.

Cc Mauro Carvalho Chehab <[email protected]>
Cc Sakari Ailus <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>

---
Greg - if you're going to take this for 6.1, that's fine with me. Otherwise, if it's for 6.2, I'll take this in my unsigned-char tree to keep all of these fixups together. -Jason

 drivers/staging/media/atomisp/pci/hive_types.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/atomisp/pci/hive_types.h +1 -1
index 4b8a679fb672..55d36931f079 100644
@@ -42,7 +42,7 @@ typedef unsigned int hive_bool;
 #define hive_false 0
 #define hive_true  1
 
-typedef char                 hive_int8;
+typedef signed char          hive_int8;
 typedef short                hive_int16;
 typedef int                  hive_int32;
 typedef long long            hive_int64;
Signature · 1 line
2.38.1
maintainer
#1 lore raw
Quoted 6 lines · Jason A. Donenfeld

The current definition of hive_int8 is a naked char, without any sign specifier. This is incorrect on platforms such as arm, where char is unsigned. Fortunately nothing in the kernel actually uses a hive_int8 type, but in case it gets used later rather than removed, this makes it explicitly signed.

Quoted 8 lines
Cc Mauro Carvalho Chehab <[email protected]>
Cc Sakari Ailus <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>

---
Greg - if you're going to take this for 6.1, that's fine with me. Otherwise, if it's for 6.2, I'll take this in my unsigned-char tree to keep all of these fixups together. -Jason

I don't take drivers/staging/media/* patches, they go through Mauro's tree, so I'll let him and you fight it out here :)

thanks,

greg k-h