Skip to contentSkip to conversation

phy: phy-brcm-usb: Utilize platform_get_irq_byname_optional()

PATCH Applied Florian Fainelli 3 participants 3 messages Oct 26, 2022 – Nov 5, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 phy: phy-brcm-usb: Utilize platform_get_irq_byname_optional()

The wake-up interrupt lines are entirely optional, avoid printing messages that interrupts were not found by switching to the _optional variant.

---
 drivers/phy/broadcom/phy-brcm-usb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/phy/broadcom/phy-brcm-usb.c +2 -2
index 2cb3779fcdf8..fbf454b206f2 100644
@@ -445,9 +445,9 @@ static int brcm_usb_phy_dvr_init(struct platform_device *pdev,
 		priv->suspend_clk = NULL;
 	}
 
-	priv->wake_irq = platform_get_irq_byname(pdev, "wake");
+	priv->wake_irq = platform_get_irq_byname_optional(pdev, "wake");
 	if (priv->wake_irq < 0)
-		priv->wake_irq = platform_get_irq_byname(pdev, "wakeup");
+		priv->wake_irq = platform_get_irq_byname_optional(pdev, "wakeup");
 	if (priv->wake_irq >= 0) {
 		err = devm_request_irq(dev, priv->wake_irq,
 				       brcm_usb_phy_wake_isr, 0,
Signature · 7 lines
2.25.1


-- 
linux-phy mailing list
[email protected]
https://lists.infradead.org/mailman/listinfo/linux-phy
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Florian Fainelli

The wake-up interrupt lines are entirely optional, avoid printing messages that interrupts were not found by switching to the _optional variant.

Quoted 23 lines
---
 drivers/phy/broadcom/phy-brcm-usb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/phy/broadcom/phy-brcm-usb.c +2 -3
index 2cb3779fcdf8..fbf454b206f2 100644
@@ -445,9 +445,9 @@ static int brcm_usb_phy_dvr_init(struct platform_device *pdev,
                priv->suspend_clk = NULL;
        }
 
-       priv->wake_irq = platform_get_irq_byname(pdev, "wake");
+       priv->wake_irq = platform_get_irq_byname_optional(pdev, "wake");
        if (priv->wake_irq < 0)
-               priv->wake_irq = platform_get_irq_byname(pdev, "wakeup");
+               priv->wake_irq = platform_get_irq_byname_optional(pdev, "wakeup");
        if (priv->wake_irq >= 0) {
                err = devm_request_irq(dev, priv->wake_irq,
                                       brcm_usb_phy_wake_isr, 0,
--

2.25.1

Signature · 3 lines
linux-phy mailing list
[email protected]
https://lists.infradead.org/mailman/listinfo/linux-phy
maintainer Applied
#2 lore raw
In reply to Florian Fainelli
Quoted 3 lines · Florian Fainelli

The wake-up interrupt lines are entirely optional, avoid printing messages that interrupts were not found by switching to the _optional variant.

Applied, thanks

Signature · 1 line
~Vinod