Skip to contentSkip to conversation

mirrors.bbclass: use shallow tarball for nativesdk-binutils

PATCH In review Etienne Cordonnier 2 participants 3 messages Nov 4, 2022 – Nov 7, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mirrors.bbclass: use shallow tarball for nativesdk-binutils

This is useful e.g. when using meta-clang, which introduces a dependency to nativesdk-binutils when populating the SDK, and then a full tarball of binutils is fetched additionally to a shallow tarball.

---
 meta/classes-global/mirrors.bbclass | 2 ++
 1 file changed, 2 insertions(+)
meta/classes-global/mirrors.bbclass +2 -0
index 81fef7f660..8b984de3bf 100644
@@ -91,6 +91,8 @@ BB_GIT_SHALLOW:pn-binutils-cross-canadian-${TRANSLATED_TARGET_ARCH} = "1"
 BB_GIT_SHALLOW:pn-binutils-cross-testsuite = "1"
 BB_GIT_SHALLOW:pn-binutils-crosssdk-${SDK_SYS} = "1"
 BB_GIT_SHALLOW:pn-binutils-native = "1"
+BB_GIT_SHALLOW:pn-nativesdk-binutils = "1"
+
 BB_GIT_SHALLOW:pn-glibc = "1"
 PREMIRRORS += "git://sourceware.org/git/glibc.git https://downloads.yoctoproject.org/mirror/sources/ \
               git://sourceware.org/git/binutils-gdb.git https://downloads.yoctoproject.org/mirror/sources/"
Signature · 1 line
2.36.1.vfs.0.0
#1 lore raw
Quoted 4 lines · Etienne Cordonnier via lists.openembedded.org

This is useful e.g. when using meta-clang, which introduces a dependency to nativesdk-binutils when populating the SDK, and then a full tarball of binutils is fetched additionally to a shallow tarball.

The SoB needs to match the author and sender. You are using two different addresses here.

Quoted 30 lines
---
 meta/classes-global/mirrors.bbclass | 2 ++
 1 file changed, 2 insertions(+)
meta/classes-global/mirrors.bbclass +2 -0
index 81fef7f660..8b984de3bf 100644
@@ -91,6 +91,8 @@ BB_GIT_SHALLOW:pn-binutils-cross-canadian-${TRANSLATED_TARGET_ARCH} = "1"
 BB_GIT_SHALLOW:pn-binutils-cross-testsuite = "1"
 BB_GIT_SHALLOW:pn-binutils-crosssdk-${SDK_SYS} = "1"
 BB_GIT_SHALLOW:pn-binutils-native = "1"
+BB_GIT_SHALLOW:pn-nativesdk-binutils = "1"
+
 BB_GIT_SHALLOW:pn-glibc = "1"
 PREMIRRORS += "git://sourceware.org/git/glibc.git https://downloads.yoctoproject.org/mirror/sources/ \
               git://sourceware.org/git/binutils-gdb.git https://downloads.yoctoproject.org/mirror/sources/"
Signature · 11 lines
2.36.1.vfs.0.0



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#172714): https://lists.openembedded.org/g/openembedded-core/message/172714
Mute This Topic: https://lists.openembedded.org/mt/94806491/3617179
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

I've resent the patch and changed git's sendemail.envelopesender option so that the From field matches the email used in the SOB field.

Quoted 60 lines · Alexandre Belloni
Quoted 1 line · Etienne Cordonnier via lists.openembedded.org

This is useful e.g. when using meta-clang, which introduces a dependency

to nativesdk-binutils when

Quoted 1 line

populating the SDK, and then a full tarball of binutils is fetched

additionally to a shallow tarball.

Quoted 2 lines

The SoB needs to match the author and sender. You are using two different addresses here.

Review

Quoted 5 lines
---
 meta/classes-global/mirrors.bbclass | 2 ++
 1 file changed, 2 insertions(+)
(quoted diff) +0 -0

b/meta/classes-global/mirrors.bbclass

meta/classes-global/mirrors.bbclass

Quoted 4 lines

index 81fef7f660..8b984de3bf 100644

meta/classes-global/mirrors.bbclass +0 -0
@@ -91,6 +91,8 @@

BB_GIT_SHALLOW:pn-binutils-cross-canadian-${TRANSLATED_TARGET_ARCH} = "1"

meta/classes-global/mirrors.bbclass BB_GIT_SHALLOW:pn-binutils-cross-canadian-${TRANSLATED_TARGET_ARCH} = "1"

Quoted 7 lines
meta/classes-global/mirrors.bbclass +2 -0
 BB_GIT_SHALLOW:pn-binutils-cross-testsuite = "1"
 BB_GIT_SHALLOW:pn-binutils-crosssdk-${SDK_SYS} = "1"
 BB_GIT_SHALLOW:pn-binutils-native = "1"
+BB_GIT_SHALLOW:pn-nativesdk-binutils = "1"
+
 BB_GIT_SHALLOW:pn-glibc = "1"
 PREMIRRORS += "git://sourceware.org/git/glibc.git

https://urldefense.proofpoint.com/v2/url?u=https-3A__downloads.yoctoproject.org_mirror_sources_&d=DwIBAg&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=ItIZIiBFvPUc7ha-blv_xFb0FMnb2T_GL7CNoIiQdZKZOHxwxi75uwo6Hol3J3TA&s=hk4_w8STTvGIN0VNAn2uzyYG_oOrycryBPA5-pYHAPg&e=
\

Quoted 8 lines

--
2.36.1.vfs.0.0

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#172714):

https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.openembedded.org_g_openembedded-2Dcore_message_172714&d=DwIBAg&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=ItIZIiBFvPUc7ha-blv_xFb0FMnb2T_GL7CNoIiQdZKZOHxwxi75uwo6Hol3J3TA&s=C08MKSdkpczwMDUBLU0lDwc6-divmgE89AHm-eHFcy0&e=

Quoted 1 line

Mute This Topic:

https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.openembedded.org_mt_94806491_3617179&d=DwIBAg&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=ItIZIiBFvPUc7ha-blv_xFb0FMnb2T_GL7CNoIiQdZKZOHxwxi75uwo6Hol3J3TA&s=aWDi_0FtVYrz0eG_bPJO0tqup8a5jLutsSoTa3Pynwk&e=

Quoted 2 lines

Group Owner: [email protected] Unsubscribe:

https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.openembedded.org_g_openembedded-2Dcore_unsub&d=DwIBAg&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=ItIZIiBFvPUc7ha-blv_xFb0FMnb2T_GL7CNoIiQdZKZOHxwxi75uwo6Hol3J3TA&s=FpYs9M88TVaCf1Ibbm3mKpHzyHV_ihvwGydOexSfF2s&e=
[[email protected]]

Quoted 2 lines

-=-=-=-=-=-=-=-=-=-=-=-

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering

https://urldefense.proofpoint.com/v2/url?u=https-3A__bootlin.com&d=DwIBAg&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=ItIZIiBFvPUc7ha-blv_xFb0FMnb2T_GL7CNoIiQdZKZOHxwxi75uwo6Hol3J3TA&s=Lu5F2iWAYyxz6ynKWLlP56TD2uUQTBZBQSCOpzaMaRI&e=