Skip to contentSkip to conversation

i2c: smbus: support new RAM variant for SPD

PATCH In review Corentin Labbe 2 participants 3 messages Nov 7, 2022 – Nov 14, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i2c: smbus: support new RAM variant for SPD

On my x05 laptop I got:
Memory type 0x12 not supported yet, not instantiating SPD

Adding the 0x12 case lead to a successful instantiated SPD AT24 EEPROM. i801_smbus 0000:00:1f.3: SMBus using polling
i2c i2c-6: 2/2 memory slots populated (from DMI)
at24 6-0050: 256 byte spd EEPROM, read-only
i2c i2c-6: Successfully instantiated SPD at 0x50
at24 6-0051: 256 byte spd EEPROM, read-only
i2c i2c-6: Successfully instantiated SPD at 0x51

And then, I decoded it successfully via decode-dimms.

---
The result of decode-dimms could be found at http://kernel.montjoie.ovh/zoo/x05/decode-dimms.txt
Since RAM is DDR, I wanted to add '/* DDR */' comment, but I didnt find any document with proof that this 0x12 is for DDR.

 drivers/i2c/i2c-smbus.c | 1 +
 1 file changed, 1 insertion(+)
drivers/i2c/i2c-smbus.c +1 -0
index 07c92c8495a3..6dca19c994db 100644
@@ -362,6 +362,7 @@ void i2c_register_spd(struct i2c_adapter *adap)
 	}
 
 	switch (common_mem_type) {
+	case 0x12:
 	case 0x13:	/* DDR2 */
 	case 0x18:	/* DDR3 */
 	case 0x1C:	/* LPDDR2 */
Signature · 1 line
2.37.4
#1 lore raw

Hi Corentin,

Quoted 2 lines · Corentin Labbe

On my x05 laptop I got:
Memory type 0x12 not supported yet, not instantiating SPD

Oh, that one must be old.

Quoted 8 lines

Adding the 0x12 case lead to a successful instantiated SPD AT24 EEPROM. i801_smbus 0000:00:1f.3: SMBus using polling
i2c i2c-6: 2/2 memory slots populated (from DMI)
at24 6-0050: 256 byte spd EEPROM, read-only
i2c i2c-6: Successfully instantiated SPD at 0x50
at24 6-0051: 256 byte spd EEPROM, read-only
i2c i2c-6: Successfully instantiated SPD at 0x51

Quoted 7 lines

And then, I decoded it successfully via decode-dimms.

---
The result of decode-dimms could be found at http://kernel.montjoie.ovh/zoo/x05/decode-dimms.txt
Since RAM is DDR, I wanted to add '/* DDR */' comment, but I didnt find any document with proof that this 0x12 is for DDR.

It is. The document you are looking for is:
https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.6.0.pdf

and specifically section 7.18.2 (Memory Device — Type), table 78 (Memory Device: Type).

Quoted 9 lines
 drivers/i2c/i2c-smbus.c | 1 +
 1 file changed, 1 insertion(+)
drivers/i2c/i2c-smbus.c +0 -0
index 07c92c8495a3..6dca19c994db 100644

drivers/i2c/i2c-smbus.c void i2c_register_spd(struct i2c_adapter *adap) · line 368

Quoted 7 lines
drivers/i2c/i2c-smbus.c +1 -0
@@ -362,6 +362,7 @@ void i2c_register_spd(struct i2c_adapter *adap)
 	}
 
 	switch (common_mem_type) {
+	case 0x12:
 	case 0x13:	/* DDR2 */
 	case 0x18:	/* DDR3 */
 	case 0x1C:	/* LPDDR2 */

Please also add LPDDR (0x1B) for consistency.

Thanks,

Signature · 2 lines
Jean Delvare
SUSE L3 Support
#2 lore raw
Quoted 25 lines · Jean Delvare

Hi Corentin,

Quoted 2 lines · Corentin Labbe

On my x05 laptop I got:
Memory type 0x12 not supported yet, not instantiating SPD

Oh, that one must be old.

Quoted 8 lines

Adding the 0x12 case lead to a successful instantiated SPD AT24 EEPROM. i801_smbus 0000:00:1f.3: SMBus using polling
i2c i2c-6: 2/2 memory slots populated (from DMI)
at24 6-0050: 256 byte spd EEPROM, read-only
i2c i2c-6: Successfully instantiated SPD at 0x50
at24 6-0051: 256 byte spd EEPROM, read-only
i2c i2c-6: Successfully instantiated SPD at 0x51

Quoted 7 lines

And then, I decoded it successfully via decode-dimms.

---
The result of decode-dimms could be found at http://kernel.montjoie.ovh/zoo/x05/decode-dimms.txt
Since RAM is DDR, I wanted to add '/* DDR */' comment, but I didnt find any document with proof that this 0x12 is for DDR.

Quoted 6 lines

It is. The document you are looking for is:
https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.6.0.pdf

and specifically section 7.18.2 (Memory Device — Type), table 78 (Memory Device: Type).

Hello

Thanks for the link, I will add it also as comment.

Quoted 11 lines
Quoted 11 lines
 drivers/i2c/i2c-smbus.c | 1 +
 1 file changed, 1 insertion(+)
drivers/i2c/i2c-smbus.c +0 -0
index 07c92c8495a3..6dca19c994db 100644
@@ -362,6 +362,7 @@ void i2c_register_spd(struct i2c_adapter *adap)
 	}
 
Quoted 7 lines

drivers/i2c/i2c-smbus.c void i2c_register_spd(struct i2c_adapter *adap) · line 368

Quoted 5 lines
drivers/i2c/i2c-smbus.c +1 -0
 	switch (common_mem_type) {
+	case 0x12:
 	case 0x13:	/* DDR2 */
 	case 0x18:	/* DDR3 */
 	case 0x1C:	/* LPDDR2 */

Please also add LPDDR (0x1B) for consistency.

Will do it.

Thanks
Regards