Skip to contentSkip to conversation

drm/nouveau/gr/gv100-: unlock on error in gf100_gr_chan_new()

PATCH New Dan Carpenter 1 participant 1 message Nov 15, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/nouveau/gr/gv100-: unlock on error in gf100_gr_chan_new()

Drop the "gr->fecs.mutex" lock before returning on this error path.

Fixes ca081fff6ecc ("drm/nouveau/gr/gf100-: generate golden context during first object alloc")
---
 drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c +1 -0
index 5f20079c3660..24bec8f8f83e 100644
@@ -442,6 +442,7 @@ gf100_gr_chan_new(struct nvkm_gr *base, struct nvkm_fifo_chan *fifoch,
 	if (gr->data == NULL) {
 		ret = gf100_grctx_generate(gr, chan, fifoch->inst);
 		if (ret) {
+			mutex_unlock(&gr->fecs.mutex);
 			nvkm_error(&base->engine.subdev, "failed to construct context\n");
 			return ret;
 		}
Signature · 1 line
2.35.1