Skip to contentSkip to conversation

blk-cgroup: properly pin the parent in blkcg_css_online

PATCH Applied Chris Mason 4 participants 4 messages Nov 14, 2022 – Nov 15, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 blk-cgroup: properly pin the parent in blkcg_css_online

blkcg_css_online is supposed to pin the blkcg of the parent, but 397c9f46ee4d refactored things and along the way, changed it to pin the css instead. This results in extra pins, and we end up leaking blkcgs and cgroups.

Fixes 397c9f46ee4d ("blk-cgroup: move blkcg_{pin,unpin}_online out of line")
Cc <[email protected]> # v5.19+
---
 block/blk-cgroup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
block/blk-cgroup.c +1 -1
index 6a5c849ee061..ed761c62ad0a 100644
@@ -1213,7 +1213,7 @@ static int blkcg_css_online(struct cgroup_subsys_state *css)
 	 * parent so that offline always happens towards the root.
 	 */
 	if (parent)
-		blkcg_pin_online(css);
+		blkcg_pin_online(&parent->css);
 	return 0;
 }
 
Signature · 1 line
2.30.2
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Chris Mason

blkcg_css_online is supposed to pin the blkcg of the parent, but 397c9f46ee4d refactored things and along the way, changed it to pin the css instead. This results in extra pins, and we end up leaking blkcgs and cgroups.

Fixes 397c9f46ee4d ("blk-cgroup: move blkcg_{pin,unpin}_online out of line")
Cc <[email protected]> # v5.19+
maintainer Applied
#2 lore raw
In reply to Chris Mason
Quoted 6 lines · Chris Mason

blkcg_css_online is supposed to pin the blkcg of the parent, but 397c9f46ee4d refactored things and along the way, changed it to pin the css instead. This results in extra pins, and we end up leaking blkcgs and cgroups.

Applied, thanks!

[1/1] blk-cgroup: properly pin the parent in blkcg_css_online

      commit: d7dbd43f4a828fa1d9a8614d5b0ac40aee6375fe

Best regards,

Signature · 1 line
Jens Axboe