usb: typec: Check for ops->exit instead of ops->enter in altmode_exit
Subsystems (2)
PATCH 1/1 usb: typec: Check for ops->exit instead of ops->enter in altmode_exit
typec_altmode_exit checks if ops->enter is not NULL but then calls ops->exit a few lines below. Fix that and check for the function pointer it's about to call instead.
Fixes 8a37d87d72f0 ("usb: typec: Bus type for alternate modes")
Signed-off-by Sven Peter <[email protected]>
--- drivers/usb/typec/bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/typec/bus.c +1 -1
@@ -134,7 +134,7 @@ int typec_altmode_exit(struct typec_altmode *adev)if (!adev || !adev->active)return 0 ; -if (!pdev->ops || !pdev->ops->enter) +if (!pdev->ops || !pdev->ops->exit)return -EOPNOTSUPP ;/* Moving to USB Safe State */
Signature · 1 line
2.25.1
Quoted 6 lines · Sven Peter
typec_altmode_exitchecks ifops->enteris not NULL but then callsops->exita few lines below. Fix that and check for the function pointer it's about to call instead.Fixes 8a37d87d72f0 ("usb: typec: Bus type for alternate modes")Signed-off-by Sven Peter <[email protected]>
No Cc: stable@...?
Reviewed-by Heikki Krogerus <[email protected]>
Quoted 9 lines
--- drivers/usb/typec/bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/usb/typec/bus.c +0
-0
drivers/usb/typec/bus.c int typec_altmode_exit(struct typec_altmode *adev) · line 140
Quoted 8 lines
drivers/usb/typec/bus.c +1
-1@@ -134,7 +134,7 @@ int typec_altmode_exit(struct typec_altmode *adev)if (!adev || !adev->active)return 0 ; -if (!pdev->ops || !pdev->ops->enter) +if (!pdev->ops || !pdev->ops->exit)return -EOPNOTSUPP ;/* Moving to USB Safe State */
thanks,
Signature · 1 line
heikki