fixp-arith: do not require users to include bug.h
PATCH RESEND 1/1 fixp-arith: do not require users to include bug.h
The fixp_sin32_rad()() contains a call to BUG_ON(). If users of fixp-arith.h have not included the bug.h prior including the fixp-arith.h the compiler will not find the BUG_ON. Thus every user of fixp-arith.h must also include bug.h (or roll own variant of BUG_ON()).
Include bug.h from fixp-arith.h so every user of fixp-arith.h does not need to include the bug.h prior inclusion of fixp-arith.h
---
Another forgotten patch I encountered while cleaning up my local git. Seems like this has fell through the cracks.
include/linux/fixp-arith.h | 1 + 1 file changed, 1 insertion(+)
include/linux/fixp-arith.h +1 -0
@@ -2,6 +2,7 @@#ifndef _FIXP_ARITH_H#define _FIXP_ARITH_H +#include <linux/bug.h> #include <linux/math64.h> /*
base-commit: 094226ad94f471a9f19e8f8e7140a09c2625abaa
Signature · 14 lines
2.38.1 -- Matti Vaittinen, Linux device drivers ROHM Semiconductors, Finland SWDC Kiviharjunlenkki 1E 90220 OULU FINLAND ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~ Simon says - in Latin please. ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~ Thanks to Simon Glass for the translation =]
Dmitry Torokhov
AppliedQuoted 10 lines · Matti Vaittinen
The fixp_sin32_rad()() contains a call to
BUG_ON(). If users offixp-arith.hhave not included thebug.hprior including thefixp-arith.hthe compiler will not find theBUG_ON. Thus every user offixp-arith.hmust also includebug.h(or roll own variant ofBUG_ON()).Include
bug.hfromfixp-arith.hso every user offixp-arith.hdoes not need to include thebug.hprior inclusion offixp-arith.hFixes 559addc25b00 ("[media] fixp-arith: replace sin/cos table by a better precision one")Signed-off-by Matti Vaittinen <[email protected]>
Applied, thank you.
Signature · 1 line
Dmitry