Skip to contentSkip to conversation

staging: wlan-ng: Replace zero-length arrays with DECLARE_FLEX_ARRAY() helper

PATCH In review Deepak R Varma 3 participants 12 messages Nov 17, 2022 – Nov 28, 2022 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: wlan-ng: Replace zero-length arrays with DECLARE_FLEX_ARRAY() helper

The code currently uses C90 standard extension based zero length arrays. The zero length array member also happens to be the only member of the structs. Such zero length array declarations are deprecated and the new C99 standard extension of flexible array declarations are to be used instead.

The DECLARE_FLEX_ARRAY() helper allows for a flexible array member as the only member in a structure. Refer to these links [1], [2] for details.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://lkml.kernel.org/r/YxKY6O2hmdwNh8r8@work

Issue identified using Coccinelle.

---

Notes:
1. Proposed change is compile tested only.
2. Solution feedback from [email protected]

 drivers/staging/wlan-ng/hfa384x.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/wlan-ng/hfa384x.h +3 -3
index 0611e37df6ac..3a1edcb43e07 100644
@@ -960,15 +960,15 @@ struct hfa384x_pdr_nicid {
 } __packed;
 
 struct hfa384x_pdr_refdac_measurements {
-	u16 value[0];
+	DECLARE_FLEX_ARRAY(u16, value);
 } __packed;
 
 struct hfa384x_pdr_vgdac_measurements {
-	u16 value[0];
+	DECLARE_FLEX_ARRAY(u16, value);
 } __packed;
 
 struct hfa384x_pdr_level_comp_measurements {
-	u16 value[0];
+	DECLARE_FLEX_ARRAY(u16, value);
 } __packed;
 
 struct hfa384x_pdr_mac_address {

--
2.34.1

#1 lore raw
Quoted 31 lines · Deepak R Varma

The code currently uses C90 standard extension based zero length arrays. The zero length array member also happens to be the only member of the structs. Such zero length array declarations are deprecated and the new C99 standard extension of flexible array declarations are to be used instead.

The DECLARE_FLEX_ARRAY() helper allows for a flexible array member as the only member in a structure. Refer to these links [1], [2] for details.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://lkml.kernel.org/r/YxKY6O2hmdwNh8r8@work

Issue identified using Coccinelle.

---

Notes:
1. Proposed change is compile tested only.
2. Solution feedback from [email protected]

 drivers/staging/wlan-ng/hfa384x.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/wlan-ng/hfa384x.h +0 -0
index 0611e37df6ac..3a1edcb43e07 100644

drivers/staging/wlan-ng/hfa384x.h struct hfa384x_pdr_nicid { · line 964

Quoted 6 lines
drivers/staging/wlan-ng/hfa384x.h +1 -1
@@ -960,15 +960,15 @@ struct hfa384x_pdr_nicid {
 } __packed;
 
 struct hfa384x_pdr_refdac_measurements {
-	u16 value[0];
+	DECLARE_FLEX_ARRAY(u16, value);
 } __packed;

Why? This structure is never used anywhere, right? So why is this needed to be changed and not just removed entirely? Same for the other structures in this patch.

thanks,

greg k-h

#2 lore raw
Quoted 34 lines · Greg Kroah-Hartman
Quoted 33 lines · Deepak R Varma

The code currently uses C90 standard extension based zero length arrays. The zero length array member also happens to be the only member of the structs. Such zero length array declarations are deprecated and the new C99 standard extension of flexible array declarations are to be used instead.

The DECLARE_FLEX_ARRAY() helper allows for a flexible array member as the only member in a structure. Refer to these links [1], [2] for details.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://lkml.kernel.org/r/YxKY6O2hmdwNh8r8@work

Issue identified using Coccinelle.

---

Notes:
1. Proposed change is compile tested only.
2. Solution feedback from [email protected]

 drivers/staging/wlan-ng/hfa384x.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/wlan-ng/hfa384x.h +0 -0
index 0611e37df6ac..3a1edcb43e07 100644
@@ -960,15 +960,15 @@ struct hfa384x_pdr_nicid {
 } __packed;
 
Quoted 8 lines

drivers/staging/wlan-ng/hfa384x.h struct hfa384x_pdr_nicid { · line 964

Quoted 4 lines
drivers/staging/wlan-ng/hfa384x.h +1 -1
 struct hfa384x_pdr_refdac_measurements {
-	u16 value[0];
+	DECLARE_FLEX_ARRAY(u16, value);
 } __packed;

Why? This structure is never used anywhere, right? So why is this needed to be changed and not just removed entirely? Same for the other structures in this patch.

Hello Greg,
I am unable to confirm that these structures are truly not needed in the absence if a real device based testing. I could only validate that using the compile build and driver loading.

This change that I am proposing in the interim would enable the compiler to protect the structure from addition of a new member below the zero length array.

If there is a way to confirm that the structures are indeed not needed, I can revise the patch and send the cleanup accordingly. Please suggest.

Thank you,
./drv

Quoted 4 lines

thanks,

greg k-h

#3 lore raw
Quoted 44 lines · Deepak R Varma
Quoted 34 lines · Greg Kroah-Hartman
Quoted 33 lines · Deepak R Varma

The code currently uses C90 standard extension based zero length arrays. The zero length array member also happens to be the only member of the structs. Such zero length array declarations are deprecated and the new C99 standard extension of flexible array declarations are to be used instead.

The DECLARE_FLEX_ARRAY() helper allows for a flexible array member as the only member in a structure. Refer to these links [1], [2] for details.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://lkml.kernel.org/r/YxKY6O2hmdwNh8r8@work

Issue identified using Coccinelle.

---

Notes:
1. Proposed change is compile tested only.
2. Solution feedback from [email protected]

 drivers/staging/wlan-ng/hfa384x.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/wlan-ng/hfa384x.h +0 -0
index 0611e37df6ac..3a1edcb43e07 100644
@@ -960,15 +960,15 @@ struct hfa384x_pdr_nicid {
 } __packed;
 
Quoted 8 lines

drivers/staging/wlan-ng/hfa384x.h struct hfa384x_pdr_nicid { · line 964

Quoted 4 lines
drivers/staging/wlan-ng/hfa384x.h +1 -1
 struct hfa384x_pdr_refdac_measurements {
-	u16 value[0];
+	DECLARE_FLEX_ARRAY(u16, value);
 } __packed;

Why? This structure is never used anywhere, right? So why is this needed to be changed and not just removed entirely? Same for the other structures in this patch.

Quoted 4 lines

Hello Greg,
I am unable to confirm that these structures are truly not needed in the absence if a real device based testing. I could only validate that using the compile build and driver loading.

Think this through, if no one is actually using this structure, and it is of 0 size, then do you think it is being used?

Quoted 2 lines

This change that I am proposing in the interim would enable the compiler to protect the structure from addition of a new member below the zero length array.

Why would you want to add a new member below this? That's not what is happening here at all.

Please think this through a bit more.

good luck!

greg k-h

#4 lore raw
Quoted 13 lines · Greg Kroah-Hartman
Quoted 12 lines · Deepak R Varma
Quoted 10 lines · Greg Kroah-Hartman

drivers/staging/wlan-ng/hfa384x.h struct hfa384x_pdr_nicid { · line 964

Quoted 5 lines · Deepak R Varma

struct hfa384x_pdr_refdac_measurements {

drivers/staging/wlan-ng/hfa384x.h +1 -1
-	u16 value[0];
+	DECLARE_FLEX_ARRAY(u16, value);
 } __packed;

Why? This structure is never used anywhere, right? So why is this needed to be changed and not just removed entirely? Same for the other structures in this patch.

Quoted 7 lines
Quoted 4 lines

Hello Greg,
I am unable to confirm that these structures are truly not needed in the absence if a real device based testing. I could only validate that using the compile build and driver loading.

Think this through, if no one is actually using this structure, and it is of 0 size, then do you think it is being used?

Hello Greg,
I did not find any memory allocation for these zero length array structures. Also, the union or its enclosing structure do not appear to access the members. Hence I am leaning towards concluding that these zero length array structures do not appear to be necessary.

There are a few other structures that are part of the same union, however, they too do not appear to be used for accessing the memory assigned to the union [or its enclosing structure]. I think most of the members of these unions can be replaced by one max size structure of this union [e.g. struct hfa384x_pdr_mkk_measurements].

Could you please comment if I am reading the code right?

For your quick reference, the zero length structure declaration are online 963 whereas the union is on line number 1080 of the file drivers/staging/wlan-ng/hfa384x.h

Thank you,
./drv

Quoted 6 lines
Quoted 3 lines

This change that I am proposing in the interim would enable the compiler to protect the structure from addition of a new member below the zero length array.

Why would you want to add a new member below this? That's not what is happening here at all.

I came across this one old commit where such an accident happened. This is from a recent LWN article:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e48f129c2f20

I understand the C99 now protects from such an attempt at the compile time itself.

Thank you,
./drv

Quoted 7 lines

Please think this through a bit more.

good luck!

greg k-h

#5 lore raw
Quoted 34 lines · Deepak R Varma
Quoted 13 lines · Greg Kroah-Hartman
Quoted 12 lines · Deepak R Varma
Quoted 10 lines · Greg Kroah-Hartman

drivers/staging/wlan-ng/hfa384x.h struct hfa384x_pdr_nicid { · line 964

Quoted 5 lines · Deepak R Varma

struct hfa384x_pdr_refdac_measurements {

drivers/staging/wlan-ng/hfa384x.h +1 -1
-	u16 value[0];
+	DECLARE_FLEX_ARRAY(u16, value);
 } __packed;

Why? This structure is never used anywhere, right? So why is this needed to be changed and not just removed entirely? Same for the other structures in this patch.

Quoted 7 lines
Quoted 4 lines

Hello Greg,
I am unable to confirm that these structures are truly not needed in the absence if a real device based testing. I could only validate that using the compile build and driver loading.

Think this through, if no one is actually using this structure, and it is of 0 size, then do you think it is being used?

Hello Greg,
I did not find any memory allocation for these zero length array structures. Also, the union or its enclosing structure do not appear to access the members. Hence I am leaning towards concluding that these zero length array structures do not appear to be necessary.

There are a few other structures that are part of the same union, however, they too do not appear to be used for accessing the memory assigned to the union [or its enclosing structure]. I think most of the members of these unions can be replaced by one max size structure of this union [e.g. struct hfa384x_pdr_mkk_measurements].

Quoted 4 lines

Could you please comment if I am reading the code right?

For your quick reference, the zero length structure declaration are online 963 whereas the union is on line number 1080 of the file drivers/staging/wlan-ng/hfa384x.h

Hello Greg,
can you please suggest how should I approach this clean-up/correction?

Thank you,
./drv

Quoted 32 lines

Thank you,
./drv

Quoted 6 lines
Quoted 3 lines

This change that I am proposing in the interim would enable the compiler to protect the structure from addition of a new member below the zero length array.

Why would you want to add a new member below this? That's not what is happening here at all.

I came across this one old commit where such an accident happened. This is from a recent LWN article:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e48f129c2f20

I understand the C99 now protects from such an attempt at the compile time itself.

Thank you,
./drv

Quoted 7 lines

Please think this through a bit more.

good luck!

greg k-h

#6 lore raw
Quoted 35 lines · Deepak R Varma
Quoted 34 lines · Deepak R Varma
Quoted 13 lines · Greg Kroah-Hartman
Quoted 12 lines · Deepak R Varma
Quoted 10 lines · Greg Kroah-Hartman

Review

Quoted 5 lines · Deepak R Varma

struct hfa384x_pdr_refdac_measurements {

(quoted diff) +1 -1
-	u16 value[0];
+	DECLARE_FLEX_ARRAY(u16, value);
 } __packed;

Why? This structure is never used anywhere, right? So why is this needed to be changed and not just removed entirely? Same for the other structures in this patch.

Quoted 7 lines
Quoted 4 lines

Hello Greg,
I am unable to confirm that these structures are truly not needed in the absence if a real device based testing. I could only validate that using the compile build and driver loading.

Think this through, if no one is actually using this structure, and it is of 0 size, then do you think it is being used?

Hello Greg,
I did not find any memory allocation for these zero length array structures. Also, the union or its enclosing structure do not appear to access the members. Hence I am leaning towards concluding that these zero length array structures do not appear to be necessary.

There are a few other structures that are part of the same union, however, they too do not appear to be used for accessing the memory assigned to the union [or its enclosing structure]. I think most of the members of these unions can be replaced by one max size structure of this union [e.g. struct hfa384x_pdr_mkk_measurements].

Quoted 8 lines
Quoted 4 lines

Could you please comment if I am reading the code right?

For your quick reference, the zero length structure declaration are online 963 whereas the union is on line number 1080 of the file drivers/staging/wlan-ng/hfa384x.h

Hello Greg,
can you please suggest how should I approach this clean-up/correction?

Like this:

drivers/staging/wlan-ng/hfa384x.h +0 -5
index 0611e37df6ac..6a3df58c9e9c 100644
@@ -959,10 +959,6 @@ struct hfa384x_pdr_nicid {
 	u16 minor;
 } __packed;
 
-struct hfa384x_pdr_refdac_measurements {
-	u16 value[0];
-} __packed;
-
 struct hfa384x_pdr_vgdac_measurements {
 	u16 value[0];
 } __packed;
@@ -1077,7 +1073,6 @@ struct hfa384x_pdrec {
 		struct hfa384x_pdr_mfisuprange mfisuprange;
 		struct hfa384x_pdr_cfisuprange cfisuprange;
 		struct hfa384x_pdr_nicid nicid;
-		struct hfa384x_pdr_refdac_measurements refdac_measurements;
 		struct hfa384x_pdr_vgdac_measurements vgdac_measurements;
 		struct hfa384x_pdr_level_comp_measurements level_compc_measurements;
 		struct hfa384x_pdr_mac_address mac_address;
#7 lore raw
Quoted 38 lines · Dan Carpenter
Quoted 37 lines · Deepak R Varma
Quoted 36 lines · Deepak R Varma
Quoted 13 lines · Greg Kroah-Hartman
Quoted 12 lines · Deepak R Varma
Quoted 10 lines · Greg Kroah-Hartman

drivers/staging/wlan-ng/hfa384x.h struct hfa384x_pdr_nicid { · line 964

Quoted 5 lines · Deepak R Varma

struct hfa384x_pdr_refdac_measurements {

drivers/staging/wlan-ng/hfa384x.h +1 -1
-	u16 value[0];
+	DECLARE_FLEX_ARRAY(u16, value);
 } __packed;

Why? This structure is never used anywhere, right? So why is this needed to be changed and not just removed entirely? Same for the other structures in this patch.

Quoted 7 lines
Quoted 4 lines

Hello Greg,
I am unable to confirm that these structures are truly not needed in the absence if a real device based testing. I could only validate that using the compile build and driver loading.

Think this through, if no one is actually using this structure, and it is of 0 size, then do you think it is being used?

Hello Greg,
I did not find any memory allocation for these zero length array structures. Also, the union or its enclosing structure do not appear to access the members. Hence I am leaning towards concluding that these zero length array structures do not appear to be necessary.

There are a few other structures that are part of the same union, however, they too do not appear to be used for accessing the memory assigned to the union [or its enclosing structure]. I think most of the members of these unions can be replaced by one max size structure of this union [e.g. struct hfa384x_pdr_mkk_measurements].

Could you please comment if I am reading the code right?

Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

For your quick reference, the zero length structure declaration are online 963 whereas the union is on line number 1080 of the file drivers/staging/wlan-ng/hfa384x.h

Hello Greg,
can you please suggest how should I approach this clean-up/correction?

Like this:

Thank you Dan. This takes me back to the very first version of this patch. I will send in the clean up.

./drv

Quoted 25 lines
drivers/staging/wlan-ng/hfa384x.h +0 -5
index 0611e37df6ac..6a3df58c9e9c 100644
@@ -959,10 +959,6 @@ struct hfa384x_pdr_nicid {
 	u16 minor;
 } __packed;
 
-struct hfa384x_pdr_refdac_measurements {
-	u16 value[0];
-} __packed;
-
 struct hfa384x_pdr_vgdac_measurements {
 	u16 value[0];
 } __packed;
@@ -1077,7 +1073,6 @@ struct hfa384x_pdrec {
 		struct hfa384x_pdr_mfisuprange mfisuprange;
 		struct hfa384x_pdr_cfisuprange cfisuprange;
 		struct hfa384x_pdr_nicid nicid;
-		struct hfa384x_pdr_refdac_measurements refdac_measurements;
 		struct hfa384x_pdr_vgdac_measurements vgdac_measurements;
 		struct hfa384x_pdr_level_comp_measurements level_compc_measurements;
 		struct hfa384x_pdr_mac_address mac_address;
#8 lore raw
Quoted 42 lines · Deepak R Varma
Quoted 41 lines · Dan Carpenter
Quoted 40 lines · Deepak R Varma
Quoted 38 lines · Deepak R Varma
Quoted 13 lines · Greg Kroah-Hartman
Quoted 12 lines · Deepak R Varma
Quoted 10 lines · Greg Kroah-Hartman

drivers/staging/wlan-ng/hfa384x.h struct hfa384x_pdr_nicid { · line 964

Quoted 5 lines · Deepak R Varma

struct hfa384x_pdr_refdac_measurements {

drivers/staging/wlan-ng/hfa384x.h +1 -1
-	u16 value[0];
+	DECLARE_FLEX_ARRAY(u16, value);
 } __packed;

Why? This structure is never used anywhere, right? So why is this needed to be changed and not just removed entirely? Same for the other structures in this patch.

Quoted 7 lines
Quoted 4 lines

Hello Greg,
I am unable to confirm that these structures are truly not needed in the absence if a real device based testing. I could only validate that using the compile build and driver loading.

Think this through, if no one is actually using this structure, and it is of 0 size, then do you think it is being used?

Hello Greg,
I did not find any memory allocation for these zero length array structures. Also, the union or its enclosing structure do not appear to access the members. Hence I am leaning towards concluding that these zero length array structures do not appear to be necessary.

There are a few other structures that are part of the same union, however, they too do not appear to be used for accessing the memory assigned to the union [or its enclosing structure]. I think most of the members of these unions can be replaced by one max size structure of this union [e.g. struct hfa384x_pdr_mkk_measurements].

Could you please comment if I am reading the code right?

For your quick reference, the zero length structure declaration are online 963 whereas the union is on line number 1080 of the file drivers/staging/wlan-ng/hfa384x.h

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

Hello Greg,
can you please suggest how should I approach this clean-up/correction?

Like this:

Thank you Dan. This takes me back to the very first version of this patch. I will send in the clean up.

Don't just send what I sent you, look around and try to see if there are other issues with the code.

regards,
dan carpenter

#9 lore raw
Quoted 9 lines · Dan Carpenter
Quoted 5 lines · Deepak R Varma
Quoted 1 line · Dan Carpenter

Like this:

Thank you Dan. This takes me back to the very first version of this patch. I will send in the clean up.

Don't just send what I sent you, look around and try to see if there are other issues with the code.

Yes, I will follow your advise.

Thanks,
./drv

Quoted 5 lines

regards,
dan carpenter

#10 lore raw
In reply to Deepak R Varma
Quoted 35 lines · Deepak R Varma
Quoted 34 lines · Deepak R Varma
Quoted 13 lines · Greg Kroah-Hartman
Quoted 12 lines · Deepak R Varma
Quoted 10 lines · Greg Kroah-Hartman

drivers/staging/wlan-ng/hfa384x.h struct hfa384x_pdr_nicid { · line 964

Quoted 5 lines · Deepak R Varma

struct hfa384x_pdr_refdac_measurements {

drivers/staging/wlan-ng/hfa384x.h +1 -1
-	u16 value[0];
+	DECLARE_FLEX_ARRAY(u16, value);
 } __packed;

Why? This structure is never used anywhere, right? So why is this needed to be changed and not just removed entirely? Same for the other structures in this patch.

Quoted 7 lines
Quoted 4 lines

Hello Greg,
I am unable to confirm that these structures are truly not needed in the absence if a real device based testing. I could only validate that using the compile build and driver loading.

Think this through, if no one is actually using this structure, and it is of 0 size, then do you think it is being used?

Hello Greg,
I did not find any memory allocation for these zero length array structures. Also, the union or its enclosing structure do not appear to access the members. Hence I am leaning towards concluding that these zero length array structures do not appear to be necessary.

There are a few other structures that are part of the same union, however, they too do not appear to be used for accessing the memory assigned to the union [or its enclosing structure]. I think most of the members of these unions can be replaced by one max size structure of this union [e.g. struct hfa384x_pdr_mkk_measurements].

Quoted 7 lines
Quoted 4 lines

Could you please comment if I am reading the code right?

For your quick reference, the zero length structure declaration are online 963 whereas the union is on line number 1080 of the file drivers/staging/wlan-ng/hfa384x.h

Hello Greg,
can you please suggest how should I approach this clean-up/correction?

Sorry, but I do not have the bandwidth to help out with this. I will gladly review changes submitted only.

greg k-h

#11 lore raw
Quoted 10 lines · Greg Kroah-Hartman
Quoted 6 lines · Deepak R Varma
Quoted 3 lines

For your quick reference, the zero length structure declaration are online 963 whereas the union is on line number 1080 of the file drivers/staging/wlan-ng/hfa384x.h

Hello Greg,
can you please suggest how should I approach this clean-up/correction?

Sorry, but I do not have the bandwidth to help out with this. I will gladly review changes submitted only.

No problem. I completely understand and appreciate. Thank you Greg.

./drv

Quoted 3 lines

greg k-h