net: microchip: sparx5: fix uninitialized variables
PATCH 1/1 net: microchip: sparx5: fix uninitialized variables
Smatch complains that "err" can be uninitialized on these paths. Also it's just nicer to "return 0;" instead of "return err;"
Fixes 3a344f99bb55 ("net: microchip: sparx5: Add support for TC flower ARP dissector")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/net/ethernet/microchip/sparx5/sparx5_tc_flower.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/net/ethernet/microchip/sparx5/sparx5_tc_flower.c +5 -3
@@ -341,7 +341,7 @@ sparx5_tc_flower_handler_vlan_usage(struct sparx5_tc_flower_parse_usage *st) st->used_keys |=BIT (FLOW_DISSECTOR_KEY_VLAN ); -return err; +return 0 ; out:NL_SET_ERR_MSG_MOD (st->fco->common.extack,"vlan parse error" );return err;
@@ -452,8 +452,10 @@ sparx5_tc_flower_handler_arp_usage(struct sparx5_tc_flower_parse_usage *st)/* The IS2 ARP keyset does not support ARP hardware addresses */ if (!is_zero_ether_addr (mt.mask->sha) || - !is_zero_ether_addr (mt.mask->tha)) + !is_zero_ether_addr (mt.mask->tha)) { + err = -EINVAL ; goto out; + }if (mt.mask->sip) { ipval =be32_to_cpu ((__force __be32 )mt.key->sip);
@@ -477,7 +479,7 @@ sparx5_tc_flower_handler_arp_usage(struct sparx5_tc_flower_parse_usage *st) st->used_keys |=BIT (FLOW_DISSECTOR_KEY_ARP ); -return err; +return 0 ; out:NL_SET_ERR_MSG_MOD (st->fco->common.extack,"arp parse error" );
Signature · 1 line
2.35.1
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Fri, 18 Nov 2022 18:12:52 +0300 you wrote:
Smatch complains that "err" can be uninitialized on these paths. Also it's just nicer to "return 0;" instead of "return err;"
Fixes 3a344f99bb55 ("net: microchip: sparx5: Add support for TC flower ARP dissector")Signed-off-by Dan Carpenter <[email protected]>--- drivers/net/ethernet/microchip/sparx5/sparx5_tc_flower.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
Here is the summary with links:
- [net-next] net: microchip: sparx5: fix uninitialized variables
https://git.kernel.org/netdev/net-next/c/4e9a61394dc4
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html