Skip to contentSkip to conversation

staging: emxx_udc: Remove unneeded parentheses

PATCH In review Jack Schofield 2 participants 2 messages Nov 28, 2022 – Dec 5, 2022 Staging

lore
Share & tools
lore

Jack Schofield

author
#0 lore raw

PATCH 1/1 staging: emxx_udc: Remove unneeded parentheses

Parentheses are not required around condition tests. Remove to follow Linux Kernel coding style. Issue reported by checkpatch.

Signed-off-by Jack Schofield <[email protected]>

---
There are more instances of extra parens to cleanup. If this patch is welcome I can continue to cleanup this file.

 drivers/staging/emxx_udc/emxx_udc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/emxx_udc/emxx_udc.c +3 -3
index b4e19174bef2..1d4ac8374fe2 100644
@@ -149,8 +149,8 @@ static void _nbu2ss_ep0_complete(struct usb_ep *_ep, struct usb_request *_req)
 			/* SET_FEATURE */
 			recipient = (u8)(p_ctrl->bRequestType & USB_RECIP_MASK);
 			selector  = le16_to_cpu(p_ctrl->wValue);
-			if ((recipient == USB_RECIP_DEVICE) &&
-			    (selector == USB_DEVICE_TEST_MODE)) {
+			if (recipient == USB_RECIP_DEVICE &&
+			    selector == USB_DEVICE_TEST_MODE) {
 				wIndex = le16_to_cpu(p_ctrl->wIndex);
 				test_mode = (u32)(wIndex >> 8);
 				_nbu2ss_set_test_mode(udc, test_mode);

@@ -287,7 +287,7 @@ static int _nbu2ss_epn_exit(struct nbu2ss_udc *udc, struct nbu2ss_ep *ep)
 	u32		num;
 	u32		data;
 
-	if ((ep->epnum == 0) || (udc->vbus_active == 0))
+	if (ep->epnum == 0 || udc->vbus_active == 0)
 		return	-EINVAL;
 
 	num = ep->epnum - 1;
Signature · 1 line
2.25.1
maintainer
#1 lore raw
Quoted 27 lines · Jack Schofield

Parentheses are not required around condition tests. Remove to follow Linux Kernel coding style. Issue reported by checkpatch.

Signed-off-by Jack Schofield <[email protected]>

---
There are more instances of extra parens to cleanup. If this patch is welcome I can continue to cleanup this file.

 drivers/staging/emxx_udc/emxx_udc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/emxx_udc/emxx_udc.c +2 -2
index b4e19174bef2..1d4ac8374fe2 100644
@@ -149,8 +149,8 @@ static void _nbu2ss_ep0_complete(struct usb_ep *_ep, struct usb_request *_req)
 			/* SET_FEATURE */
 			recipient = (u8)(p_ctrl->bRequestType & USB_RECIP_MASK);
 			selector  = le16_to_cpu(p_ctrl->wValue);
-			if ((recipient == USB_RECIP_DEVICE) &&
-			    (selector == USB_DEVICE_TEST_MODE)) {
+			if (recipient == USB_RECIP_DEVICE &&
+			    selector == USB_DEVICE_TEST_MODE) {
 				wIndex = le16_to_cpu(p_ctrl->wIndex);
 				test_mode = (u32)(wIndex >> 8);
 				_nbu2ss_set_test_mode(udc, test_mode);

drivers/staging/emxx_udc/emxx_udc.c static int _nbu2ss_epn_exit(struct nbu2ss_udc *udc, struct nbu2ss_ep *ep) · line 290

Quoted 5 lines
drivers/staging/emxx_udc/emxx_udc.c +1 -1
@@ -287,7 +287,7 @@ static int _nbu2ss_epn_exit(struct nbu2ss_udc *udc, struct nbu2ss_ep *ep)
 	u32		num;
 	u32		data;
 
-	if ((ep->epnum == 0) || (udc->vbus_active == 0))
+	if (ep->epnum == 0 || udc->vbus_active == 0)

This type of change requires you to remember the == comes before || so it's best to just leave the code as-is to make it much more obvious what is happening.

sorry,

greg k-h