Skip to contentSkip to conversation

input/misc: wistron_btns: disable on UML

PATCH Applied Randy Dunlap 2 participants 2 messages Nov 30, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 input/misc: wistron_btns: disable on UML

The wistron_btns driver calls rtc_cmos_read(), which isn't available with UML builds, so disable this driver on UML.

Prevents this build error:

ld: drivers/input/misc/wistron_btns.o: in function `poll_bios':
wistron_btns.c:(.text+0x4be): undefined reference to `rtc_cmos_read'

Fixes 0bbadafdc49d ("um: allow disabling NO_IOMEM") # v5.14+
Cc Johannes Berg <[email protected]>
Cc Richard Weinberger <[email protected]>
Cc Dmitry Torokhov <[email protected]>
Cc Miloslav Trmac <[email protected]>
---
 drivers/input/misc/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/misc/Kconfig +1 -1
diff -- a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
@@ -330,7 +330,7 @@ config INPUT_CPCAP_PWRBUTTON
 
 config INPUT_WISTRON_BTNS
 	tristate "x86 Wistron laptop button interface"
-	depends on X86_32
+	depends on X86_32 && !UML
 	select INPUT_SPARSEKMAP
 	select NEW_LEDS
 	select LEDS_CLASS
maintainer Applied
#1 lore raw
Quoted 8 lines · Randy Dunlap

The wistron_btns driver calls rtc_cmos_read(), which isn't available with UML builds, so disable this driver on UML.

Prevents this build error:

ld: drivers/input/misc/wistron_btns.o: in function `poll_bios':
wistron_btns.c:(.text+0x4be): undefined reference to `rtc_cmos_read'

Quoted 8 lines
Fixes 0bbadafdc49d ("um: allow disabling NO_IOMEM") # v5.14+
Cc Johannes Berg <[email protected]>
Cc Richard Weinberger <[email protected]>
Cc Dmitry Torokhov <[email protected]>
Cc Miloslav Trmac <[email protected]>

Applied, thank you.

Signature · 6 lines
Dmitry

_______________________________________________
linux-um mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-um