Skip to contentSkip to conversation

riscv : select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY

PATCH Superseded Song Shuai 3 participants 4 messages Dec 1, 2022 – Dec 5, 2022 RISC-V

v3 of 11 Superseded Latest is v11 →

lore
Share & tools
lore

Song Shuai

author
#0 lore raw

PATCH v3 1/1 riscv : select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY

In RISC-V, -fpatchable-function-entry option is used to support dynamic ftrace in this commit afc76b8b8011 ("riscv: Using PATCHABLE_FUNCTION_ENTRY instead of MCOUNT"). So recordmcount don't have to be called to create the __mcount_loc section before the vmlinux linking.

Here selects FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY to tell Makefile not to run recordmcount.

Link_v1: https://lore.kernel.org/linux-riscv/CAAYs2=j3Eak9vU6xbAw0zPuoh00rh8v5C2U3fePkokZFibWs2g@mail.gmail.com/T/#t
Link_v2: https://lore.kernel.org/linux-riscv/CAAYs2=iYn8sLQB8oh+RzTKd2VKs8MXOLX6Mwpamx5gdVVN6mkA@mail.gmail.com/T/#m62138d7a76664798d00051818a438a601eff4cf1

---
 arch/riscv/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/riscv/Kconfig +1 -0
index 572973103d73..c19cddb8feb9 100644
@@ -277,6 +277,7 @@ config ARCH_RV64I
 	select 64BIT
 	select ARCH_SUPPORTS_INT128 if CC_HAS_INT128
 	select HAVE_DYNAMIC_FTRACE if !XIP_KERNEL && MMU && $(cc-option,-fpatchable-function-entry=8)
+	select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY if DYNAMIC_FTRACE
 	select HAVE_DYNAMIC_FTRACE_WITH_REGS if HAVE_DYNAMIC_FTRACE
 	select HAVE_DYNAMIC_FTRACE_WITH_DIRECT_CALLS
 	select HAVE_SAMPLE_FTRACE_DIRECT
Signature · 1 line
2.20.1
#1 lore raw
Quoted 11 lines · Song Shuai

In RISC-V, -fpatchable-function-entry option is used to support dynamic ftrace in this commit afc76b8b8011 ("riscv: Using PATCHABLE_FUNCTION_ENTRY instead of MCOUNT"). So recordmcount don't have to be called to create the __mcount_loc section before the vmlinux linking.

Here selects FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY to tell Makefile not to run recordmcount.

Link_v1: https://lore.kernel.org/linux-riscv/CAAYs2=j3Eak9vU6xbAw0zPuoh00rh8v5C2U3fePkokZFibWs2g@mail.gmail.com/T/#t
Link_v2: https://lore.kernel.org/linux-riscv/CAAYs2=iYn8sLQB8oh+RzTKd2VKs8MXOLX6Mwpamx5gdVVN6mkA@mail.gmail.com/T/#m62138d7a76664798d00051818a438a601eff4cf1

Hey Song Shuai,

For future patches, please use normal "Link:" tags. If you're just linking to prior versions of the patch, just put them below the --- line so they don't end up in the git history.

Please don't resend for this alone :)

Thanks,
Conor.

Quoted 21 lines
---
 arch/riscv/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/riscv/Kconfig +1 -0
index 572973103d73..c19cddb8feb9 100644
@@ -277,6 +277,7 @@ config ARCH_RV64I
 	select 64BIT
 	select ARCH_SUPPORTS_INT128 if CC_HAS_INT128
 	select HAVE_DYNAMIC_FTRACE if !XIP_KERNEL && MMU && $(cc-option,-fpatchable-function-entry=8)
+	select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY if DYNAMIC_FTRACE
 	select HAVE_DYNAMIC_FTRACE_WITH_REGS if HAVE_DYNAMIC_FTRACE
 	select HAVE_DYNAMIC_FTRACE_WITH_DIRECT_CALLS
 	select HAVE_SAMPLE_FTRACE_DIRECT
Signature · 1 line
2.20.1
#2 lore raw
Quoted 25 lines · Conor Dooley
Quoted 11 lines · Song Shuai

In RISC-V, -fpatchable-function-entry option is used to support dynamic ftrace in this commit afc76b8b8011 ("riscv: Using PATCHABLE_FUNCTION_ENTRY instead of MCOUNT"). So recordmcount don't have to be called to create the __mcount_loc section before the vmlinux linking.

Here selects FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY to tell Makefile not to run recordmcount.

Link_v1: https://lore.kernel.org/linux-riscv/CAAYs2=j3Eak9vU6xbAw0zPuoh00rh8v5C2U3fePkokZFibWs2g@mail.gmail.com/T/#t
Link_v2: https://lore.kernel.org/linux-riscv/CAAYs2=iYn8sLQB8oh+RzTKd2VKs8MXOLX6Mwpamx5gdVVN6mkA@mail.gmail.com/T/#m62138d7a76664798d00051818a438a601eff4cf1

Hey Song Shuai,

For future patches, please use normal "Link:" tags. If you're just linking to prior versions of the patch, just put them below the --- line so they don't end up in the git history.

Quoted 6 lines
---
 arch/riscv/Kconfig | 1 +
 1 file changed, 1 insertion(+)
Quoted 9 lines

arch/riscv/Kconfig config ARCH_RV64I · line 280

Quoted 9 lines
arch/riscv/Kconfig +1 -0
index 572973103d73..c19cddb8feb9 100644
@@ -277,6 +277,7 @@ config ARCH_RV64I
 	select 64BIT
 	select ARCH_SUPPORTS_INT128 if CC_HAS_INT128
 	select HAVE_DYNAMIC_FTRACE if !XIP_KERNEL && MMU && $(cc-option,-fpatchable-function-entry=8)
+	select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY if DYNAMIC_FTRACE

Also, why are these not added in alphabetical order, like the current list is? I don't see HAVE_DYNAMIC_FTRACE in linux-next from the other day so that probably needs fixing in the series you are based on too.

Quoted 6 lines
Quoted 6 lines
arch/riscv/Kconfig +0 -0
 	select HAVE_DYNAMIC_FTRACE_WITH_REGS if HAVE_DYNAMIC_FTRACE
 	select HAVE_DYNAMIC_FTRACE_WITH_DIRECT_CALLS
 	select HAVE_SAMPLE_FTRACE_DIRECT
Signature · 1 line
2.20.1
author
#3 lore raw
Quoted 27 lines · Conor Dooley <[email protected]> 于2022年12月1日周四 18:08写道:
Quoted 25 lines · Conor Dooley
Quoted 11 lines · Song Shuai

In RISC-V, -fpatchable-function-entry option is used to support dynamic ftrace in this commit afc76b8b8011 ("riscv: Using PATCHABLE_FUNCTION_ENTRY instead of MCOUNT"). So recordmcount don't have to be called to create the __mcount_loc section before the vmlinux linking.

Here selects FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY to tell Makefile not to run recordmcount.

Link_v1: https://lore.kernel.org/linux-riscv/CAAYs2=j3Eak9vU6xbAw0zPuoh00rh8v5C2U3fePkokZFibWs2g@mail.gmail.com/T/#t
Link_v2: https://lore.kernel.org/linux-riscv/CAAYs2=iYn8sLQB8oh+RzTKd2VKs8MXOLX6Mwpamx5gdVVN6mkA@mail.gmail.com/T/#m62138d7a76664798d00051818a438a601eff4cf1

Hey Song Shuai,

For future patches, please use normal "Link:" tags. If you're just linking to prior versions of the patch, just put them below the --- line so they don't end up in the git history.

Quoted 6 lines
---
 arch/riscv/Kconfig | 1 +
 1 file changed, 1 insertion(+)
Quoted 14 lines
Quoted 9 lines

arch/riscv/Kconfig config ARCH_RV64I · line 280

Quoted 9 lines
arch/riscv/Kconfig +1 -0
index 572973103d73..c19cddb8feb9 100644
@@ -277,6 +277,7 @@ config ARCH_RV64I
    select 64BIT
    select ARCH_SUPPORTS_INT128 if CC_HAS_INT128
    select HAVE_DYNAMIC_FTRACE if !XIP_KERNEL && MMU && $(cc-option,-fpatchable-function-entry=8)
+   select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY if DYNAMIC_FTRACE

Also, why are these not added in alphabetical order, like the current list is? I don't see HAVE_DYNAMIC_FTRACE in linux-next from the other day so that probably needs fixing in the series you are based on too.

Sorry for bothering you with this disorderly CONFIG and the 'Link' tags I'll tidy them up with Guo Ren in the next version.

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
arch/riscv/Kconfig +0 -1
    select HAVE_DYNAMIC_FTRACE_WITH_REGS if HAVE_DYNAMIC_FTRACE
    select HAVE_DYNAMIC_FTRACE_WITH_DIRECT_CALLS
    select HAVE_SAMPLE_FTRACE_DIRECT
--

2.20.1

--
Thanks,
Song