drm/fsl-dcu: Remove redundant error logging
Subsystems (3)
PATCH 1/1 drm/fsl-dcu: Remove redundant error logging
A call to platform_get_irq() already prints an error on failure within its own implementation. So printing another error based on its return value in the caller is redundant and should be removed. The clean up also makes if condition block braces unnecessary. Remove that as well.
Issue identified using platform_get_irq.cocci coccicheck script.
--- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c +1 -3
@@ -272,10 +272,8 @@ static int fsl_dcu_drm_probe(struct platform_device *pdev) } fsl_dev->irq =platform_get_irq (pdev,0 ); -if (fsl_dev->irq <0 ) { -dev_err (dev,"failed to get irq\n" ); +if (fsl_dev->irq <0 )return fsl_dev->irq; - } fsl_dev->regmap =devm_regmap_init_mmio (dev, base, &fsl_dcu_regmap_config);
--
2.34.1
On Sun, Dec 11, 2022 at 03:57:47PM +0530, Deepak R Varma wrote:
Hello,
May I please request a review and feedback on this patch proposal?
Thank you,
./drv
Quoted 31 lines
A call to
platform_get_irq()already prints an error on failure within its own implementation. So printing another error based on its return value in the caller is redundant and should be removed. The clean up also makes if condition block braces unnecessary. Remove that as well.Issue identified using
platform_get_irq.coccicoccicheck script.Signed-off-by Deepak R Varma <[email protected]>--- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c +1
-4@@ -272,10 +272,8 @@ static int fsl_dcu_drm_probe(struct platform_device *pdev) } fsl_dev->irq =platform_get_irq (pdev,0 ); -if (fsl_dev->irq <0 ) { -dev_err (dev,"failed to get irq\n" ); +if (fsl_dev->irq <0 )return fsl_dev->irq; - } fsl_dev->regmap =devm_regmap_init_mmio (dev, base, &fsl_dcu_regmap_config); --2.34.1
Quoted 8 lines · Deepak R Varma
A call to
platform_get_irq()already prints an error on failure within its own implementation. So printing another error based on its return value in the caller is redundant and should be removed. The clean up also makes if condition block braces unnecessary. Remove that as well.Issue identified using
platform_get_irq.coccicoccicheck script.Signed-off-by Deepak R Varma <[email protected]>
--
Stefan
Quoted 23 lines
--- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c +1
-4@@ -272,10 +272,8 @@ static int fsl_dcu_drm_probe(struct platform_device *pdev) } fsl_dev->irq =platform_get_irq (pdev,0 ); -if (fsl_dev->irq <0 ) { -dev_err (dev,"failed to get irq\n" ); +if (fsl_dev->irq <0 )return fsl_dev->irq; - } fsl_dev->regmap =devm_regmap_init_mmio (dev, base, &fsl_dcu_regmap_config); --2.34.1