Skip to contentSkip to conversation

CXL: Process event logs

PATCH Ira Weiny 2 participants 5 messages Dec 12, 2022 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Ira Weiny

author
#1 lore raw

My apologies. Please ignore this series.

I'm trying to use the new b4 send functionality and was trying to send this only to myself. I'm not sure what went wrong. The patches should be ok but this did not get sent to all the intended lists and people.

I'm going to resend this hopefully to all the right addresses this time.

Ira

Quoted 51 lines · Ira

This code has been tested with a newer qemu which allows for more events to be returned at a time as well an additional QMP event and interrupt injection. Those patches will follow once they have been cleaned up.

The series is now in 3 parts:

1) Base functionality including interrupts
2) Tracing specific events (Dynamic Capacity Event Record is defered)
3) cxl-test infrastructure for basic tests

---
Changes in v3:
Address comments from Dan

- Link to v3: https://lore.kernel.org/all/[email protected]/

---
Davidlohr Bueso (1):
cxl/mem: Wire up event interrupts

Ira Weiny (8):
PCI/CXL: Export native CXL error reporting control cxl/mem: Read, trace, and clear events on driver load cxl/mem: Trace General Media Event Record cxl/mem: Trace DRAM Event Record
cxl/mem: Trace Memory Module Event Record cxl/test: Add generic mock events
cxl/test: Add specific events
cxl/test: Simulate event log overflow

 drivers/acpi/pci_root.c       |   3 +
 drivers/cxl/core/mbox.c       | 186 ++++++++++++++++
 drivers/cxl/core/trace.h      | 479 ++++++++++++++++++++++++++++++++++++++++++
 drivers/cxl/cxl.h             |  16 ++
 drivers/cxl/cxlmem.h          | 171 +++++++++++++++
 drivers/cxl/cxlpci.h          |   6 +
 drivers/cxl/pci.c             | 236 +++++++++++++++++++++
 drivers/pci/probe.c           |   1 +
 include/linux/pci.h           |   1 +
 tools/testing/cxl/test/Kbuild |   2 +-
 tools/testing/cxl/test/mem.c  | 352 +++++++++++++++++++++++++++++++
 11 files changed, 1452 insertions(+), 1 deletion(-)

---
base-commit: acb704099642bc822ef2aed223a0b8db1f7ea76e
change-id: 20221211-test-b4-e9de44001b6e

Best regards,

Signature · 1 line
Ira Weiny <[email protected]>
#2 lore raw
Quoted 7 lines · Ira Weiny

My apologies. Please ignore this series.

I'm trying to use the new b4 send functionality and was trying to send this only to myself. I'm not sure what went wrong. The patches should be ok but this did not get sent to all the intended lists and people.

I'm going to resend this hopefully to all the right addresses this time.

Ira:

I don't think anything went wrong -- you probably used the new "reflect" feature, right? It fills out the To: and Cc: headers but doesn't actually send actual mail to those accounts. Mail servers don't actually pay any attention to those headers -- all that matters is what destinations are given to the server during the envelope negotiation.

I do realize that this is confusing. :/

Should I include anything in the output about this?

-K

author
#3 lore raw
Quoted 10 lines · Konstantin Ryabitsev
Quoted 7 lines · Ira Weiny

My apologies. Please ignore this series.

I'm trying to use the new b4 send functionality and was trying to send this only to myself. I'm not sure what went wrong. The patches should be ok but this did not get sent to all the intended lists and people.

I'm going to resend this hopefully to all the right addresses this time.

Ira:

First off thanks for the quick response and I have to say b4 send looks like an awesome tool. So I hope the above was not taken the wrong way.

Quoted 3 lines

I don't think anything went wrong -- you probably used the new "reflect" feature, right?

I did! :-D

Quoted 4 lines

It fills out the To: and Cc: headers but doesn't actually send actual mail to those accounts. Mail servers don't actually pay any attention to those headers -- all that matters is what destinations are given to the server during the envelope negotiation.

I did not know that. But I was kind of coming to that conclusion based on what I saw happen.

Quoted 2 lines

I do realize that this is confusing. :/

Only to those mere mortals such as myself who don't know squat about mail protocols! :-D

Quoted 2 lines

Should I include anything in the output about this?

Maybe. I'm not trying to put more burden on you. But for the ignorant maybe it is a good idea. I did panic when I saw all the to/cc addresses filled in.

FWIW I do like the idea of seeing the headers as they appear. My personal scripts have features to dump emails before trying to send. So now that I know what happened I kind of like it.

Thanks,
Ira

#4 lore raw
Quoted 5 lines · Ira Weiny
Quoted 4 lines

It fills out the To: and Cc: headers but doesn't actually send actual mail to those accounts. Mail servers don't actually pay any attention to those headers -- all that matters is what destinations are given to the server during the envelope negotiation.

Quoted 8 lines

I did not know that. But I was kind of coming to that conclusion based on what I saw happen.

Quoted 2 lines

I do realize that this is confusing. :/

Only to those mere mortals such as myself who don't know squat about mail protocols! :-D

It's completely normal not to know how that works -- and you shouldn't either.

Quoted 4 lines
Quoted 1 line

Should I include anything in the output about this?

Maybe. I'm not trying to put more burden on you. But for the ignorant maybe it is a good idea. I did panic when I saw all the to/cc addresses filled in.

I added a large notice about that to the --reflect output:

[...]
---
Ready to:
- send the above messages to just [email protected] (REFLECT MODE)
- via web endpoint: https://lkml.kernel.org/_b4_submit

REFLECT MODE:
The To: and Cc: headers will be fully populated, but the only address given to the mail server for actual delivery will be [email protected]

Addresses in To: and Cc: headers will NOT receive this series.

Press Enter to proceed or Ctrl-C to abort

Hopefully, it will be less worrisome to others in the future.

Thank you for trying out b4 prep/send!

-K

author
#5 lore raw
Quoted 35 lines · Konstantin Ryabitsev
Quoted 5 lines · Ira Weiny
Quoted 4 lines

It fills out the To: and Cc: headers but doesn't actually send actual mail to those accounts. Mail servers don't actually pay any attention to those headers -- all that matters is what destinations are given to the server during the envelope negotiation.

Quoted 8 lines

I did not know that. But I was kind of coming to that conclusion based on what I saw happen.

Quoted 2 lines

I do realize that this is confusing. :/

Only to those mere mortals such as myself who don't know squat about mail protocols! :-D

It's completely normal not to know how that works -- and you shouldn't either.

Quoted 4 lines
Quoted 1 line

Should I include anything in the output about this?

Maybe. I'm not trying to put more burden on you. But for the ignorant maybe it is a good idea. I did panic when I saw all the to/cc addresses filled in.

I added a large notice about that to the --reflect output:

[...]
---
Ready to:
- send the above messages to just [email protected] (REFLECT MODE)
- via web endpoint: https://lkml.kernel.org/_b4_submit

REFLECT MODE:
The To: and Cc: headers will be fully populated, but the only address given to the mail server for actual delivery will be [email protected]

Quoted 5 lines

Addresses in To: and Cc: headers will NOT receive this series.

Press Enter to proceed or Ctrl-C to abort

Hopefully, it will be less worrisome to others in the future.

Yes that should help a lot!

Quoted 2 lines

Thank you for trying out b4 prep/send!

NP

Thanks!
Ira