ipvs: fix type warning in do_div() on 32 bit
Subsystems (4)
Jakub Kicinski
maintainerPATCH 1/1 ipvs: fix type warning in do_div() on 32 bit
32 bit platforms without 64bit div generate the following warning:
net/netfilter/ipvs/ip_vs_est.c: In function 'ip_vs_est_calc_limits':include/asm-generic/div64.h:222:35: warning: comparison of distinct pointer types lacks a cast
222 | (void)(((typeof((n)) *)0) == ((uint64_t *)0)); \
| ^~net/netfilter/ipvs/ip_vs_est.c:694:17: note: in expansion of macro 'do_div'
694 | do_div(val, loops);
| ^~~~~~include/asm-generic/div64.h:222:35: warning: comparison of distinct pointer types lacks a cast
222 | (void)(((typeof((n)) *)0) == ((uint64_t *)0)); \
| ^~net/netfilter/ipvs/ip_vs_est.c:700:33: note: in expansion of macro 'do_div'
700 | do_div(val, min_est);
| ^~~~~~first argument of do_div() should be unsigned. We can't just cast as do_div() updates it as well, so we need an lval.
Make val unsigned in the first place, all paths check that the value they assign to this variables are non-negative already.
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
--- net/netfilter/ipvs/ip_vs_est.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
net/netfilter/ipvs/ip_vs_est.c +2 -1
@@ -640,9 +640,10 @@ static int ip_vs_est_calc_limits(struct netns_ipvs *ipvs, int *chain_max)int i, loops, ntest;s32 min_est =0 ;ktime_t t1, t2; -s64 diff, val;int max =8 ;int ret =1 ; +s64 diff; +u64 val;INIT_HLIST_HEAD (&chain);mutex_lock (&__ip_vs_mutex);
Signature · 1 line
2.38.1
Pablo Neira Ayuso
maintainerHi Jakub,
Quoted 13 lines · Jakub Kicinski
32 bit platforms without 64bit div generate the following warning:
net/netfilter/ipvs/ip_vs_est.c: In function 'ip_vs_est_calc_limits':include/asm-generic/div64.h:222:35: warning: comparison of distinct pointer types lacks a cast
222 | (void)(((typeof((n)) *)0) == ((uint64_t*)0)); \
| ^~net/netfilter/ipvs/ip_vs_est.c:694:17: note: in expansion of macro 'do_div'694 | do_div(val, loops); | ^~~~~~
include/asm-generic/div64.h:222:35: warning: comparison of distinct pointer types lacks a cast
222 | (void)(((typeof((n)) *)0) == ((uint64_t*)0)); \
| ^~net/netfilter/ipvs/ip_vs_est.c:700:33: note: in expansion of macro 'do_div'
Quoted 7 lines
700 | do_div(val, min_est); | ^~~~~~first argument of
do_div()should be unsigned. We can't just cast asdo_div()updates it as well, so we need an lval.
Make val unsigned in the first place, all paths check that the value they assign to this variables are non-negative already.
Your patch is very similar to what Julian posted:
https://patchwork.ozlabs.org/project/netfilter-devel/patch/[email protected]/
Thanks.