libpng: Added "--enable-hardware-optimizations" instead of "--enable-arm-neon". Because "--enable-arm-neon" only works for armv7, but doesn't work for aarch64. But in fact neon is also enabled for aarch64 by default.
PATCH 1/1 libpng: Added "--enable-hardware-optimizations" instead of "--enable-arm-neon". Because "--enable-arm-neon" only works for armv7, but doesn't work for aarch64. But in fact neon is also enabled for aarch64 by default.
Reference to libpng-1.6.38/configure,if enable_hardware_optimizations is enabled, libpng can judge whether enable enable_arm_neon according to $host_cpu.
----------------------------------------
$ cat libpng-1.6.38/configure
......
if test ${enable_hardware_optimizations+y}
then :
......
# allow enabling hardware optimization on any system:
case "$host_cpu" in
arm*|aarch64*)
enable_arm_neon=yesprintf "%s\n" "#define PNG_ARM_NEON_OPT 2" >>confdefs.h
......
----------------------------------------
--- meta/recipes-multimedia/libpng/libpng_1.6.38.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-multimedia/libpng/libpng_1.6.38.bb +1 -1
@@ -22,7 +22,7 @@ BINCONFIG = "${bindir}/libpng-config ${bindir}/libpng16-config" inherit autotools binconfig-disabled pkgconfig # Work around missing symbols -EXTRA_OECONF:append:class-target = " ${@bb.utils.contains("TUNE_FEATURES", "neon", "--enable-arm-neon=on", "--enable-arm-neon=off", d)}" +EXTRA_OECONF:append:class-target = " --enable-hardware-optimizations=on " PACKAGES =+ "${PN}-tools"
Signature · 1 line
2.25.1
Quoted 6 lines
-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of leimaohui
Sent: den 13 december 2022 03:38
To: [email protected]
Cc: Lei Maohui <[email protected]>
Subject: [oe-core][PATCH] libpng: Added "--enable-hardware-optimizations" instead of "--enable-arm-neon". Because "--enable-arm-neon" only works for armv7, but doesn't work for aarch64. But in fact neon is also enabled for aarch64 by default.
The above is a way too long subject. I suggest changing it to:
libpng: Use --enable-hardware-optimizations instead of --enable-arm-neon
And then use the rest of the original subject as the first paragraph of the commit message:
Because "--enable-arm-neon" only works for armv7, but doesn't work for aarch64. But in fact neon is also enabled for aarch64 by default.
Quoted 29 lines
Reference to libpng-1.6.38/configure,if
enable_hardware_optimizationsis enabled, libpng can judge whether enableenable_arm_neonaccording to $host_cpu.
----------------------------------------$ cat libpng-1.6.38/configure ...... if test ${enable_hardware_optimizations+y} then : ...... # allow enabling hardware optimization on any system: case "$host_cpu" in arm*|aarch64*) enable_arm_neon=yesprintf "%s\n" "#define
PNG_ARM_NEON_OPT2" >>confdefs.h
......
----------------------------------------Signed-off-by Lei Maohui <[email protected]>--- meta/recipes-multimedia/libpng/libpng_1.6.38.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/recipes-multimedia/libpng/libpng_1.6.38.bb +0
-0
meta/recipes-multimedia/libpng/libpng_1.6.38.bb BINCONFIG = "${bindir}/libpng-config ${bindir}/libpng16-config" · line 25
Quoted 5 lines
meta/recipes-multimedia/libpng/libpng_1.6.38.bb +1
-1@@ -22,7 +22,7 @@ BINCONFIG = "${bindir}/libpng-config ${bindir}/libpng16-config" inherit autotools binconfig-disabled pkgconfig # Work around missing symbols -EXTRA_OECONF:append:class-target = " ${@bb.utils.contains("TUNE_FEATURES", "neon", "--enable-arm-neon=on", "--enable-arm-neon=off", d)}" +EXTRA_OECONF:append:class-target = " --enable-hardware-optimizations=on "
Remove the space before the trailing quote.
Quoted 5 lines
meta/recipes-multimedia/libpng/libpng_1.6.38.bb +0
-1PACKAGES =+ "${PN}-tools" --2.25.1
//Peter
Hello,
This fails on the autobuilders:
https://autobuilder.yoctoproject.org/typhoon/#/builders/107/builds/3913/steps/11/logs/stdio
Quoted 49 lines · leimaohui
Reference to libpng-1.6.38/configure,if
enable_hardware_optimizationsis enabled, libpng can judge whether enableenable_arm_neonaccording to $host_cpu.
----------------------------------------$ cat libpng-1.6.38/configure ...... if test ${enable_hardware_optimizations+y} then : ...... # allow enabling hardware optimization on any system: case "$host_cpu" in arm*|aarch64*) enable_arm_neon=yesprintf "%s\n" "#define
PNG_ARM_NEON_OPT2" >>confdefs.h
......
----------------------------------------Signed-off-by Lei Maohui <[email protected]>--- meta/recipes-multimedia/libpng/libpng_1.6.38.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/recipes-multimedia/libpng/libpng_1.6.38.bb +1
-1@@ -22,7 +22,7 @@ BINCONFIG = "${bindir}/libpng-config ${bindir}/libpng16-config" inherit autotools binconfig-disabled pkgconfig # Work around missing symbols -EXTRA_OECONF:append:class-target = " ${@bb.utils.contains("TUNE_FEATURES", "neon", "--enable-arm-neon=on", "--enable-arm-neon=off", d)}" +EXTRA_OECONF:append:class-target = " --enable-hardware-optimizations=on " PACKAGES =+ "${PN}-tools"Signature · 11 lines
2.25.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#174506): https://lists.openembedded.org/g/openembedded-core/message/174506 Mute This Topic: https://lists.openembedded.org/mt/95637494/3617179 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Quoted 29 lines · leimaohui
Reference to libpng-1.6.38/configure,if
enable_hardware_optimizationsis enabled, libpng can judge whether enableenable_arm_neonaccording to $host_cpu.
----------------------------------------$ cat libpng-1.6.38/configure ...... if test ${enable_hardware_optimizations+y} then : ...... # allow enabling hardware optimization on any system: case "$host_cpu" in arm*|aarch64*) enable_arm_neon=yesprintf "%s\n" "#define
PNG_ARM_NEON_OPT2" >>confdefs.h
......
----------------------------------------Signed-off-by Lei Maohui <[email protected]>--- meta/recipes-multimedia/libpng/libpng_1.6.38.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/recipes-multimedia/libpng/libpng_1.6.38.bb +0
-0
meta/recipes-multimedia/libpng/libpng_1.6.38.bb BINCONFIG = "${bindir}/libpng-config ${bindir}/libpng16-config" · line 25
Quoted 5 lines
meta/recipes-multimedia/libpng/libpng_1.6.38.bb +1
-1@@ -22,7 +22,7 @@ BINCONFIG = "${bindir}/libpng-config ${bindir}/libpng16-config" inherit autotools binconfig-disabled pkgconfig # Work around missing symbols -EXTRA_OECONF:append:class-target = " ${@bb.utils.contains("TUNE_FEATURES", "neon", "--enable-arm-neon=on", "--enable-arm-neon=off", d)}" +EXTRA_OECONF:append:class-target = " --enable-hardware-optimizations=on "
It's difficult (impossible?) to automatically detect whether an ARM target supports NEON at build time, so this looks unlikely to work. Testing for NEON either needs to happen at run time or the information needs to be passed from the build system as an explicit configure option (ie the original approach here).
If you don't want to pass NEON options to 64bit ARM targets then add an over-ride which only applies to 32bit ARM targets.
Or in this case, if the configure script is wrong to try to enable NEON for 64bit ARM targets, patch the configure script and submit the patch upstream.
Quoted 14 lines
meta/recipes-multimedia/libpng/libpng_1.6.38.bb +0
-1PACKAGES =+ "${PN}-tools" --2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#174506): https://lists.openembedded.org/g/openembedded-core/message/174506
Mute This Topic: https://lists.openembedded.org/mt/95637494/3619030
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
Quoted 7 lines
It's difficult (impossible?) to automatically detect whether an ARM target supports NEON at build time, so this looks unlikely to work.
Testing for NEON either needs to happen at run time or the information needs to be passed from the build system as an explicit configure option (ie the original approach here).
Quoted 5 lines
If you don't want to pass NEON options to 64bit ARM targets then add an over-ride which only applies to 32bit ARM targets.
Or in this case, if the configure script is wrong to try to enable NEON for 64bit ARM targets, patch the configure script and submit the patch upstream.
I got it.
In fact, I submitted this patch because I met a conflict error when I enable multilib on aarch64. The conflict reason is that my lib32-libpng enabled NEON but libpng(64bit) didn't enable NEON although NEON is enabled for all aarch64 by default. But it looks like it is not a good way to added " --enable-hardware-optimizations=on " for all target.
So how about to update my patch to V2 as the following:
-EXTRA_OECONF:append:class-target = " ${@bb.utils.contains("TUNE_FEATURES", "neon", "--enable-arm-neon=on", "--enable-arm-neon=off", d)}" +EXTRA_OECONF:append:class-target = " ${@bb.utils.contains("TUNE_FEATURES", "neon", "--enable-arm-neon=on", " ", d)}" +EXTRA_OECONF:append:aarch64 = " --enable-hardware-optimizations=on "
Best regards
Lei
Quoted 77 lines
-----Original Message-----
From: Andre McCurdy <[email protected]>
Sent: Wednesday, December 14, 2022 5:49 AM
To: Lei, Maohui <[email protected]>
Cc: [email protected]
Subject: Re: [oe-core][PATCH] libpng: Added "--enable-hardware-optimizations" instead of "--enable-arm-neon". Because "--enable-arm-neon" only works for armv7, but doesn't work for aarch64. But in fact neon is also enabled for aarch64 by default.meta/recipes-multimedia/libpng/libpng_1.6.38.bb BINCONFIG = "${bindir}/libpng-config
Quoted 29 lines · leimaohui
Reference to libpng-1.6.38/configure,if
enable_hardware_optimizationsis enabled, libpng can judge whether enableenable_arm_neonaccording to $host_cpu.
----------------------------------------$ cat libpng-1.6.38/configure ...... if test ${enable_hardware_optimizations+y} then : ...... # allow enabling hardware optimization on any system: case "$host_cpu" in arm*|aarch64*) enable_arm_neon=yesprintf "%s\n" "#define
PNG_ARM_NEON_OPT2" >>confdefs.h ......
----------------------------------------Signed-off-by Lei Maohui <[email protected]>--- meta/recipes-multimedia/libpng/libpng_1.6.38.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/recipes-multimedia/libpng/libpng_1.6.38.bb +0
-0@@ -22,7 +22,7 @@ BINCONFIG = "${bindir}/libpng-config${bindir}/libpng16-config"
meta/recipes-multimedia/libpng/libpng_1.6.38.bb BINCONFIG = "${bindir}/libpng-config ${bindir}/libpng16-config"
Quoted 4 lines
meta/recipes-multimedia/libpng/libpng_1.6.38.bb +0
-1inherit autotools binconfig-disabled pkgconfig # Work around missing symbols -EXTRA_OECONF:append:class-target = "${@bb.utils.contains("TUNE_FEATURES", "neon", "--enable-arm-neon=on", "--enable-arm-neon=off", d)}"
meta/recipes-multimedia/libpng/libpng_1.6.38.bb BINCONFIG = "${bindir}/libpng-config ${bindir}/libpng16-config" · line 25
Quoted 1 line
meta/recipes-multimedia/libpng/libpng_1.6.38.bb +1
-0+EXTRA_OECONF:append:class-target = " --enable-hardware-optimizations=on "It's difficult (impossible?) to automatically detect whether an ARM target supports NEON at build time, so this looks unlikely to work.
Testing for NEON either needs to happen at run time or the information needs to be passed from the build system as an explicit configure option (ie the original approach here).If you don't want to pass NEON options to 64bit ARM targets then add an over-ride which only applies to 32bit ARM targets.
Or in this case, if the configure script is wrong to try to enable NEON for 64bit ARM targets, patch the configure script and submit the patch upstream.
Quoted 16 lines
meta/recipes-multimedia/libpng/libpng_1.6.38.bb +0
-1PACKAGES =+ "${PN}-tools" --2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#174506):
https://lists.openembedded.org/g/openembedded-core/message/174506
Mute This Topic: https://lists.openembedded.org/mt/95637494/3619030
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-