kvm: kvm_main: Remove unnecessary (void*) conversions
PATCH 1/1 kvm: kvm_main: Remove unnecessary (void*) conversions
void * pointer assignment does not require a forced replacement.
Signed-off-by Li kunyu <[email protected]>
--- virt/kvm/kvm_main.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-)
virt/kvm/kvm_main.c +5 -7
@@ -3861,7 +3861,7 @@ static int create_vcpu_fd(struct kvm_vcpu *vcpu)#ifdef __KVM_HAVE_ARCH_VCPU_DEBUGFSstatic int vcpu_get_pid (void *data,u64 *val) { -struct kvm_vcpu *vcpu = (struct kvm_vcpu *) data; +struct kvm_vcpu *vcpu = data; *val =pid_nr (rcu_access_pointer (vcpu->pid));return 0 ; }
@@ -5445,8 +5445,7 @@ static int kvm_debugfs_open(struct inode *inode, struct file *file, const char *fmt) {int ret; -struct kvm_stat_data *stat_data = (struct kvm_stat_data *) - inode->i_private; +struct kvm_stat_data *stat_data = inode->i_private;/* * The debugfs files are a reference to the kvm struct which
@@ -5467,8 +5466,7 @@ static int kvm_debugfs_open(struct inode *inode, struct file *file,static int kvm_debugfs_release (struct inode *inode,struct file *file) { -struct kvm_stat_data *stat_data = (struct kvm_stat_data *) - inode->i_private; +struct kvm_stat_data *stat_data = inode->i_private;simple_attr_release (inode, file);kvm_put_kvm (stat_data->kvm);
@@ -5517,7 +5515,7 @@ static int kvm_clear_stat_per_vcpu(struct kvm *kvm, size_t offset)static int kvm_stat_data_get (void *data,u64 *val) {int r = -EFAULT ; -struct kvm_stat_data *stat_data = (struct kvm_stat_data *)data; +struct kvm_stat_data *stat_data = data;switch (stat_data->kind) {case KVM_STAT_VM :
@@ -5536,7 +5534,7 @@ static int kvm_stat_data_get(void *data, u64 *val)static int kvm_stat_data_clear (void *data,u64 val) {int r = -EFAULT ; -struct kvm_stat_data *stat_data = (struct kvm_stat_data *)data; +struct kvm_stat_data *stat_data = data;if (val)return -EINVAL ;
Signature · 1 line
2.18.2
Sean Christopherson
reviewerQuoted 12 lines · Li kunyu
void * pointer assignment does not require a forced replacement.
Signed-off-by Li kunyu <[email protected]>--- virt/kvm/kvm_main.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-)virt/kvm/kvm_main.c +0
-0
virt/kvm/kvm_main.c static int create_vcpu_fd(struct kvm_vcpu *vcpu) · line 3865
Quoted 6 lines
virt/kvm/kvm_main.c +1
-1@@ -3861,7 +3861,7 @@ static int create_vcpu_fd(struct kvm_vcpu *vcpu)#ifdef __KVM_HAVE_ARCH_VCPU_DEBUGFSstatic int vcpu_get_pid (void *data,u64 *val) { -struct kvm_vcpu *vcpu = (struct kvm_vcpu *) data; +struct kvm_vcpu *vcpu = data; *val =pid_nr (rcu_access_pointer (vcpu->pid));
Unrelated to your patch: doesn't this need proper RCU protection? E.g. if KVM_RUN changes vcpu->pid between the read and dereference in pid_nr(), and puts the last reference to the old pid.
Quoted 3 lines · Li kunyu
void * pointer assignment does not require a forced replacement.
Applied to kvm-x86 generic, thanks!
[1/1] kvm: kvm_main: Remove unnecessary (void*) conversions
https://github.com/kvm-x86/linux/commit/14aa40a1d05e
--
https://github.com/kvm-x86/linux/tree/next
https://github.com/kvm-x86/linux/tree/fixes