mm, slab: periodically resched in drain_freelist()
PATCH 1/1 mm, slab: periodically resched in drain_freelist()
drain_freelist() can be called with a very large number of slabs to free, such as for kmem_cache_shrink(), or depending on various settings of the slab cache when doing periodic reaping.
If there is a potentially long list of slabs to drain, periodically schedule to ensure we aren't saturating the cpu for too long.
--- mm/slab.c | 2 ++ 1 file changed, 2 insertions(+)
mm/slab.c +2 -0
@@ -2211,6 +2211,8 @@ static int drain_freelist(struct kmem_cache *cache,raw_spin_unlock_irq (&n->list_lock);slab_destroy (cache, slab); nr_freed++; + +cond_resched (); } out:return nr_freed;
Quoted 16 lines · David Rientjes
drain_freelist()can be called with a very large number of slabs to free, such as forkmem_cache_shrink(), or depending on various settings of the slab cache when doing periodic reaping.If there is a potentially long list of slabs to drain, periodically schedule to ensure we aren't saturating the cpu for too long.
Signed-off-by David Rientjes <[email protected]>--- mm/slab.c | 2 ++ 1 file changed, 2 insertions(+)
mm/slab.c static int drain_freelist(struct kmem_cache *cache, · line 2218
Quoted 8 lines
mm/slab.c +2
-0@@ -2211,6 +2211,8 @@ static int drain_freelist(struct kmem_cache *cache,raw_spin_unlock_irq (&n->list_lock);slab_destroy (cache, slab); nr_freed++; + +cond_resched (); } out:return nr_freed;
Looks good to me,
Signature · 2 lines
Thanks, Hyeonggon
Quoted 8 lines · David Rientjes
drain_freelist()can be called with a very large number of slabs to free, such as forkmem_cache_shrink(), or depending on various settings of the slab cache when doing periodic reaping.If there is a potentially long list of slabs to drain, periodically schedule to ensure we aren't saturating the cpu for too long.
Signed-off-by David Rientjes <[email protected]>
Thanks, added to slab/for-6.2-rc3/fixes
Quoted 16 lines
--- mm/slab.c | 2 ++ 1 file changed, 2 insertions(+)mm/slab.c +2
-0@@ -2211,6 +2211,8 @@ static int drain_freelist(struct kmem_cache *cache,raw_spin_unlock_irq (&n->list_lock);slab_destroy (cache, slab); nr_freed++; + +cond_resched (); } out:return nr_freed;