Skip to contentSkip to conversation

usb: storage: de-quirk Seagate Expansion Portable Drive SRD00F1 [0bc2:2320]

PATCH In review Maciej Żenczykowski 3 participants 4 messages Dec 30, 2022 – Dec 31, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: storage: de-quirk Seagate Expansion Portable Drive SRD00F1 [0bc2:2320]

From: Maciej Żenczykowski <[email protected]>

Since November 2017 commit 7fee72d5e8f1 ("uas: Always apply US_FL_NO_ATA_1X quirk to Seagate devices"), the US_FL_NO_ATA_1X is always set for Seagate devices, but it doesn't appear to be required - at least for this one (based on internet searches, probably for a fair number more...).

ID 0bc2:2320 Seagate RSS LLC USB 3.0 bridge [Portable Expansion Drive]

Confirmed via:
smartctl -a /dev/sda
working fine with
modprobe usb_storage quirks=0bc2:2320:
on
5.19.11-1rodete1-amd64

Fixes 7fee72d5e8f1 ("uas: Always apply US_FL_NO_ATA_1X quirk to Seagate devices")
Cc stable <[email protected]>
Cc Hans de Goede <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
---
 drivers/usb/storage/uas-detect.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/usb/storage/uas-detect.h +3 -2
index 3f720faa6f97..74d65810f09a 100644
@@ -112,8 +112,9 @@ static int uas_use_uas_driver(struct usb_interface *intf,
 		}
 	}
 
-	/* All Seagate disk enclosures have broken ATA pass-through support */
-	if (le16_to_cpu(udev->descriptor.idVendor) == 0x0bc2)
+	/* Most Seagate disk enclosures have broken ATA pass-through support */
+	if (le16_to_cpu(udev->descriptor.idVendor) == 0x0bc2 &&
+	    le16_to_cpu(udev->descriptor.idProduct) != 0x2320)
 		flags |= US_FL_NO_ATA_1X;
 
 	usb_stor_adjust_quirks(udev, &flags);
Signature · 1 line
2.39.0.314.g84b9a713c41-goog
#1 lore raw
FYI: kernel test robot notices the stable kernel rule is not satisfied.

Hi,

Thanks for your patch.

FYI: kernel test robot notices the stable kernel rule is not satisfied.

Rule: 'Cc: [email protected]' or 'commit <sha1> upstream.'
Subject: [PATCH] usb: storage: de-quirk Seagate Expansion Portable Drive SRD00F1 [0bc2:2320]

The check is based on https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html

Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
#2 lore raw

Mr. Robot,

your rule matching logic appears to be incorrectly implemented.

Regards,

A human.

Quoted 19 lines · kernel test robot

Hi,

Thanks for your patch.

FYI: kernel test robot notices the stable kernel rule is not satisfied.

Rule: 'Cc: [email protected]' or 'commit <sha1> upstream.'
Subject: [PATCH] usb: storage: de-quirk Seagate Expansion Portable Drive SRD00F1 [0bc2:2320]

The check is based on https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

#3 lore raw
In reply to Maciej Żenczykowski

drivers/usb/storage/uas-detect.h static int uas_use_uas_driver(struct usb_interface *intf, · line 120

Quoted 8 lines · Maciej Żenczykowski
drivers/usb/storage/uas-detect.h +3 -2
-	/* All Seagate disk enclosures have broken ATA pass-through support */
-	if (le16_to_cpu(udev->descriptor.idVendor) == 0x0bc2)
+	/* Most Seagate disk enclosures have broken ATA pass-through support */
+	if (le16_to_cpu(udev->descriptor.idVendor) == 0x0bc2 &&
+	    le16_to_cpu(udev->descriptor.idProduct) != 0x2320)
  		flags |= US_FL_NO_ATA_1X;
 
  	usb_stor_adjust_quirks(udev, &flags);

Hi,

I am sorry, but no. We cannot accomodate a list of of devices to be dequirked that is sure to grow in the future. Please define a flag for these devices.

Regards
Oliver