pinctrl: intel: Use same order of bit fields for PADCFG2
Subsystems (3)
PATCH 1/1 pinctrl: intel: Use same order of bit fields for PADCFG2
PADCFG0 and PADCFG1 are ordered from MSB to LSB, do the same for PADCFG2 bit fields.
Signed-off-by Andy Shevchenko <[email protected]>
--- drivers/pinctrl/intel/pinctrl-intel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/intel/pinctrl-intel.c +1 -1
@@ -88,9 +88,9 @@#define PADCFG1_TERM_800 (BIT(2) | BIT(1) | BIT(0))#define PADCFG2 0x008 -#define PADCFG2_DEBEN BIT(0)#define PADCFG2_DEBOUNCE_SHIFT 1#define PADCFG2_DEBOUNCE_MASK GENMASK(4, 1) +#define PADCFG2_DEBEN BIT(0)#define DEBOUNCE_PERIOD_NSEC 31250
Signature · 1 line
2.35.1
Quoted 2 lines · Andy Shevchenko
PADCFG0 and PADCFG1 are ordered from MSB to LSB, do the same for PADCFG2 bit fields.
Perhaps:
No functional changes.
Quoted 1 line
Signed-off-by Andy Shevchenko <[email protected]>
Acked-by Mika Westerberg <[email protected]>
Quoted 7 lines · Mika Westerberg
Quoted 2 lines · Andy Shevchenko
PADCFG0 and PADCFG1 are ordered from MSB to LSB, do the same for PADCFG2 bit fields.
Perhaps:
No functional changes.
Sure.
Quoted 3 lines
Quoted 1 line
Signed-off-by Andy Shevchenko <[email protected]>Acked-by Mika Westerberg <[email protected]>
Thank you!
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 11 lines · Mika Westerberg
Quoted 2 lines · Andy Shevchenko
PADCFG0 and PADCFG1 are ordered from MSB to LSB, do the same for PADCFG2 bit fields.
Perhaps:
No functional changes.
Quoted 1 line
Signed-off-by Andy Shevchenko <[email protected]>Acked-by Mika Westerberg <[email protected]>
Pushed to my review and testing queue, thanks!
Signature · 2 lines
With Best Regards, Andy Shevchenko