Skip to contentSkip to conversation

drm/tegra: sor: Remove redundant error logging

PATCH Superseded Deepak R Varma 1 participant 3 messages Dec 12, 2022 – Jan 20, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/tegra: sor: Remove redundant error logging

A call to platform_get_irq() already prints an error on failure within its own implementation. So printing another error based on its return value in the caller is redundant and should be removed. The clean up also makes if condition block braces unnecessary. Remove that as well.

Issue identified using platform_get_irq.cocci coccicheck script.

---
Please note: I was not able to build this driver since I did not find the DRM_TEGRA option in menu config. All dependencies listed in the KConfig are enabled, however, I was still not able to find the DRM_TEGRA module in the Graphics-Drivers list. Since the proposed change is known, minor and obvious, I am sending in this patch without build testing.

Any advise on how to enable the DRM_TEGRA module in menuconfig selection list will be helpful. Thank you.

 drivers/gpu/drm/tegra/sor.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/tegra/sor.c +1 -3
index 8af632740673..ceaebd33408d 100644
@@ -3799,10 +3799,8 @@ static int tegra_sor_probe(struct platform_device *pdev)
 	}
 
 	err = platform_get_irq(pdev, 0);
-	if (err < 0) {
-		dev_err(&pdev->dev, "failed to get IRQ: %d\n", err);
+	if (err < 0)
 		goto remove;
-	}
 
 	sor->irq = err;
 

--
2.34.1

#1 lore raw

On Mon, Dec 12, 2022 at 10:44:55AM +0530, Deepak R Varma wrote:

Hello,
May I please request a review and feedback on this patch proposal?

Also, I was able to build the changes for ARM arch verified using modinfo tegr-drm.ko command.

Thank you,
./drv

Quoted 41 lines

A call to platform_get_irq() already prints an error on failure within its own implementation. So printing another error based on its return value in the caller is redundant and should be removed. The clean up also makes if condition block braces unnecessary. Remove that as well.

Issue identified using platform_get_irq.cocci coccicheck script.

---
Please note: I was not able to build this driver since I did not find the DRM_TEGRA option in menu config. All dependencies listed in the KConfig are enabled, however, I was still not able to find the DRM_TEGRA module in the Graphics-Drivers list. Since the proposed change is known, minor and obvious, I am sending in this patch without build testing.

Any advise on how to enable the DRM_TEGRA module in menuconfig selection list will be helpful. Thank you.

 drivers/gpu/drm/tegra/sor.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/tegra/sor.c +1 -4
index 8af632740673..ceaebd33408d 100644
@@ -3799,10 +3799,8 @@ static int tegra_sor_probe(struct platform_device *pdev)
 	}
 
 	err = platform_get_irq(pdev, 0);
-	if (err < 0) {
-		dev_err(&pdev->dev, "failed to get IRQ: %d\n", err);
+	if (err < 0)
 		goto remove;
-	}
 
 	sor->irq = err;
 
--

2.34.1

#2 lore raw
Quoted 7 lines · Deepak R Varma

On Mon, Dec 12, 2022 at 10:44:55AM +0530, Deepak R Varma wrote:

Hello,
May I please request a review and feedback on this patch proposal?

Also, I was able to build the changes for ARM arch verified using modinfo tegr-drm.ko command.

Hello,
I am waiting on a feedback on this patch proposal. Do I need to resend it to get maintainer attention? Please advise.

Thank you,
./drv

Quoted 47 lines

Thank you,
./drv

Quoted 41 lines

A call to platform_get_irq() already prints an error on failure within its own implementation. So printing another error based on its return value in the caller is redundant and should be removed. The clean up also makes if condition block braces unnecessary. Remove that as well.

Issue identified using platform_get_irq.cocci coccicheck script.

---
Please note: I was not able to build this driver since I did not find the DRM_TEGRA option in menu config. All dependencies listed in the KConfig are enabled, however, I was still not able to find the DRM_TEGRA module in the Graphics-Drivers list. Since the proposed change is known, minor and obvious, I am sending in this patch without build testing.

Any advise on how to enable the DRM_TEGRA module in menuconfig selection list will be helpful. Thank you.

 drivers/gpu/drm/tegra/sor.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/tegra/sor.c +1 -4
index 8af632740673..ceaebd33408d 100644
@@ -3799,10 +3799,8 @@ static int tegra_sor_probe(struct platform_device *pdev)
 	}
 
 	err = platform_get_irq(pdev, 0);
-	if (err < 0) {
-		dev_err(&pdev->dev, "failed to get IRQ: %d\n", err);
+	if (err < 0)
 		goto remove;
-	}
 
 	sor->irq = err;
 
--

2.34.1