Skip to contentSkip to conversation

net: phy: enhance Maxlinear GPY loopback disable function

PATCH In review Xu Liang 3 participants 3 messages Dec 14, 2022 – Dec 21, 2022 1 message not in the archive

Subsystems (4)
lore
Share & tools
lore

Xu Liang

author maintainer
#0 lore raw

PATCH 1/1 net: phy: enhance Maxlinear GPY loopback disable function

GPY need 3 seconds to switch out of loopback mode.

---
 drivers/net/phy/mxl-gpy.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/net/phy/mxl-gpy.c +3 -2
index 147d7a5a9b35..81ea7c768657 100644
@@ -770,9 +770,10 @@ static int gpy_loopback(struct phy_device *phydev, bool enable)
 			 enable ? BMCR_LOOPBACK : 0);
 	if (!ret) {
 		/* It takes some time for PHY device to switch
-		 * into/out-of loopback mode.
+		 * into/out-of loopback mode. It takes 3 seconds
+		 * before re-enter loopback mode.
 		 */
-		msleep(100);
+		msleep(enable ? 100 : 3000);
 	}
 
 	return ret;
Signature · 1 line
2.17.1
#1 lore raw

Subject is missing the correct target, "net" in this case.

Quoted 1 line

GPY need 3 seconds to switch out of loopback mode.

What does that mean, what goes wrong with the current 100ms? Could you elaborate a bit more and update the commit message and the comment? Is this true for any GPY PHY supported by this driver?

This probably needs a Fixed tag then.

-michael

A message that is not in the archive (sent off-list or not yet received): PH7PR19MB56130FA71635455AE9DB8524BDE09@PH7PR19MB5613.namprd19.prod.outlook.com

#3 lore raw

Hi,

Quoted 16 lines · Liang Xu

From: Michael Walle <[email protected]>
Sent: Wednesday, December 14, 2022 5:00 PM
Subject: Re: [PATCH] net: phy: enhance Maxlinear GPY loopback disable function

This email was sent from outside of MaxLinear.

Subject is missing the correct target, "net" in this case.

Quoted 1 line

GPY need 3 seconds to switch out of loopback mode.

What does that mean, what goes wrong with the current 100ms? Could you elaborate a bit more and update the commit message and the comment? Is this true for any GPY PHY supported by this driver?

Quoted 4 lines

The internal state machine need almost 3s to fully restore to original state when leaving the loopback mode. This is true for all models supported by this driver.
I will update the commit message and fix the target.
Thank you.

When you state that it takes almost 3 seconds to fully restore the state, what are you basing that upon - what are you using to determine that the state has been fully restored?

Thanks.

Signature · 2 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!