scsi: arcmsr: Use sysfs_emit in show function callsbacks
PATCH 1/1 scsi: arcmsr: Use sysfs_emit in show function callsbacks
According to Documentation/filesystems/sysfs.rst, the show() callback function of kobject attributes should strictly use sysfs_emit instead of sprintf family functions.
Issue identified using the coccinelle device_attr_show.cocci script.
Signed-off-by Deepak R Varma <[email protected]>
--- drivers/scsi/arcmsr/arcmsr_attr.c | 44 ++++++++++--------------------- 1 file changed, 14 insertions(+), 30 deletions(-)
drivers/scsi/arcmsr/arcmsr_attr.c +14 -30
@@ -258,9 +258,7 @@ static ssize_t arcmsr_attr_host_driver_version(struct device *dev, struct device_attribute *attr, char *buf) { - return snprintf(buf, PAGE_SIZE, - "%s\n", - ARCMSR_DRIVER_VERSION); + return sysfs_emit(buf, "%s\n", ARCMSR_DRIVER_VERSION); } static ssize_t
@@ -270,9 +268,8 @@ arcmsr_attr_host_driver_posted_cmd(struct device *dev,struct Scsi_Host *host =class_to_shost (dev);struct AdapterControlBlock *acb = (struct AdapterControlBlock *) host->hostdata; -return snprintf (buf,PAGE_SIZE , -"%4d\n" , -atomic_read (&acb->ccboutstandingcount)); + +return sysfs_emit (buf,"%4d\n" ,atomic_read (&acb->ccboutstandingcount)); } static ssize_t
@@ -282,9 +279,8 @@ arcmsr_attr_host_driver_reset(struct device *dev,struct Scsi_Host *host =class_to_shost (dev);struct AdapterControlBlock *acb = (struct AdapterControlBlock *) host->hostdata; -return snprintf (buf,PAGE_SIZE , -"%4d\n" , - acb->num_resets); + +return sysfs_emit (buf,"%4d\n" , acb->num_resets); } static ssize_t
@@ -294,9 +290,8 @@ arcmsr_attr_host_driver_abort(struct device *dev,struct Scsi_Host *host =class_to_shost (dev);struct AdapterControlBlock *acb = (struct AdapterControlBlock *) host->hostdata; -return snprintf (buf,PAGE_SIZE , -"%4d\n" , - acb->num_aborts); + +return sysfs_emit (buf,"%4d\n" , acb->num_aborts); } static ssize_t
@@ -306,9 +301,8 @@ arcmsr_attr_host_fw_model(struct device *dev, struct device_attribute *attr,struct Scsi_Host *host =class_to_shost (dev);struct AdapterControlBlock *acb = (struct AdapterControlBlock *) host->hostdata; -return snprintf (buf,PAGE_SIZE , -"%s\n" , - acb->firm_model); + +return sysfs_emit (buf,"%s\n" , acb->firm_model); } static ssize_t
@@ -319,9 +313,7 @@ arcmsr_attr_host_fw_version(struct device *dev,struct AdapterControlBlock *acb = (struct AdapterControlBlock *) host->hostdata; -return snprintf (buf,PAGE_SIZE , -"%s\n" , - acb->firm_version); +return sysfs_emit (buf,"%s\n" , acb->firm_version); } static ssize_t
@@ -332,9 +324,7 @@ arcmsr_attr_host_fw_request_len(struct device *dev,struct AdapterControlBlock *acb = (struct AdapterControlBlock *) host->hostdata; -return snprintf (buf,PAGE_SIZE , -"%4d\n" , - acb->firm_request_len); +return sysfs_emit (buf,"%4d\n" , acb->firm_request_len); } static ssize_t
@@ -345,9 +335,7 @@ arcmsr_attr_host_fw_numbers_queue(struct device *dev,struct AdapterControlBlock *acb = (struct AdapterControlBlock *) host->hostdata; -return snprintf (buf,PAGE_SIZE , -"%4d\n" , - acb->firm_numbers_queue); +return sysfs_emit (buf,"%4d\n" , acb->firm_numbers_queue); } static ssize_t
@@ -358,9 +346,7 @@ arcmsr_attr_host_fw_sdram_size(struct device *dev,struct AdapterControlBlock *acb = (struct AdapterControlBlock *) host->hostdata; -return snprintf (buf,PAGE_SIZE , -"%4d\n" , - acb->firm_sdram_size); +return sysfs_emit (buf,"%4d\n" , acb->firm_sdram_size); } static ssize_t
@@ -371,9 +357,7 @@ arcmsr_attr_host_fw_hd_channels(struct device *dev,struct AdapterControlBlock *acb = (struct AdapterControlBlock *) host->hostdata; -return snprintf (buf,PAGE_SIZE , -"%4d\n" , - acb->firm_hd_channels); +return sysfs_emit (buf,"%4d\n" , acb->firm_hd_channels); } static DEVICE_ATTR(host_driver_version, S_IRUGO, arcmsr_attr_host_driver_version, NULL);
--
2.34.1