scsi: message: fusion: Use sysfs_emit in show function callsbacks
Subsystems (2)
PATCH 1/1 scsi: message: fusion: Use sysfs_emit in show function callsbacks
According to Documentation/filesystems/sysfs.rst, the show() callback function of kobject attributes should strictly use sysfs_emit() instead of sprintf() family functions. So, make this change.
Issue identified using the coccinelle device_attr_show.cocci script.
Signed-off-by Deepak R Varma <[email protected]>
--- drivers/message/fusion/mptscsih.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-)
drivers/message/fusion/mptscsih.c +12 -12
@@ -3046,7 +3046,7 @@ mptscsih_version_fw_show(struct device *dev, struct device_attribute *attr,MPT_SCSI_HOST *hd =shost_priv (host);MPT_ADAPTER *ioc = hd->ioc; - return snprintf(buf, PAGE_SIZE, "%02d.%02d.%02d.%02d\n", + return sysfs_emit(buf, "%02d.%02d.%02d.%02d\n", (ioc->facts.FWVersion.Word & 0xFF000000) >> 24, (ioc->facts.FWVersion.Word & 0x00FF0000) >> 16, (ioc->facts.FWVersion.Word & 0x0000FF00) >> 8,
@@ -3062,7 +3062,7 @@ mptscsih_version_bios_show(struct device *dev, struct device_attribute *attr,MPT_SCSI_HOST *hd =shost_priv (host);MPT_ADAPTER *ioc = hd->ioc; - return snprintf(buf, PAGE_SIZE, "%02x.%02x.%02x.%02x\n", + return sysfs_emit(buf, "%02x.%02x.%02x.%02x\n", (ioc->biosVersion & 0xFF000000) >> 24, (ioc->biosVersion & 0x00FF0000) >> 16, (ioc->biosVersion & 0x0000FF00) >> 8,
@@ -3078,7 +3078,7 @@ mptscsih_version_mpi_show(struct device *dev, struct device_attribute *attr,MPT_SCSI_HOST *hd =shost_priv (host);MPT_ADAPTER *ioc = hd->ioc; -return snprintf (buf,PAGE_SIZE ,"%03x\n" , ioc->facts.MsgVersion); +return sysfs_emit (buf,"%03x\n" , ioc->facts.MsgVersion); } static DEVICE_ATTR(version_mpi, S_IRUGO, mptscsih_version_mpi_show, NULL);
@@ -3091,7 +3091,7 @@ char *buf)MPT_SCSI_HOST *hd =shost_priv (host);MPT_ADAPTER *ioc = hd->ioc; -return snprintf (buf,PAGE_SIZE ,"%s\n" , ioc->prod_name); +return sysfs_emit (buf,"%s\n" , ioc->prod_name); } static DEVICE_ATTR(version_product, S_IRUGO, mptscsih_version_product_show, NULL);
@@ -3105,7 +3105,7 @@ mptscsih_version_nvdata_persistent_show(struct device *dev,MPT_SCSI_HOST *hd =shost_priv (host);MPT_ADAPTER *ioc = hd->ioc; -return snprintf (buf,PAGE_SIZE ,"%02xh\n" , +return sysfs_emit (buf,"%02xh\n" , ioc->nvdata_version_persistent); } static DEVICE_ATTR(version_nvdata_persistent, S_IRUGO,
@@ -3119,7 +3119,7 @@ mptscsih_version_nvdata_default_show(struct device *dev,MPT_SCSI_HOST *hd =shost_priv (host);MPT_ADAPTER *ioc = hd->ioc; -return snprintf (buf,PAGE_SIZE ,"%02xh\n" ,ioc->nvdata_version_default); +return sysfs_emit (buf,"%02xh\n" , ioc->nvdata_version_default); } static DEVICE_ATTR(version_nvdata_default, S_IRUGO, mptscsih_version_nvdata_default_show, NULL);
@@ -3132,7 +3132,7 @@ mptscsih_board_name_show(struct device *dev, struct device_attribute *attr,MPT_SCSI_HOST *hd =shost_priv (host);MPT_ADAPTER *ioc = hd->ioc; -return snprintf (buf,PAGE_SIZE ,"%s\n" , ioc->board_name); +return sysfs_emit (buf,"%s\n" , ioc->board_name); } static DEVICE_ATTR(board_name, S_IRUGO, mptscsih_board_name_show, NULL);
@@ -3144,7 +3144,7 @@ mptscsih_board_assembly_show(struct device *dev,MPT_SCSI_HOST *hd =shost_priv (host);MPT_ADAPTER *ioc = hd->ioc; -return snprintf (buf,PAGE_SIZE ,"%s\n" , ioc->board_assembly); +return sysfs_emit (buf,"%s\n" , ioc->board_assembly); } static DEVICE_ATTR(board_assembly, S_IRUGO, mptscsih_board_assembly_show, NULL);
@@ -3157,7 +3157,7 @@ mptscsih_board_tracer_show(struct device *dev, struct device_attribute *attr,MPT_SCSI_HOST *hd =shost_priv (host);MPT_ADAPTER *ioc = hd->ioc; -return snprintf (buf,PAGE_SIZE ,"%s\n" , ioc->board_tracer); +return sysfs_emit (buf,"%s\n" , ioc->board_tracer); } static DEVICE_ATTR(board_tracer, S_IRUGO, mptscsih_board_tracer_show, NULL);
@@ -3170,7 +3170,7 @@ mptscsih_io_delay_show(struct device *dev, struct device_attribute *attr,MPT_SCSI_HOST *hd =shost_priv (host);MPT_ADAPTER *ioc = hd->ioc; -return snprintf (buf,PAGE_SIZE ,"%02d\n" , ioc->io_missing_delay); +return sysfs_emit (buf,"%02d\n" , ioc->io_missing_delay); } static DEVICE_ATTR(io_delay, S_IRUGO, mptscsih_io_delay_show, NULL);
@@ -3183,7 +3183,7 @@ mptscsih_device_delay_show(struct device *dev, struct device_attribute *attr,MPT_SCSI_HOST *hd =shost_priv (host);MPT_ADAPTER *ioc = hd->ioc; -return snprintf (buf,PAGE_SIZE ,"%02d\n" , ioc->device_missing_delay); +return sysfs_emit (buf,"%02d\n" , ioc->device_missing_delay); } static DEVICE_ATTR(device_delay, S_IRUGO, mptscsih_device_delay_show, NULL);
@@ -3196,7 +3196,7 @@ mptscsih_debug_level_show(struct device *dev, struct device_attribute *attr,MPT_SCSI_HOST *hd =shost_priv (host);MPT_ADAPTER *ioc = hd->ioc; -return snprintf (buf,PAGE_SIZE ,"%08xh\n" , ioc->debug_level); +return sysfs_emit (buf,"%08xh\n" , ioc->debug_level); } static ssize_t mptscsih_debug_level_store(struct device *dev, struct device_attribute *attr,
--
2.34.1