scsi: aacraid: Use sysfs_emit in show function callsbacks
Subsystems (2)
PATCH 1/1 scsi: aacraid: Use sysfs_emit in show function callsbacks
According to Documentation/filesystems/sysfs.rst, the show() callback function of kobject attributes should strictly use sysfs_emit() instead of sprintf() family functions. So, make this change.
Also, change in length of lines enables code allows to reformat code for improved readability.
Issue identified using the coccinelle device_attr_show.cocci script.
Signed-off-by Deepak R Varma <[email protected]>
--- drivers/scsi/aacraid/linit.c | 27 ++++++++++++--------------- 1 file changed, 12 insertions(+), 15 deletions(-)
drivers/scsi/aacraid/linit.c +12 -15
@@ -559,11 +559,9 @@ static ssize_t aac_show_raid_level(struct device *dev, struct device_attribute *struct scsi_device *sdev =to_scsi_device (dev);struct aac_dev *aac = (struct aac_dev *)(sdev->host->hostdata);if (sdev_channel (sdev) !=CONTAINER_CHANNEL ) -return snprintf (buf,PAGE_SIZE , sdev->no_uld_attach - ?"Hidden\n" : +return sysfs_emit (buf, sdev->no_uld_attach ?"Hidden\n" : ((aac->jbod && (sdev->type ==TYPE_DISK )) ?"JBOD\n" :"" )); -return snprintf (buf,PAGE_SIZE ,"%s\n" , -get_container_type (aac->fsa_dev[sdev_id (sdev)].type)); +return sysfs_emit (buf,"%s\n" ,get_container_type (aac->fsa_dev[sdev_id (sdev)].type)); }static struct device_attribute aac_raid_level_attr = {
@@ -586,12 +584,13 @@ static ssize_t aac_show_unique_id(struct device *dev,if (sdev_channel (sdev) ==CONTAINER_CHANNEL )memcpy (sn, aac->fsa_dev[sdev_id (sdev)].identifier,sizeof (sn)); -return snprintf (buf,16 *2 +2 , -"%02X%02X%02X%02X%02X%02X%02X%02X%02X%02X%02X%02X%02X%02X%02X%02X\n" , - sn[0 ], sn[1 ], sn[2 ], sn[3 ], - sn[4 ], sn[5 ], sn[6 ], sn[7 ], - sn[8 ], sn[9 ], sn[10 ], sn[11 ], - sn[12 ], sn[13 ], sn[14 ], sn[15 ]); +return sysfs_emit (buf, +"%02X%02X%02X%02X%02X%02X%02X%02X" +"%02X%02X%02X%02X%02X%02X%02X%02X\n" , + sn[0 ], sn[1 ], sn[2 ], sn[3 ], + sn[4 ], sn[5 ], sn[6 ], sn[7 ], + sn[8 ], sn[9 ], sn[10 ], sn[11 ], + sn[12 ], sn[13 ], sn[14 ], sn[15 ]); }static struct device_attribute aac_unique_id_attr = {
@@ -1297,7 +1296,7 @@ static ssize_t aac_show_driver_version(struct device *device,struct device_attribute *attr, char *buf) { - return snprintf(buf, PAGE_SIZE, "%s\n", aac_driver_version); + return sysfs_emit(buf, "%s\n", aac_driver_version); } static ssize_t aac_show_serial_number(struct device *device,
@@ -1323,15 +1322,13 @@ static ssize_t aac_show_serial_number(struct device *device,static ssize_t aac_show_max_channel (struct device *device,struct device_attribute *attr,char *buf) { -return snprintf (buf,PAGE_SIZE ,"%d\n" , -class_to_shost (device)->max_channel); +return sysfs_emit (buf,"%d\n" ,class_to_shost (device)->max_channel); }static ssize_t aac_show_max_id (struct device *device,struct device_attribute *attr,char *buf) { -return snprintf (buf,PAGE_SIZE ,"%d\n" , -class_to_shost (device)->max_id); +return sysfs_emit (buf,"%d\n" ,class_to_shost (device)->max_id); } static ssize_t aac_store_reset_adapter(struct device *device,
--
2.34.1