Skip to contentSkip to conversation

gpu: host1x: No need for Null pointer check before kfree

PATCH New Deepak R Varma 1 participant 1 message Dec 27, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpu: host1x: No need for Null pointer check before kfree

kfree() & vfree() internally performs NULL check on the pointer handed to it and take no action if it indeed is NULL. Hence there is no need for a pre-check of the memory pointer before handing it to kfree()/vfree().

Issue reported by ifnullfree.cocci Coccinelle semantic patch script.

---
 drivers/gpu/host1x/fence.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/host1x/fence.c +1 -2
index df428bcbae69..42498902947f 100644
@@ -93,8 +93,7 @@ static void host1x_syncpt_fence_release(struct dma_fence *f)
 {
 	struct host1x_syncpt_fence *sf = to_host1x_fence(f);
 
-	if (sf->waiter)
-		kfree(sf->waiter);
+	kfree(sf->waiter);
 
 	dma_fence_free(f);
 }

--
2.34.1