platform/x86: int3472/discrete: Ensure the clk/power enable pins are in output mode
PATCH 1/1 platform/x86: int3472/discrete: Ensure the clk/power enable pins are in output mode
acpi_get_and_request_gpiod() does not take a gpio_lookup_flags argument specifying that the pins direction should be initialized to a specific value.
This means that in some cases the pins might be left in input mode, causing the gpiod_set() calls made to enable the clk / regulator to not work.
One example of this problem is the clk-enable GPIO for the ov01a1s sensor on a Dell Latitude 9420 being left in input mode causing the clk to never get enabled.
Explicitly set the direction of the pins to output to fix this.
---
Changes in v4:
- Split out of the "int3472/media privacy LED support" series, so that this can be applied separately as it really is a bug-fix
--- drivers/platform/x86/intel/int3472/clk_and_regulator.c | 3 +++ drivers/platform/x86/intel/int3472/discrete.c | 4 ++++ 2 files changed, 7 insertions(+)
drivers/platform/x86/intel/int3472/clk_and_regulator.c +3 -0
@@ -181,6 +181,9 @@ int skl_int3472_register_regulator(struct int3472_discrete_device *int3472,return PTR_ERR (int3472->regulator.gpio); } +/* Ensure the pin is in output mode and non-active state */ +gpiod_direction_output (int3472->regulator.gpio,0 ); + cfg.dev = &int3472->adev->dev; cfg.init_data = &init_data; cfg.ena_gpiod = int3472->regulator.gpio;
drivers/platform/x86/intel/int3472/discrete.c +4 -0
@@ -168,6 +168,8 @@ static int skl_int3472_map_gpio_to_clk(struct int3472_discrete_device *int3472,return (PTR_ERR (gpio)); int3472->clock.ena_gpio = gpio; +/* Ensure the pin is in output mode and non-active state */ +gpiod_direction_output (int3472->clock.ena_gpio,0 );break ;case INT3472_GPIO_TYPE_PRIVACY_LED : gpio =acpi_get_and_request_gpiod (path, pin,"int3472,privacy-led" );
@@ -175,6 +177,8 @@ static int skl_int3472_map_gpio_to_clk(struct int3472_discrete_device *int3472,return (PTR_ERR (gpio)); int3472->clock.led_gpio = gpio; +/* Ensure the pin is in output mode and non-active state */ +gpiod_direction_output (int3472->clock.led_gpio,0 );break ;default :dev_err (int3472->dev,"Invalid GPIO type 0x%02x for clock\n" , type);
Signature · 1 line
2.39.0
Quoted 4 lines · Hans de Goede
acpi_get_and_request_gpiod()does not take agpio_lookup_flagsargument specifying that the pins direction should be initialized to a specific value.
Quoted 8 lines
This means that in some cases the pins might be left in input mode, causing the
gpiod_set()calls made to enable the clk / regulator to not work.One example of this problem is the clk-enable GPIO for the ov01a1s sensor on a Dell Latitude 9420 being left in input mode causing the clk to never get enabled.
Explicitly set the direction of the pins to output to fix this.
LGTM,
thanks!
Quoted 50 lines
Fixes 5de691bffe57 ("platform/x86: Add intel_skl_int3472 driver")Signed-off-by Hans de Goede <[email protected]>---
Changes in v4:
- Split out of the "int3472/media privacy LED support" series, so that this can be applied separately as it really is a bug-fix--- drivers/platform/x86/intel/int3472/clk_and_regulator.c | 3 +++ drivers/platform/x86/intel/int3472/discrete.c | 4 ++++ 2 files changed, 7 insertions(+)drivers/platform/x86/intel/int3472/clk_and_regulator.c +3
-0@@ -181,6 +181,9 @@ int skl_int3472_register_regulator(struct int3472_discrete_device *int3472,return PTR_ERR (int3472->regulator.gpio); } +/* Ensure the pin is in output mode and non-active state */ +gpiod_direction_output (int3472->regulator.gpio,0 ); + cfg.dev = &int3472->adev->dev; cfg.init_data = &init_data; cfg.ena_gpiod = int3472->regulator.gpio;drivers/platform/x86/intel/int3472/discrete.c +4
-0@@ -168,6 +168,8 @@ static int skl_int3472_map_gpio_to_clk(struct int3472_discrete_device *int3472,return (PTR_ERR (gpio)); int3472->clock.ena_gpio = gpio; +/* Ensure the pin is in output mode and non-active state */ +gpiod_direction_output (int3472->clock.ena_gpio,0 );break ;case INT3472_GPIO_TYPE_PRIVACY_LED : gpio =acpi_get_and_request_gpiod (path, pin,"int3472,privacy-led" );@@ -175,6 +177,8 @@ static int skl_int3472_map_gpio_to_clk(struct int3472_discrete_device *int3472,return (PTR_ERR (gpio)); int3472->clock.led_gpio = gpio; +/* Ensure the pin is in output mode and non-active state */ +gpiod_direction_output (int3472->clock.led_gpio,0 );break ;default :dev_err (int3472->dev,"Invalid GPIO type 0x%02x for clock\n" , type);Signature · 1 line
2.39.0
Signature · 2 lines
With Best Regards, Andy Shevchenko
Daniel Scally
Reviewed-byHi Hans
Quoted 8 lines · Andy Shevchenko
Quoted 7 lines · Hans de Goede
acpi_get_and_request_gpiod()does not take agpio_lookup_flagsargument specifying that the pins direction should be initialized to a specific value.This means that in some cases the pins might be left in input mode, causing the
gpiod_set()calls made to enable the clk / regulator to not work.
Quoted 8 lines
Quoted 5 lines
One example of this problem is the clk-enable GPIO for the ov01a1s sensor on a Dell Latitude 9420 being left in input mode causing the clk to never get enabled.
Explicitly set the direction of the pins to output to fix this.
LGTM,
Reviewed-by Andy Shevchenko <[email protected]>thanks!
And to me:
Quoted 51 lines
Quoted 51 lines
Fixes 5de691bffe57 ("platform/x86: Add intel_skl_int3472 driver")Signed-off-by Hans de Goede <[email protected]>---
Changes in v4:
- Split out of the "int3472/media privacy LED support" series, so that this can be applied separately as it really is a bug-fix--- drivers/platform/x86/intel/int3472/clk_and_regulator.c | 3 +++ drivers/platform/x86/intel/int3472/discrete.c | 4 ++++ 2 files changed, 7 insertions(+)drivers/platform/x86/intel/int3472/clk_and_regulator.c +3
-0@@ -181,6 +181,9 @@ int skl_int3472_register_regulator(struct int3472_discrete_device *int3472,return PTR_ERR (int3472->regulator.gpio); } +/* Ensure the pin is in output mode and non-active state */ +gpiod_direction_output (int3472->regulator.gpio,0 ); + cfg.dev = &int3472->adev->dev; cfg.init_data = &init_data; cfg.ena_gpiod = int3472->regulator.gpio;drivers/platform/x86/intel/int3472/discrete.c +4
-0@@ -168,6 +168,8 @@ static int skl_int3472_map_gpio_to_clk(struct int3472_discrete_device *int3472,return (PTR_ERR (gpio)); int3472->clock.ena_gpio = gpio; +/* Ensure the pin is in output mode and non-active state */ +gpiod_direction_output (int3472->clock.ena_gpio,0 );break ;case INT3472_GPIO_TYPE_PRIVACY_LED : gpio =acpi_get_and_request_gpiod (path, pin,"int3472,privacy-led" );@@ -175,6 +177,8 @@ static int skl_int3472_map_gpio_to_clk(struct int3472_discrete_device *int3472,return (PTR_ERR (gpio)); int3472->clock.led_gpio = gpio; +/* Ensure the pin is in output mode and non-active state */ +gpiod_direction_output (int3472->clock.led_gpio,0 );break ;default :dev_err (int3472->dev,"Invalid GPIO type 0x%02x for clock\n" , type);Signature · 1 line
2.39.0
Quoted 7 lines · Hans de Goede
acpi_get_and_request_gpiod()does not take agpio_lookup_flagsargument specifying that the pins direction should be initialized to a specific value.This means that in some cases the pins might be left in input mode, causing the
gpiod_set()calls made to enable the clk / regulator to not work.
Quoted 8 lines
One example of this problem is the clk-enable GPIO for the ov01a1s sensor on a Dell Latitude 9420 being left in input mode causing the clk to never get enabled.
Explicitly set the direction of the pins to output to fix this.
Fixes 5de691bffe57 ("platform/x86: Add intel_skl_int3472 driver")Signed-off-by Hans de Goede <[email protected]>
Signature · 1 line
Sakari Ailus
Hi,
Quoted 7 lines · Hans de Goede
acpi_get_and_request_gpiod()does not take agpio_lookup_flagsargument specifying that the pins direction should be initialized to a specific value.This means that in some cases the pins might be left in input mode, causing the
gpiod_set()calls made to enable the clk / regulator to not work.
Quoted 8 lines
One example of this problem is the clk-enable GPIO for the ov01a1s sensor on a Dell Latitude 9420 being left in input mode causing the clk to never get enabled.
Explicitly set the direction of the pins to output to fix this.
Fixes 5de691bffe57 ("platform/x86: Add intel_skl_int3472 driver")Signed-off-by Hans de Goede <[email protected]>
I've added this to my review-hans (soon to be fixes) branch now.
Thank you all for the reviews.
Regards,
Hans
Quoted 45 lines
---
Changes in v4:
- Split out of the "int3472/media privacy LED support" series, so that this can be applied separately as it really is a bug-fix--- drivers/platform/x86/intel/int3472/clk_and_regulator.c | 3 +++ drivers/platform/x86/intel/int3472/discrete.c | 4 ++++ 2 files changed, 7 insertions(+)drivers/platform/x86/intel/int3472/clk_and_regulator.c +3
-0@@ -181,6 +181,9 @@ int skl_int3472_register_regulator(struct int3472_discrete_device *int3472,return PTR_ERR (int3472->regulator.gpio); } +/* Ensure the pin is in output mode and non-active state */ +gpiod_direction_output (int3472->regulator.gpio,0 ); + cfg.dev = &int3472->adev->dev; cfg.init_data = &init_data; cfg.ena_gpiod = int3472->regulator.gpio;drivers/platform/x86/intel/int3472/discrete.c +4
-0@@ -168,6 +168,8 @@ static int skl_int3472_map_gpio_to_clk(struct int3472_discrete_device *int3472,return (PTR_ERR (gpio)); int3472->clock.ena_gpio = gpio; +/* Ensure the pin is in output mode and non-active state */ +gpiod_direction_output (int3472->clock.ena_gpio,0 );break ;case INT3472_GPIO_TYPE_PRIVACY_LED : gpio =acpi_get_and_request_gpiod (path, pin,"int3472,privacy-led" );@@ -175,6 +177,8 @@ static int skl_int3472_map_gpio_to_clk(struct int3472_discrete_device *int3472,return (PTR_ERR (gpio)); int3472->clock.led_gpio = gpio; +/* Ensure the pin is in output mode and non-active state */ +gpiod_direction_output (int3472->clock.led_gpio,0 );break ;default :dev_err (int3472->dev,"Invalid GPIO type 0x%02x for clock\n" , type);