staging: vchiq_arm.c: Declare vchiq_platform_init as static
Subsystems (2)
PATCH 1/1 staging: vchiq_arm.c: Declare vchiq_platform_init as static
Modified vchiq_platform_init() as static to fix sparse warning
Quoted 2 lines
warning: symbol '
vchiq_platform_init' was not declared. Should it be static?
--- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +1 -1
@@ -462,7 +462,7 @@ free_pagelist(struct vchiq_instance *instance, struct vchiq_pagelist_info *pagelcleanup_pagelistinfo (instance, pagelistinfo); } -int vchiq_platform_init (struct platform_device *pdev,struct vchiq_state *state) +static int vchiq_platform_init (struct platform_device *pdev,struct vchiq_state *state) {struct device *dev = &pdev->dev;struct vchiq_drvdata *drvdata =platform_get_drvdata (pdev);
Signature · 1 line
2.39.0
Greg KH
maintainerQuoted 3 lines · Gaurav Pathak
Modified
vchiq_platform_init()as static to fix sparse warningQuoted 2 lines
warning: symbol '
vchiq_platform_init' was not declared. Should it be static?
Put the warning line all on one line, no need to wrap that.
Quoted 22 lines
Signed-off-by Gaurav Pathak <[email protected]>--- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +1
-1@@ -462,7 +462,7 @@ free_pagelist(struct vchiq_instance *instance, struct vchiq_pagelist_info *pagelcleanup_pagelistinfo (instance, pagelistinfo); } -int vchiq_platform_init (struct platform_device *pdev,struct vchiq_state *state) +static int vchiq_platform_init (struct platform_device *pdev,struct vchiq_state *state) {struct device *dev = &pdev->dev;struct vchiq_drvdata *drvdata =platform_get_drvdata (pdev);Signature · 1 line
2.39.0
What changed to enable this version of the patch to work properly compared to the previous submissions that broke the build? Did you test this and it now works properly?
thanks,
greg k-h
Hi Greg,
After submitting the patch, I realized this is the duplicate patch of https://www.spinics.net/lists/arm-kernel/msg976512.html
I am in the process of reproducing the issue reported by kernel test robot in the original patch submission. If I am successful, I will try to fix other warnings.
Best,
Gaurav
Quoted 37 lines · Greg KH
Quoted 3 lines · Gaurav Pathak
Modified
vchiq_platform_init()as static to fix sparse warningQuoted 2 lines
warning: symbol '
vchiq_platform_init' was not declared. Should it be static?Put the warning line all on one line, no need to wrap that.
Quoted 22 lines
Signed-off-by Gaurav Pathak <[email protected]>--- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +1
-1@@ -462,7 +462,7 @@ free_pagelist(struct vchiq_instance *instance, struct vchiq_pagelist_info *pagelcleanup_pagelistinfo (instance, pagelistinfo); } -int vchiq_platform_init (struct platform_device *pdev,struct vchiq_state *state) +static int vchiq_platform_init (struct platform_device *pdev,struct vchiq_state *state) {struct device *dev = &pdev->dev;struct vchiq_drvdata *drvdata =platform_get_drvdata (pdev);Signature · 1 line
2.39.0What changed to enable this version of the patch to work properly compared to the previous submissions that broke the build? Did you test this and it now works properly?
thanks,
greg k-h