staging: media: imx: remove unnecessary return variable
PATCH 1/1 staging: media: imx: remove unnecessary return variable
The function imx_media_fim_set_stream() can directly return 0 instead of using a ret variable which never changes its value. Issue identified using the returnvar.cocci Coccinelle semantic patch.
--- drivers/staging/media/imx/imx-media-fim.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/media/imx/imx-media-fim.c +1 -2
@@ -373,7 +373,6 @@ int imx_media_fim_set_stream(struct imx_media_fim *fim, bool on) {unsigned long flags; -int ret =0 ;v4l2_ctrl_lock (fim->ctrl[FIM_CL_ENABLE ]);
@@ -393,7 +392,7 @@ int imx_media_fim_set_stream(struct imx_media_fim *fim, fim->stream_on = on; out:v4l2_ctrl_unlock (fim->ctrl[FIM_CL_ENABLE ]); -return ret; +return 0 ; }int imx_media_fim_add_controls (struct imx_media_fim *fim)
--
2.34.1
Fabio Estevam
reviewerQuoted 23 lines · Deepak R Varma
The function
imx_media_fim_set_stream()can directly return 0 instead of using a ret variable which never changes its value. Issue identified using thereturnvar.cocciCoccinelle semantic patch.Signed-off-by Deepak R Varma <[email protected]>--- drivers/staging/media/imx/imx-media-fim.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/staging/media/imx/imx-media-fim.c +0
-1@@ -373,7 +373,6 @@ int imx_media_fim_set_stream(struct imx_media_fim *fim, bool on) {unsigned long flags; -int ret =0 ;v4l2_ctrl_lock (fim->ctrl[FIM_CL_ENABLE ]);
drivers/staging/media/imx/imx-media-fim.c int imx_media_fim_set_stream(struct imx_media_fim *fim, · line 395
Quoted 5 lines
drivers/staging/media/imx/imx-media-fim.c +1
-1@@ -393,7 +392,7 @@ int imx_media_fim_set_stream(struct imx_media_fim *fim, fim->stream_on = on; out:v4l2_ctrl_unlock (fim->ctrl[FIM_CL_ENABLE ]); -return ret; +return 0 ;
Maybe you could change imx_media_fim_set_stream() to a void function instead?
Quoted 23 lines · Fabio Estevam
Quoted 22 lines · Deepak R Varma
The function
imx_media_fim_set_stream()can directly return 0 instead of using a ret variable which never changes its value. Issue identified using thereturnvar.cocciCoccinelle semantic patch.Signed-off-by Deepak R Varma <[email protected]>--- drivers/staging/media/imx/imx-media-fim.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/staging/media/imx/imx-media-fim.c +0
-1@@ -373,7 +373,6 @@ int imx_media_fim_set_stream(struct imx_media_fim *fim, bool on) {unsigned long flags; -int ret =0 ;v4l2_ctrl_lock (fim->ctrl[FIM_CL_ENABLE ]);
Quoted 8 lines
drivers/staging/media/imx/imx-media-fim.c int imx_media_fim_set_stream(struct imx_media_fim *fim, · line 395
Quoted 6 lines
drivers/staging/media/imx/imx-media-fim.c +1
-1@@ -393,7 +392,7 @@ int imx_media_fim_set_stream(struct imx_media_fim *fim, fim->stream_on = on; out:v4l2_ctrl_unlock (fim->ctrl[FIM_CL_ENABLE ]); -return ret; +return 0 ;Maybe you could change
imx_media_fim_set_stream()to a void function instead?
That sounds more accurate. I will send in the revision as v2. Thank you so much for the feedback.
Regards,
./drv
Quoted 1 line
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel