mfd: axp20x: fix order of pek rise and fall events
PATCH v2 1/1 mfd: axp20x: fix order of pek rise and fall events
The power button can get "stuck" if the rising edge and falling edge irq are read in the same pass. This can often be triggered when resuming from suspend if the power button is released before the kernel handles the interrupt.
Swapping the order of the rise and fall events makes sure that the press event is handled first, which prevents this situation.
---
changes in v2:
- add comments describing the reason these are out of bit order
previous version:
https://lore.kernel.org/lkml/[email protected]/T/
include/linux/mfd/axp20x.h | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-)
include/linux/mfd/axp20x.h +10 -5
@@ -432,8 +432,9 @@ enum {AXP152_IRQ_PEK_SHORT ,AXP152_IRQ_PEK_LONG ,AXP152_IRQ_TIMER , -AXP152_IRQ_PEK_RIS_EDGE , +/* out of bit order to make sure the press event is handled first */ AXP152_IRQ_PEK_FAL_EDGE , +AXP152_IRQ_PEK_RIS_EDGE ,AXP152_IRQ_GPIO3_INPUT ,AXP152_IRQ_GPIO2_INPUT , AXP152_IRQ_GPIO1_INPUT,
@@ -472,8 +473,9 @@ enum {AXP20X_IRQ_LOW_PWR_LVL1 ,AXP20X_IRQ_LOW_PWR_LVL2 ,AXP20X_IRQ_TIMER , -AXP20X_IRQ_PEK_RIS_EDGE , +/* out of bit order to make sure the press event is handled first */ AXP20X_IRQ_PEK_FAL_EDGE , +AXP20X_IRQ_PEK_RIS_EDGE ,AXP20X_IRQ_GPIO3_INPUT ,AXP20X_IRQ_GPIO2_INPUT , AXP20X_IRQ_GPIO1_INPUT,
@@ -502,8 +504,9 @@ enum axp22x_irqs {AXP22X_IRQ_LOW_PWR_LVL1 ,AXP22X_IRQ_LOW_PWR_LVL2 ,AXP22X_IRQ_TIMER , -AXP22X_IRQ_PEK_RIS_EDGE , +/* out of bit order to make sure the press event is handled first */ AXP22X_IRQ_PEK_FAL_EDGE , +AXP22X_IRQ_PEK_RIS_EDGE ,AXP22X_IRQ_GPIO1_INPUT , AXP22X_IRQ_GPIO0_INPUT, };
@@ -571,8 +574,9 @@ enum axp803_irqs {AXP803_IRQ_LOW_PWR_LVL1 ,AXP803_IRQ_LOW_PWR_LVL2 ,AXP803_IRQ_TIMER , -AXP803_IRQ_PEK_RIS_EDGE , +/* out of bit order to make sure the press event is handled first */ AXP803_IRQ_PEK_FAL_EDGE , +AXP803_IRQ_PEK_RIS_EDGE ,AXP803_IRQ_PEK_SHORT ,AXP803_IRQ_PEK_LONG , AXP803_IRQ_PEK_OVER_OFF,
@@ -623,8 +627,9 @@ enum axp809_irqs {AXP809_IRQ_LOW_PWR_LVL1 ,AXP809_IRQ_LOW_PWR_LVL2 ,AXP809_IRQ_TIMER , -AXP809_IRQ_PEK_RIS_EDGE , +/* out of bit order to make sure the press event is handled first */ AXP809_IRQ_PEK_FAL_EDGE , +AXP809_IRQ_PEK_RIS_EDGE ,AXP809_IRQ_PEK_SHORT ,AXP809_IRQ_PEK_LONG , AXP809_IRQ_PEK_OVER_OFF,
Signature · 1 line
2.38.1
Quoted 10 lines · Aren Moynihan
The power button can get "stuck" if the rising edge and falling edge irq are read in the same pass. This can often be triggered when resuming from suspend if the power button is released before the kernel handles the interrupt.
Swapping the order of the rise and fall events makes sure that the press event is handled first, which prevents this situation.
Signed-off-by Aren Moynihan <[email protected]>
Quoted 13 lines · Aren Moynihan
The power button can get "stuck" if the rising edge and falling edge irq are read in the same pass. This can often be triggered when resuming from suspend if the power button is released before the kernel handles the interrupt.
Swapping the order of the rise and fall events makes sure that the press event is handled first, which prevents this situation.
Signed-off-by Aren Moynihan <[email protected]>---
changes in v2:
- add comments describing the reason these are out of bit order
Quoted 5 lines
previous version:
https://lore.kernel.org/lkml/[email protected]/T/include/linux/mfd/axp20x.h | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-)
Quoted 13 lines · Aren Moynihan
The power button can get "stuck" if the rising edge and falling edge irq are read in the same pass. This can often be triggered when resuming from suspend if the power button is released before the kernel handles the interrupt.
Swapping the order of the rise and fall events makes sure that the press event is handled first, which prevents this situation.
Signed-off-by Aren Moynihan <[email protected]>---
changes in v2:
- add comments describing the reason these are out of bit order
Quoted 5 lines
previous version:
https://lore.kernel.org/lkml/[email protected]/T/include/linux/mfd/axp20x.h | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-)
Applied, thanks
Signature · 1 line
Lee Jones [李琼斯]