Skip to contentSkip to conversation

thunderbolt: Refactor tb_acpi_add_link()

PATCH Applied Andy Shevchenko 2 participants 2 messages Jan 2, 2023 – Jan 4, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 thunderbolt: Refactor tb_acpi_add_link()

Convert while loop into do-while with only a single call to acpi_get_first_physical_node(). No functional change intended.

---
 drivers/thunderbolt/acpi.c | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)
drivers/thunderbolt/acpi.c +5 -8
index 317e4f5fdb97..628225deb8fe 100644
@@ -36,16 +36,13 @@ static acpi_status tb_acpi_add_link(acpi_handle handle, u32 level, void *data,
 	 * We need to do this because the xHCI driver might not yet be
 	 * bound so the USB3 SuperSpeed ports are not yet created.
 	 */
-	dev = acpi_get_first_physical_node(adev);
-	while (!dev) {
-		adev = acpi_dev_parent(adev);
-		if (!adev)
-			break;
+	do {
 		dev = acpi_get_first_physical_node(adev);
-	}
+		if (dev)
+			break;
 
-	if (!dev)
-		goto out_put;
+		adev = acpi_dev_parent(adev);
+	} while (adev);
 
 	/*
 	 * Check that the device is PCIe. This is because USB3
Signature · 1 line
2.35.1