Skip to contentSkip to conversation

leds: led-core: Fix refcount leak in of_led_get

PATCH Applied Miaoqian Lin 2 participants 2 messages Dec 20, 2022 – Jan 4, 2023 LED

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 leds: led-core: Fix refcount leak in of_led_get

class_find_device_by_of_node() calls class_find_device(), it will take the reference, use the put_device() to drop the reference when not need anymore.

Fixes 699a8c7c4bd3 ("leds: Add of_led_get() and led_put()")
---
 drivers/leds/led-class.c | 1 +
 1 file changed, 1 insertion(+)
drivers/leds/led-class.c +1 -0
index 6a8ea94834fa..705b7a89f3d8 100644
@@ -240,6 +240,7 @@ struct led_classdev *of_led_get(struct device_node *np, int index)
 		return ERR_PTR(-EPROBE_DEFER);
 
 	led_cdev = dev_get_drvdata(led_dev);
+	put_device(led_dev);
 
 	if (!try_module_get(led_cdev->dev->parent->driver->owner))
 		return ERR_PTR(-ENODEV);
Signature · 1 line
2.25.1
maintainer Applied
#1 lore raw
Quoted 9 lines · Miaoqian Lin

class_find_device_by_of_node() calls class_find_device(), it will take the reference, use the put_device() to drop the reference when not need anymore.

Fixes 699a8c7c4bd3 ("leds: Add of_led_get() and led_put()")
---
 drivers/leds/led-class.c | 1 +
 1 file changed, 1 insertion(+)

Applied, thanks

Signature · 1 line
Lee Jones [李琼斯]