backlight: tosa: Use backlight helper
Subsystems (2)
PATCH RESEND 4/4 backlight: tosa: Use backlight helper
Instead of retrieving the backlight brightness in struct backlight_properties manually, and then checking whether the backlight should be on at all, use backlight_get_brightness() which does all this and insulates this from future changes.
--- drivers/video/backlight/tosa_bl.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
drivers/video/backlight/tosa_bl.c +1 -6
@@ -50,13 +50,8 @@ static void tosa_bl_set_backlight(struct tosa_bl_data *data, int brightness)static int tosa_bl_update_status (struct backlight_device *dev) { -struct backlight_properties *props = &dev->props;struct tosa_bl_data *data =bl_get_data (dev); -int power =max (props->power, props->fb_blank); -int brightness = props->brightness; - -if (power) - brightness =0 ; +int brightness =backlight_get_brightness (dev);tosa_bl_set_backlight (data, brightness);
Signature · 1 line
2.30.2
Quoted 6 lines · Stephen Kitt
Instead of retrieving the backlight brightness in struct
backlight_propertiesmanually, and then checking whether the backlight should be on at all, usebacklight_get_brightness()which does all this and insulates this from future changes.Signed-off-by Stephen Kitt <[email protected]>
Quoted 25 lines
--- drivers/video/backlight/tosa_bl.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)drivers/video/backlight/tosa_bl.c +1
-6@@ -50,13 +50,8 @@ static void tosa_bl_set_backlight(struct tosa_bl_data *data, int brightness)static int tosa_bl_update_status (struct backlight_device *dev) { -struct backlight_properties *props = &dev->props;struct tosa_bl_data *data =bl_get_data (dev); -int power =max (props->power, props->fb_blank); -int brightness = props->brightness; - -if (power) - brightness =0 ; +int brightness =backlight_get_brightness (dev);tosa_bl_set_backlight (data, brightness);Signature · 1 line
2.30.2
Quoted 6 lines · Stephen Kitt
Instead of retrieving the backlight brightness in struct
backlight_propertiesmanually, and then checking whether the backlight should be on at all, usebacklight_get_brightness()which does all this and insulates this from future changes.Signed-off-by Stephen Kitt <[email protected]>
I just realized...
This driver is about to be deleted by Arnd's effort to remove the PXA platform, so the patch is not relevant and can be ignored.
See https://lore.kernel.org/dri-devel/[email protected]/
Sam
Quoted 25 lines
--- drivers/video/backlight/tosa_bl.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)drivers/video/backlight/tosa_bl.c +1
-6@@ -50,13 +50,8 @@ static void tosa_bl_set_backlight(struct tosa_bl_data *data, int brightness)static int tosa_bl_update_status (struct backlight_device *dev) { -struct backlight_properties *props = &dev->props;struct tosa_bl_data *data =bl_get_data (dev); -int power =max (props->power, props->fb_blank); -int brightness = props->brightness; - -if (power) - brightness =0 ; +int brightness =backlight_get_brightness (dev);tosa_bl_set_backlight (data, brightness);Signature · 1 line
2.30.2
Quoted 6 lines · Stephen Kitt
Instead of retrieving the backlight brightness in struct
backlight_propertiesmanually, and then checking whether the backlight should be on at all, usebacklight_get_brightness()which does all this and insulates this from future changes.Signed-off-by Stephen Kitt <[email protected]>
For the tools:
D.