alpha: fix FEN fault handling
PATCH 1/1 alpha: fix FEN fault handling
Type 3 instruction fault (FPU insn with FPU disabled) is handled by quietly enabling FPU and returning. Which is fine, except that we need to do that both for fault in userland and in the kernel; the latter *can* legitimately happen - all it takes is this:
.global _start_start:
call_pal 0xae lda $0, 0 ldq $0, 0($0)
- call_pal CLRFEN to clear "FPU enabled" flag and arrange for a signal delivery (SIGSEGV in this case).
Fixed by moving the handling of type 3 into the common part of do_entIF(), before we check for kernel vs. user mode.
Incidentally, check for kernel mode is unidiomatic; the normal way to do that is !user_mode(regs). The difference is that the open-coded variant treats any of bits 63..3 of regs->ps being set as "it's user mode" while the normal approach is to check just the bit 3. PS is a 4-bit register and regs->ps always will have bits 63..4 clear, so the open-code variant here is actually equivalent to !user_mode(regs). Harder to follow, though...
Reproducer above will crash any box where CLRFEN is not ignored by PAL (== any actual hardware, AFAICS; PAL used in qemu doesn't bother implementing that crap).
---
arch/alpha/kernel/traps.c +15 -15
@@ -233,7 +233,21 @@ do_entIF(unsigned long type, struct pt_regs *regs) {int signo, code; -if ((regs->ps & ~IPL_MAX ) ==0 ) { +if (type ==3 ) {/* FEN fault */ +/* Irritating users can call PAL_clrfen to disable the +FPU for the process. The kernel will then trap in +do_switch_stack and undo_switch_stack when we try +to save and restore the FP registers. + +Given that GCC by default generates code that uses the +FP registers, PAL_clrfen is not useful except for DoS +attacks. So turn the bleeding FPU back on and be done +with it. */ +current_thread_info ()->pcb.flags |=1 ; +__reload_thread (¤t_thread_info ()->pcb); +return ; + } +if (!user_mode (regs)) {if (type ==1 ) {const unsigned int *data = (const unsigned int *) regs->pc;
@@ -366,20 +380,6 @@ do_entIF(unsigned long type, struct pt_regs *regs) }break ; -case 3 :/* FEN fault */ -/* Irritating users can call PAL_clrfen to disable the -FPU for the process. The kernel will then trap in -do_switch_stack and undo_switch_stack when we try -to save and restore the FP registers. - -Given that GCC by default generates code that uses the -FP registers, PAL_clrfen is not useful except for DoS -attacks. So turn the bleeding FPU back on and be done -with it. */ -current_thread_info ()->pcb.flags |=1 ; -__reload_thread (¤t_thread_info ()->pcb); -return ; -case 5 :/* illoc */ default :/* unexpected instruction-fault type */ ;
Quoted 25 lines · Al Viro
Type 3 instruction fault (FPU insn with FPU disabled) is handled by quietly enabling FPU and returning. Which is fine, except that we need to do that both for fault in userland and in the kernel; the latter *can* legitimately happen - all it takes is this:
.global
_start_start:call_pal 0xae lda $0, 0 ldq $0, 0($0)-
call_palCLRFEN to clear "FPU enabled" flag and arrange for a signal delivery (SIGSEGV in this case).Fixed by moving the handling of type 3 into the common part of
do_entIF(), before we check for kernel vs. user mode.Incidentally, check for kernel mode is unidiomatic; the normal way to do that is !user_mode(regs). The difference is that the open-coded variant treats any of bits 63..3 of
regs->psbeing set as "it's user mode" while the normal approach is to check just the bit 3. PS is a 4-bit register andregs->psalways will have bits 63..4 clear, so the open-code variant here is actually equivalent to !user_mode(regs). Harder to follow, though...
Quoted 3 lines
Reproducer above will crash any box where CLRFEN is not ignored by PAL (== any actual hardware, AFAICS; PAL used in qemu doesn't bother implementing that crap).
I didn't realize I'd forgotten this in qemu. Anyway,
r~
Quoted 26 lines · Richard Henderson
Quoted 25 lines · Al Viro
Type 3 instruction fault (FPU insn with FPU disabled) is handled by quietly enabling FPU and returning. Which is fine, except that we need to do that both for fault in userland and in the kernel; the latter *can* legitimately happen - all it takes is this:
.global
_start_start:call_pal 0xae lda $0, 0 ldq $0, 0($0)-
call_palCLRFEN to clear "FPU enabled" flag and arrange for a signal delivery (SIGSEGV in this case).Fixed by moving the handling of type 3 into the common part of
do_entIF(), before we check for kernel vs. user mode.Incidentally, check for kernel mode is unidiomatic; the normal way to do that is !user_mode(regs). The difference is that the open-coded variant treats any of bits 63..3 of
regs->psbeing set as "it's user mode" while the normal approach is to check just the bit 3. PS is a 4-bit register andregs->psalways will have bits 63..4 clear, so the open-code variant here is actually equivalent to !user_mode(regs). Harder to follow, though...
Quoted 7 lines
Quoted 3 lines
Reproducer above will crash any box where CLRFEN is not ignored by PAL (== any actual hardware, AFAICS; PAL used in qemu doesn't bother implementing that crap).
I didn't realize I'd forgotten this in qemu. Anyway,
Reviewed-by Richard Henderson <[email protected]>
Not sure it's worth bothering with in palcode-clipper - for Linux it's useless (run out of timeslice and FEN will end up set, no matter what), nothing in NetBSD or OpenBSD trees generates that call_pal, current FreeBSD doesn't support alpha and their last version to do so hadn't generated that call_pal either... What else is out there? OSF?
Quoted 5 lines · Al Viro
Not sure it's worth bothering with in palcode-clipper - for Linux it's useless (run out of timeslice and FEN will end up set, no matter what), nothing in NetBSD or OpenBSD trees generates that
call_pal, current FreeBSD doesn't support alpha and their last version to do so hadn't generated thatcall_paleither... What else is out there? OSF?
BTW, out of curiosity - what was
case 5: /* illoc */
default: /* unexpected instruction-fault type */
about in that switch in do_entIF()?
All documentation I'd been able to find had only 0..4 as expected values (bpt/bugcheck/gentrap/fen/opdec)...
Quoted 8 lines · Al Viro
Quoted 5 lines · Al Viro
Not sure it's worth bothering with in palcode-clipper - for Linux it's useless (run out of timeslice and FEN will end up set, no matter what), nothing in NetBSD or OpenBSD trees generates that
call_pal, current FreeBSD doesn't support alpha and their last version to do so hadn't generated thatcall_paleither... What else is out there? OSF?
Quoted 7 lines
BTW, out of curiosity - what was
case 5: /* illoc */
default: /* unexpected instruction-fault type */
about in that switch indo_entIF()?All documentation I'd been able to find had only 0..4 as expected values (bpt/bugcheck/gentrap/fen/opdec)...
No idea.
Historical git (cd52cb6178a7, v2.4.8 -> v2.4.8.1) suggests it's related to shark_mv, so perhaps a later revision of DEC PALcode. But I have no corresponding documentation.
r~