Skip to contentSkip to conversation

netlink: fix spelling mistake in dump size assert

PATCH Applied Jakub Kicinski 3 participants 3 messages Jan 23, 2023 – Jan 25, 2023

Subsystems (4)
lore
Share & tools
lore

Jakub Kicinski

author maintainer
#0 lore raw

PATCH 1/1 netlink: fix spelling mistake in dump size assert

Commit 2c7bc10d0f7b ("netlink: add macro for checking dump ctx size") misspelled the name of the assert as asset, missing an R.

---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]

---
 include/linux/netlink.h              | 2 +-
 net/devlink/devl_internal.h          | 2 +-
 net/netfilter/nf_conntrack_netlink.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
include/linux/netlink.h +1 -1
index 38f6334f408c..fa4d86da0ec7 100644
@@ -263,7 +263,7 @@ struct netlink_callback {
 	};
 };
 
-#define NL_ASSET_DUMP_CTX_FITS(type_name)				\
+#define NL_ASSERT_DUMP_CTX_FITS(type_name)				\
 	BUILD_BUG_ON(sizeof(type_name) >				\
 		     sizeof_field(struct netlink_callback, ctx))
 
net/devlink/devl_internal.h +1 -1
index 1aa1a9549549..d0d889038138 100644
@@ -135,7 +135,7 @@ int devlink_nl_instance_iter_dump(struct sk_buff *msg,
 static inline struct devlink_nl_dump_state *
 devlink_dump_state(struct netlink_callback *cb)
 {
-	NL_ASSET_DUMP_CTX_FITS(struct devlink_nl_dump_state);
+	NL_ASSERT_DUMP_CTX_FITS(struct devlink_nl_dump_state);
 
 	return (struct devlink_nl_dump_state *)cb->ctx;
 }
net/netfilter/nf_conntrack_netlink.c +1 -1
index 90672e293e57..308fc0023c7e 100644
@@ -3866,7 +3866,7 @@ static int __init ctnetlink_init(void)
 {
 	int ret;
 
-	NL_ASSET_DUMP_CTX_FITS(struct ctnetlink_list_dump_ctx);
+	NL_ASSERT_DUMP_CTX_FITS(struct ctnetlink_list_dump_ctx);
 
 	ret = nfnetlink_subsys_register(&ctnl_subsys);
 	if (ret < 0) {
Signature · 1 line
2.39.1
#2 lore raw
In reply to Jakub Kicinski
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:

Quoted 15 lines · On Mon, 23 Jan 2023 14:22:24 -0800 you wrote:

Commit 2c7bc10d0f7b ("netlink: add macro for checking dump ctx size") misspelled the name of the assert as asset, missing an R.

---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]

Quoted 1 line

[...]

Here is the summary with links:
- [net-next] netlink: fix spelling mistake in dump size assert

    https://git.kernel.org/netdev/net-next/c/ec8f7d495b3d

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html