Skip to contentSkip to conversation

serial: linflexuart: Remove redundant uart type assignment

PATCH In review 李哲 4 participants 4 messages Jan 5, 2023 – Jan 5, 2024 1 message not in the archive TTY layer and serial drivers

lore
Share & tools
lore

李哲

author
#0 lore raw

PATCH v6 1/1 serial: linflexuart: Remove redundant uart type assignment

in linflex_config_port() the member variable type will be assigned again. see linflex_connfig_port()

V4 -> V5: Link: https://lore.kernel.org/all/[email protected]/
V3 -> V4: Link: https://lore.kernel.org/all/[email protected]/
V2 -> V3: Link: https://lore.kernel.org/all/[email protected]/
V1 -> V2: Link: https://lore.kernel.org/all/[email protected]/

---
 drivers/tty/serial/fsl_linflexuart.c | 1 -
 1 file changed, 1 deletion(-)
drivers/tty/serial/fsl_linflexuart.c +0 -1
index 6fc21b6684e6..34400cc6ac7f 100644
@@ -837,7 +837,6 @@ static int linflex_probe(struct platform_device *pdev)
 		return PTR_ERR(sport->membase);
 
 	sport->dev = &pdev->dev;
-	sport->type = PORT_LINFLEXUART;
 	sport->iotype = UPIO_MEM;
 	sport->irq = platform_get_irq(pdev, 0);
 	sport->ops = &linflex_pops;
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 2 lines · 李哲

in linflex_config_port() the member variable type will be assigned again. see linflex_connfig_port()

I wrote to v5:
Please use capitals when you start a sentence. And periods at the ends of them.

Quoted 7 lines

V4 -> V5: Link: https://lore.kernel.org/all/[email protected]/
V3 -> V4: Link: https://lore.kernel.org/all/[email protected]/
V2 -> V3: Link: https://lore.kernel.org/all/[email protected]/
V1 -> V2: Link: https://lore.kernel.org/all/[email protected]/

This is not the proper way. PLease see:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format

Quoted 16 lines
---
  drivers/tty/serial/fsl_linflexuart.c | 1 -
  1 file changed, 1 deletion(-)
drivers/tty/serial/fsl_linflexuart.c +0 -1
index 6fc21b6684e6..34400cc6ac7f 100644
@@ -837,7 +837,6 @@ static int linflex_probe(struct platform_device *pdev)
  		return PTR_ERR(sport->membase);
 
  	sport->dev = &pdev->dev;
-	sport->type = PORT_LINFLEXUART;
  	sport->iotype = UPIO_MEM;
  	sport->irq = platform_get_irq(pdev, 0);
  	sport->ops = &linflex_pops;
Signature · 2 lines
js
suse labs

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw
Quoted 26 lines · lizhe

HI,all

       How should I wirte these comments ? please help me, i am not sure how to properly write these comments, i want to merge this patch into the mainline

Quoted 11 lines · Jiri Slaby
Quoted 2 lines · 李哲

in linflex_config_port() the member variable type will be assigned again. see linflex_connfig_port()

I wrote to v5:
Please use capitals when you start a sentence. And periods at the ends of them.

Quoted 4 lines

V4 -> V5: Link: https://lore.kernel.org/all/ddcf396b-7b91-00f3-8c16-7de5d

[email protected]/

Quoted 1 line
Quoted 1 line

V3 -> V4: Link: https://lore.kernel.org/all/2f726128-29c-b7dd-ad8-f8b536f

[email protected]/

Quoted 8 lines
Quoted 1 line
Quoted 1 line

V2 -> V3: Link: https://lore.kernel.org/all/8f433e5-fb46-d3b8-431b-4bddcc

[email protected]/

Quoted 1 line
Quoted 1 line

V1 -> V2: Link: https://lore.kernel.org/all/1c33a2af-cd0d-cdde-5bc7-49b41

[email protected]/

Quoted 3 lines

This is not the proper way. PLease see:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-

canonical-patch-format

For this you need to spell out the changes you made between versions.

E.g.,

v6:
- Used Chinese letters for From and Signed-off-by

Signature · 1 line
 i.
maintainer
#4 lore raw
In reply to 李哲
Quoted 8 lines · 李哲

in linflex_config_port() the member variable type will be assigned again. see linflex_connfig_port()

V4 -> V5: Link: https://lore.kernel.org/all/[email protected]/
V3 -> V4: Link: https://lore.kernel.org/all/[email protected]/
V2 -> V3: Link: https://lore.kernel.org/all/[email protected]/
V1 -> V2: Link: https://lore.kernel.org/all/[email protected]/

Links are not ok for versioning, sorry, please read the documentation for how to do this properly.

greg k-h