linux-next: build warning after merge of the workqueues tree
Hi all,
After merging the workqueues tree, today's linux-next build (x86_64 allnoconfig and several others) produced this warning:
kernel/workqueue.c:1993:13: warning: 'rebind_worker' defined but not used [-Wunused-function]
1993 | static void rebind_worker(struct worker *worker, struct worker_pool *pool)
| ^~~~~~~~~~~~~
Introduced by commit
793777bc193b ("workqueue: Factorize unbind/rebind_workers() logic")
Signature · 2 lines
Cheers, Stephen Rothwell
Quoted 5 lines · Stephen Rothwell
Hi all,
After merging the workqueues tree, today's linux-next build (
x86_64allnoconfig and several others) produced this warning:
Quoted 7 lines
kernel/workqueue.c:1993:13: warning: 'rebind_worker' defined but not used [-Wunused-function]
1993 | static voidrebind_worker(struct worker *worker, struct worker_pool *pool)| ^~~~~~~~~~~~~Introduced by commit
793777bc193b("workqueue: Factorize unbind/rebind_workers() logic")
Valentin, this is caused by rebind_worker() being only used by rebind_workers() which is inside CONFIG_SMP. I don't see any other uses of rebind_worker(). Just fold it back into rebind_workers()?
Thanks.
Signature · 1 line
tejun
Quoted 10 lines · Tejun Heo
Quoted 9 lines · Stephen Rothwell
Hi all,
After merging the workqueues tree, today's linux-next build (
x86_64allnoconfig and several others) produced this warning:
kernel/workqueue.c:1993:13: warning: 'rebind_worker' defined but not used [-Wunused-function]
1993 | static voidrebind_worker(struct worker *worker, struct worker_pool *pool)| ^~~~~~~~~~~~~
Quoted 8 lines
Quoted 3 lines
Introduced by commit
793777bc193b("workqueue: Factorize unbind/rebind_workers() logic")Valentin, this is caused by
rebind_worker()being only used byrebind_workers()which is insideCONFIG_SMP. I don't see any other uses ofrebind_worker(). Just fold it back intorebind_workers()?
Woops! Yes I only did it to keep things aligned with unbind_workers(), let me resend with that folded back in. Sorry!
Quoted 4 lines
Thanks.
--
tejun
Quoted 15 lines · Valentin Schneider
Quoted 14 lines · Tejun Heo
Quoted 12 lines · Stephen Rothwell
Hi all,
After merging the workqueues tree, today's linux-next build (
x86_64allnoconfig and several others) produced this warning:
kernel/workqueue.c:1993:13: warning: 'rebind_worker' defined but not used [-Wunused-function]
1993 | static voidrebind_worker(struct worker *worker, struct worker_pool *pool)| ^~~~~~~~~~~~~Introduced by commit
793777bc193b("workqueue: Factorize unbind/rebind_workers() logic")
Quoted 8 lines
Quoted 4 lines
Valentin, this is caused by
rebind_worker()being only used byrebind_workers()which is insideCONFIG_SMP. I don't see any other uses ofrebind_worker(). Just fold it back intorebind_workers()?Woops! Yes I only did it to keep things aligned with
unbind_workers(), let me resend with that folded back in. Sorry!
Unless you'd prefer a fixup patch on top of those you've already picked up?
Quoted 4 lines
Quoted 4 lines
Thanks.
--
tejun
Quoted 21 lines · Valentin Schneider
Quoted 20 lines · Valentin Schneider
Quoted 18 lines · Tejun Heo
Quoted 5 lines · Stephen Rothwell
Hi all,
After merging the workqueues tree, today's linux-next build (
x86_64allnoconfig and several others) produced this warning:Quoted 7 lines
kernel/workqueue.c:1993:13: warning: 'rebind_worker' defined but not used [-Wunused-function]
1993 | static voidrebind_worker(struct worker *worker, struct worker_pool *pool)| ^~~~~~~~~~~~~Introduced by commit
793777bc193b("workqueue: Factorize unbind/rebind_workers() logic")Valentin, this is caused by
rebind_worker()being only used byrebind_workers()which is insideCONFIG_SMP. I don't see any other uses ofrebind_worker(). Just fold it back intorebind_workers()?
Quoted 5 lines
Quoted 3 lines
Woops! Yes I only did it to keep things aligned with
unbind_workers(), let me resend with that folded back in. Sorry!Unless you'd prefer a fixup patch on top of those you've already picked up?
Yeah, just send another patch to fold it back in.
Thanks.
Signature · 1 line
tejun