xfs/440: skip test if the dax mount option is enabled
PATCH 1/1 xfs/440: skip test if the dax mount option is enabled
With the enabled dax mount option, this test doesn't work well because unwritten extents will not be allocated according to the CoW extent size hint.
Try to fix the following error by the patch:
$./check xfs/440
...
fsgqa 64 0 0
Reflink and CoW
root 0 0 0
-fsgqa 1152 0 0
+fsgqa 128 0 0
Sync
root 0 0 0
...--- tests/xfs/440 | 1 + 1 file changed, 1 insertion(+)
tests/xfs/440 +1 -0
@@ -23,6 +23,7 @@ _require_quota _require_scratch_reflink _require_cp_reflink _require_user +_exclude_scratch_mount_option dax echo "Format and mount" _scratch_mkfs > "$seqres.full" 2>&1
Signature · 1 line
2.25.1
Hi Darrick,
Is there any comment on the patch?
Best Regards,
Xiao Yang
-----Original Message-----
From: Yang, Xiao/杨 晓 <[email protected]>
Sent: 2022年12月23日 18:22
To: [email protected]; [email protected]
Cc: [email protected]; Yang, Xiao/杨 晓 <[email protected]>
Subject: [PATCH] xfs/440: skip test if the dax mount option is enabled
With the enabled dax mount option, this test doesn't work well because unwritten extents will not be allocated according to the CoW extent size hint.
Try to fix the following error by the patch:
$./check xfs/440
...
fsgqa 64 0 0
Reflink and CoW
root 0 0 0
-fsgqa 1152 0 0
+fsgqa 128 0 0
Sync
root 0 0 0
...--- tests/xfs/440 | 1 + 1 file changed, 1 insertion(+)
tests/xfs/440 +1 -0
@@ -23,6 +23,7 @@ _require_quota _require_scratch_reflink _require_cp_reflink _require_user +_exclude_scratch_mount_option dax echo "Format and mount" _scratch_mkfs > "$seqres.full" 2>&1
--
2.25.1
Quoted 3 lines · On Fri, Jan 13, 2023 at 04:53:41AM +0000, [email protected] wrote:
Hi Darrick,
Is there any comment on the patch?
What happens if you set DAXINHERIT on the root directory and omit the mount options? Does it still fail?
--D
Quoted 43 lines
Best Regards,
Xiao Yang-----Original Message-----
From: Yang, Xiao/杨 晓 <[email protected]>
Sent: 2022年12月23日 18:22
To: [email protected]; [email protected]
Cc: [email protected]; Yang, Xiao/杨 晓 <[email protected]>
Subject: [PATCH] xfs/440: skip test if the dax mount option is enabledWith the enabled dax mount option, this test doesn't work well because unwritten extents will not be allocated according to the CoW extent size hint.
Try to fix the following error by the patch:
$./check xfs/440... fsgqa 64 0 0 Reflink and CoW root 0 0 0 -fsgqa 1152 0 0 +fsgqa 128 0 0 Sync root 0 0 0 ...Signed-off-by Xiao Yang <[email protected]>--- tests/xfs/440 | 1 + 1 file changed, 1 insertion(+)tests/xfs/440 +1
-1@@ -23,6 +23,7 @@ _require_quota _require_scratch_reflink _require_cp_reflink _require_user +_exclude_scratch_mount_option dax echo "Format and mount" _scratch_mkfs > "$seqres.full" 2>&1 --2.25.1
Quoted 6 lines · Darrick J. Wong
Quoted 3 lines · On Fri, Jan 13, 2023 at 04:53:41AM +0000,[email protected] wrote:
Hi Darrick,
Is there any comment on the patch?
What happens if you set DAXINHERIT on the root directory and omit the mount options? Does it still fail?
Hi Darrick,
Yes, it still failed. I have reviewed your patch set fixing the issue.
Thanks a lot.
Best Regards,
Xiao Yang
Quoted 4 lines
--D
Quoted 6 lines · Darrick J. Wong
Quoted 3 lines · On Fri, Jan 13, 2023 at 04:53:41AM +0000,[email protected] wrote:
Hi Darrick,
Is there any comment on the patch?
What happens if you set DAXINHERIT on the root directory and omit the mount options? Does it still fail?
Hi Darrick,
Yes, it still failed. I have reviewed your patch set fixing the issue.
Thanks a lot.
Best Regards,
Xiao Yang
Quoted 4 lines
--D