Skip to contentSkip to conversation

printk: Use scnprintf() to print the message about the dropped messages on a console

PATCH In review Petr Mladek 3 participants 4 messages Jan 17, 2023 – Jan 18, 2023

Subsystems (2)
lore
Share & tools
lore

Petr Mladek

author maintainer
#0 lore raw

PATCH 1/1 printk: Use scnprintf() to print the message about the dropped messages on a console

Use scnprintf() for printing the message about dropped messages on a console. It returns the really written length of the message. It prevents potential buffer overflow when the returned length is later used to copy the buffer content.

Note that the previous code was safe because the scratch buffer was big enough and the message always fit in. But scnprintf() makes it more safe, definitely.

Addresses-Coverity-ID: 1530570 ("Memory - corruptions")

Fixes c4fcc617e148 ("printk: introduce console_prepend_dropped() for dropped messages")
---
 kernel/printk/printk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/printk/printk.c +1 -1
index 55338bfd3b55..a9b7dade0d2e 100644
@@ -2716,7 +2716,7 @@ static void console_prepend_dropped(struct printk_message *pmsg, unsigned long d
 	char *outbuf = &pbufs->outbuf[0];
 	size_t len;
 
-	len = snprintf(scratchbuf, scratchbuf_sz,
+	len = scnprintf(scratchbuf, scratchbuf_sz,
 		       "** %lu printk messages dropped **\n", dropped);
 
 	/*
Signature · 1 line
2.35.3
reviewer Reviewed-by
#2 lore raw
Quoted 8 lines · John Ogness
Quoted 5 lines · Petr Mladek

Addresses-Coverity-ID: 1530570 ("Memory - corruptions")

Fixes c4fcc617e148 ("printk: introduce console_prepend_dropped() for dropped messages")
author maintainer
#3 lore raw
In reply to Petr Mladek
Quoted 9 lines · Petr Mladek

Use scnprintf() for printing the message about dropped messages on a console. It returns the really written length of the message. It prevents potential buffer overflow when the returned length is later used to copy the buffer content.

Note that the previous code was safe because the scratch buffer was big enough and the message always fit in. But scnprintf() makes it more safe, definitely.

Quoted 5 lines

Addresses-Coverity-ID: 1530570 ("Memory - corruptions")

Fixes c4fcc617e148 ("printk: introduce console_prepend_dropped() for dropped messages")

JFYI, the patch has been comitted into printk/linux.git, branch rework/buffers-cleanup.

Best Regards,
Petr